All of lore.kernel.org
 help / color / mirror / Atom feed
From: dcashman@android.com (Daniel Cashman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.
Date: Wed, 4 Nov 2015 11:36:07 -0800	[thread overview]
Message-ID: <563A5E27.2060607@android.com> (raw)
In-Reply-To: <877flxo9j5.fsf@x220.int.ebiederm.org>

On 11/4/15 11:21 AM, Eric W. Biederman wrote:
> Michal Hocko <mhocko@kernel.org> writes:
> 
>> On Tue 03-11-15 10:10:03, Daniel Cashman wrote:
>> [...]
>>> +This value can be changed after boot using the
>>> +/proc/sys/kernel/mmap_rnd_bits tunable
>>
>> Why is this not sitting in /proc/sys/vm/ where we already have
>> mmap_min_addr. These two sound like they should sit together, no?
> 
> Ugh.  Yes.  Moving that file before it becomes part of the ABI sounds
> like a good idea.  Daniel when you get around to v3 please move the
> file.

To answer the first question: it was put there because that's where
randomize_va_space is located, which seemed to me to be the
most-related/similar option.  That being said, moving it under vm works
too.  Will change for patch-set 3.

Thank You,
Dan

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Cashman <dcashman@android.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
	Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	akpm@linux-foundation.org, keescook@chromium.org,
	mingo@kernel.org, linux-arm-kernel@lists.infradead.org,
	corbet@lwn.net, dzickus@redhat.com, xypron.glpk@gmx.de,
	jpoimboe@redhat.com, kirill.shutemov@linux.intel.com,
	n-horiguchi@ah.jp.nec.com, aarcange@redhat.com, mgorman@suse.de,
	tglx@linutronix.de, rientjes@google.com, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, salyzyn@android.com, jeffv@google.com,
	nnk@google.com, dcashman <dcashman@google.com>
Subject: Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.
Date: Wed, 4 Nov 2015 11:36:07 -0800	[thread overview]
Message-ID: <563A5E27.2060607@android.com> (raw)
In-Reply-To: <877flxo9j5.fsf@x220.int.ebiederm.org>

On 11/4/15 11:21 AM, Eric W. Biederman wrote:
> Michal Hocko <mhocko@kernel.org> writes:
> 
>> On Tue 03-11-15 10:10:03, Daniel Cashman wrote:
>> [...]
>>> +This value can be changed after boot using the
>>> +/proc/sys/kernel/mmap_rnd_bits tunable
>>
>> Why is this not sitting in /proc/sys/vm/ where we already have
>> mmap_min_addr. These two sound like they should sit together, no?
> 
> Ugh.  Yes.  Moving that file before it becomes part of the ABI sounds
> like a good idea.  Daniel when you get around to v3 please move the
> file.

To answer the first question: it was put there because that's where
randomize_va_space is located, which seemed to me to be the
most-related/similar option.  That being said, moving it under vm works
too.  Will change for patch-set 3.

Thank You,
Dan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Cashman <dcashman@android.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
	Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	akpm@linux-foundation.org, keescook@chromium.org,
	mingo@kernel.org, linux-arm-kernel@lists.infradead.org,
	corbet@lwn.net, dzickus@redhat.com, xypron.glpk@gmx.de,
	jpoimboe@redhat.com, kirill.shutemov@linux.intel.com,
	n-horiguchi@ah.jp.nec.com, aarcange@redhat.com, mgorman@suse.de,
	tglx@linutronix.de, rientjes@google.com, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, salyzyn@android.com, jeffv@google.com,
	nnk@google.com, dcashman <dcashman@google.com>
Subject: Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.
Date: Wed, 4 Nov 2015 11:36:07 -0800	[thread overview]
Message-ID: <563A5E27.2060607@android.com> (raw)
In-Reply-To: <877flxo9j5.fsf@x220.int.ebiederm.org>

On 11/4/15 11:21 AM, Eric W. Biederman wrote:
> Michal Hocko <mhocko@kernel.org> writes:
> 
>> On Tue 03-11-15 10:10:03, Daniel Cashman wrote:
>> [...]
>>> +This value can be changed after boot using the
>>> +/proc/sys/kernel/mmap_rnd_bits tunable
>>
>> Why is this not sitting in /proc/sys/vm/ where we already have
>> mmap_min_addr. These two sound like they should sit together, no?
> 
> Ugh.  Yes.  Moving that file before it becomes part of the ABI sounds
> like a good idea.  Daniel when you get around to v3 please move the
> file.

To answer the first question: it was put there because that's where
randomize_va_space is located, which seemed to me to be the
most-related/similar option.  That being said, moving it under vm works
too.  Will change for patch-set 3.

Thank You,
Dan


  reply	other threads:[~2015-11-04 19:36 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 18:10 [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR Daniel Cashman
2015-11-03 18:10 ` Daniel Cashman
2015-11-03 18:10 ` Daniel Cashman
2015-11-03 18:10 ` [PATCH v2 2/2] arm: mm: support ARCH_MMAP_RND_BITS Daniel Cashman
2015-11-03 18:10   ` Daniel Cashman
2015-11-03 18:10   ` Daniel Cashman
2015-11-03 19:19   ` Kees Cook
2015-11-03 19:19     ` Kees Cook
2015-11-03 19:19     ` Kees Cook
2015-11-03 22:39     ` Russell King - ARM Linux
2015-11-03 22:39       ` Russell King - ARM Linux
2015-11-03 22:39       ` Russell King - ARM Linux
2015-11-03 23:18       ` Kees Cook
2015-11-03 23:18         ` Kees Cook
2015-11-03 23:18         ` Kees Cook
2015-11-04 18:22         ` Daniel Cashman
2015-11-04 18:22           ` Daniel Cashman
2015-11-04 18:22           ` Daniel Cashman
2015-11-03 23:14     ` Daniel Cashman
2015-11-03 23:14       ` Daniel Cashman
2015-11-03 23:14       ` Daniel Cashman
2015-11-03 23:21       ` Kees Cook
2015-11-03 23:21         ` Kees Cook
2015-11-03 23:21         ` Kees Cook
2015-11-04 18:30         ` Daniel Cashman
2015-11-04 18:30           ` Daniel Cashman
2015-11-04 18:30           ` Daniel Cashman
2015-11-05 18:44           ` Daniel Cashman
2015-11-05 18:44             ` Daniel Cashman
2015-11-05 18:44             ` Daniel Cashman
2015-11-06 20:52             ` Kees Cook
2015-11-06 20:52               ` Kees Cook
2015-11-06 20:52               ` Kees Cook
2015-11-09  3:47               ` Michael Ellerman
2015-11-09  3:47                 ` Michael Ellerman
2015-11-09  3:47                 ` Michael Ellerman
2015-11-09 18:56                 ` Daniel Cashman
2015-11-09 18:56                   ` Daniel Cashman
2015-11-09 18:56                   ` Daniel Cashman
2015-11-09 21:27                   ` Kees Cook
2015-11-09 21:27                     ` Kees Cook
2015-11-09 21:27                     ` Kees Cook
2015-11-03 19:16 ` [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR Kees Cook
2015-11-03 19:16   ` Kees Cook
2015-11-03 19:16   ` Kees Cook
2015-11-04  0:04 ` Andrew Morton
2015-11-04  0:04   ` Andrew Morton
2015-11-04  0:04   ` Andrew Morton
2015-11-04  0:40   ` Eric W. Biederman
2015-11-04  0:40     ` Eric W. Biederman
2015-11-04  0:40     ` Eric W. Biederman
2015-11-04  1:31     ` Andrew Morton
2015-11-04  1:31       ` Andrew Morton
2015-11-04  1:31       ` Andrew Morton
2015-11-04 19:31       ` Daniel Cashman
2015-11-04 19:31         ` Daniel Cashman
2015-11-04 19:31         ` Daniel Cashman
2015-11-04 22:00         ` Andrew Morton
2015-11-04 22:00           ` Andrew Morton
2015-11-04 22:00           ` Andrew Morton
2015-11-04 22:10         ` Eric W. Biederman
2015-11-04 22:10           ` Eric W. Biederman
2015-11-04 22:10           ` Eric W. Biederman
2015-11-04 22:37           ` Kees Cook
2015-11-04 22:37             ` Kees Cook
2015-11-04 22:37             ` Kees Cook
2015-11-04  9:39 ` Michal Hocko
2015-11-04  9:39   ` Michal Hocko
2015-11-04  9:39   ` Michal Hocko
2015-11-04 19:21   ` Eric W. Biederman
2015-11-04 19:21     ` Eric W. Biederman
2015-11-04 19:21     ` Eric W. Biederman
2015-11-04 19:36     ` Daniel Cashman [this message]
2015-11-04 19:36       ` Daniel Cashman
2015-11-04 19:36       ` Daniel Cashman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563A5E27.2060607@android.com \
    --to=dcashman@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.