From: "Christian König" <deathsimple@vodafone.de>
To: "Michel Dänzer" <michel@daenzer.net>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/radeon: Disable uncacheable CPU mappings of GTT with RV6xx
Date: Thu, 5 Nov 2015 11:41:26 +0100 [thread overview]
Message-ID: <563B3256.7000509@vodafone.de> (raw)
In-Reply-To: <1446711928-14788-1-git-send-email-michel@daenzer.net>
On 05.11.2015 09:25, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> They reportedly cause random GPU hangs.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91268
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
For this series Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_object.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index d302488..a35f5af 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -221,6 +221,12 @@ int radeon_bo_create(struct radeon_device *rdev,
> if (!(rdev->flags & RADEON_IS_PCIE))
> bo->flags &= ~(RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC);
>
> + /* Write-combined CPU mappings of GTT cause GPU hangs with RV6xx
> + * See https://bugs.freedesktop.org/show_bug.cgi?id=91268
> + */
> + if (rdev->family >= CHIP_RV610 && rdev->family <= CHIP_RV635)
> + bo->flags &= ~(RADEON_GEM_GTT_WC | RADEON_GEM_GTT_UC);
> +
> #ifdef CONFIG_X86_32
> /* XXX: Write-combined CPU mappings of GTT seem broken on 32-bit
> * See https://bugs.freedesktop.org/show_bug.cgi?id=84627
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-11-05 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 8:25 [PATCH 1/3] drm/radeon: Disable uncacheable CPU mappings of GTT with RV6xx Michel Dänzer
2015-11-05 8:25 ` [PATCH 2/3] drm/radeon: Always disable RADEON_GEM_GTT_UC along with RADEON_GEM_GTT_WC Michel Dänzer
2015-11-05 8:25 ` [PATCH 3/3] drm/radeon: Only prompt for enabling PAT when we'd allow write-combining Michel Dänzer
2015-11-05 10:41 ` Christian König [this message]
2015-11-05 19:03 ` [PATCH 1/3] drm/radeon: Disable uncacheable CPU mappings of GTT with RV6xx Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B3256.7000509@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.