From: "Andreas Färber" <afaerber@suse.de>
To: Wei Huang <wei@redhat.com>, qemu-arm@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Remove the definition of NUM_CPU
Date: Thu, 5 Nov 2015 18:13:44 +0100 [thread overview]
Message-ID: <563B8E48.8020407@suse.de> (raw)
In-Reply-To: <1446743477-21579-1-git-send-email-wei@redhat.com>
Am 05.11.2015 um 18:11 schrieb Wei Huang:
> arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu.
> Such mixed-uses make source code inconsistent. This patch removes
> NUM_CPU(s), which was defined for MPCore tweak long ago, and instead
> favors s->num_cpu. The source is more consistent after this tweak.
>
> Signed-off-by: Wei Huang <wei@redhat.com>
> ---
> hw/intc/arm_gic.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
I don't mind either way, and it'll go through Peter's queue I guess,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Wei Huang <wei@redhat.com>, qemu-arm@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH Trivial] hw/intc/arm_gic: Remove the definition of NUM_CPU
Date: Thu, 5 Nov 2015 18:13:44 +0100 [thread overview]
Message-ID: <563B8E48.8020407@suse.de> (raw)
In-Reply-To: <1446743477-21579-1-git-send-email-wei@redhat.com>
Am 05.11.2015 um 18:11 schrieb Wei Huang:
> arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu.
> Such mixed-uses make source code inconsistent. This patch removes
> NUM_CPU(s), which was defined for MPCore tweak long ago, and instead
> favors s->num_cpu. The source is more consistent after this tweak.
>
> Signed-off-by: Wei Huang <wei@redhat.com>
> ---
> hw/intc/arm_gic.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
I don't mind either way, and it'll go through Peter's queue I guess,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-11-05 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 17:11 [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Remove the definition of NUM_CPU Wei Huang
2015-11-05 17:11 ` [Qemu-devel] " Wei Huang
2015-11-05 17:11 ` [Qemu-arm] " Wei Huang
2015-11-05 17:13 ` Andreas Färber [this message]
2015-11-05 17:13 ` [Qemu-devel] " Andreas Färber
2015-11-05 17:22 ` [Qemu-trivial] " Wei Huang
2015-11-05 17:22 ` [Qemu-devel] " Wei Huang
2015-11-05 17:22 ` [Qemu-arm] " Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B8E48.8020407@suse.de \
--to=afaerber@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.