From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()
Date: Thu, 05 Nov 2015 17:19:17 +0000 [thread overview]
Message-ID: <563B8F95.9000507@cogentembedded.com> (raw)
In-Reply-To: <20151105.111348.1315362570048541764.davem@davemloft.net>
Hello.
On 11/05/2015 07:13 PM, David Miller wrote:
>>>> While the ring allocation is done by a single function,
>>>> sh_eth_ring_init(),
>>>> the ring deallocation was split into two functions (almost always
>>>> called
>>>> one after the other) for no good reason. Merge
>>>> sh_eth_free_dma_buffer()
>>>> into sh_eth_ring_free() which allows us to save space not only on the
>>>> direct calls of the former function but also on the
>>>> sh_eth_ring_init()'s
>>>> simplified error path...
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> Applied.
>>
>> Hum, I'm seeing both patches in the net.git repo, while they were
>> clearly targeted to net-next.git... Did you really consider these 2
>> patches fixes?
>
> It was more work for me to let the patches rot in patchwork until I openned
> net-next back up than to simply just apply them to net.
OK, thank you!
> You guys really make an enormous amount of work and stress for me when you
> submit net-next patches when I _CLEARLY_ and _EXPLICITLY_ state that the
> tree is closed right now.
Hmm, I hadn't seen your announcement, else I would have refrained from
sending. Will look for it now...
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free()
Date: Thu, 5 Nov 2015 20:19:17 +0300 [thread overview]
Message-ID: <563B8F95.9000507@cogentembedded.com> (raw)
In-Reply-To: <20151105.111348.1315362570048541764.davem@davemloft.net>
Hello.
On 11/05/2015 07:13 PM, David Miller wrote:
>>>> While the ring allocation is done by a single function,
>>>> sh_eth_ring_init(),
>>>> the ring deallocation was split into two functions (almost always
>>>> called
>>>> one after the other) for no good reason. Merge
>>>> sh_eth_free_dma_buffer()
>>>> into sh_eth_ring_free() which allows us to save space not only on the
>>>> direct calls of the former function but also on the
>>>> sh_eth_ring_init()'s
>>>> simplified error path...
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> Applied.
>>
>> Hum, I'm seeing both patches in the net.git repo, while they were
>> clearly targeted to net-next.git... Did you really consider these 2
>> patches fixes?
>
> It was more work for me to let the patches rot in patchwork until I openned
> net-next back up than to simply just apply them to net.
OK, thank you!
> You guys really make an enormous amount of work and stress for me when you
> submit net-next patches when I _CLEARLY_ and _EXPLICITLY_ state that the
> tree is closed right now.
Hmm, I hadn't seen your announcement, else I would have refrained from
sending. Will look for it now...
MBR, Sergei
next prev parent reply other threads:[~2015-11-05 17:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 21:55 [PATCH] sh_eth: merge sh_eth_free_dma_buffer() into sh_eth_ring_free() Sergei Shtylyov
2015-11-03 21:55 ` Sergei Shtylyov
2015-11-05 1:59 ` David Miller
2015-11-05 1:59 ` David Miller
2015-11-05 12:53 ` Sergei Shtylyov
2015-11-05 12:53 ` Sergei Shtylyov
2015-11-05 16:13 ` David Miller
2015-11-05 16:13 ` David Miller
2015-11-05 17:19 ` Sergei Shtylyov [this message]
2015-11-05 17:19 ` Sergei Shtylyov
2015-11-05 17:42 ` Sergei Shtylyov
2015-11-05 17:42 ` Sergei Shtylyov
2015-11-05 18:29 ` David Miller
2015-11-05 18:29 ` David Miller
2015-11-05 18:38 ` Sergei Shtylyov
2015-11-05 18:38 ` Sergei Shtylyov
2015-11-05 18:58 ` Dave Jones
2015-11-05 18:58 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B8F95.9000507@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.