From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] regulator: tps65912: Add regulator driver for the TPS65912 PMIC
Date: Thu, 5 Nov 2015 12:04:00 -0600 [thread overview]
Message-ID: <563B9A10.4020907@ti.com> (raw)
In-Reply-To: <20151105101417.GM1717@sirena.org.uk>
On 11/05/2015 04:14 AM, Mark Brown wrote:
> On Wed, Nov 04, 2015 at 09:35:26AM -0600, Andrew F. Davis wrote:
>
>> Something I just noticed, when I remove this table, module loading stops
>> working, even with 'MODULE_ALIAS("platform:tps65912-regulator");'. It
>> looks like when DT is enabled platform_uevent (drivers/base/platform.c:787)
>> only sends out the OF MODALIAS event then returns, not sending out the
>> platform event, is this desired behavior? If so then I will need this
>> table even though I still create the device and match it on platform
>> name as you suggested.
>
> That sounds like a bug to me, it'll have broken a bunch of existing
> devices.
>
Most OF drivers have the OF MODALIAS.
'platform_uevent' can only emit one MODALIAS string per device (only
the last emitted one seems to count), so for any device with
'dev->of_node' set it will be the OF MODALIAS string. So I need
that table (to generate the OF MODALIAS) or this sub-device module
will not be loaded.
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 4/5] regulator: tps65912: Add regulator driver for the TPS65912 PMIC
Date: Thu, 5 Nov 2015 12:04:00 -0600 [thread overview]
Message-ID: <563B9A10.4020907@ti.com> (raw)
In-Reply-To: <20151105101417.GM1717@sirena.org.uk>
On 11/05/2015 04:14 AM, Mark Brown wrote:
> On Wed, Nov 04, 2015 at 09:35:26AM -0600, Andrew F. Davis wrote:
>
>> Something I just noticed, when I remove this table, module loading stops
>> working, even with 'MODULE_ALIAS("platform:tps65912-regulator");'. It
>> looks like when DT is enabled platform_uevent (drivers/base/platform.c:787)
>> only sends out the OF MODALIAS event then returns, not sending out the
>> platform event, is this desired behavior? If so then I will need this
>> table even though I still create the device and match it on platform
>> name as you suggested.
>
> That sounds like a bug to me, it'll have broken a bunch of existing
> devices.
>
Most OF drivers have the OF MODALIAS.
'platform_uevent' can only emit one MODALIAS string per device (only
the last emitted one seems to count), so for any device with
'dev->of_node' set it will be the OF MODALIAS string. So I need
that table (to generate the OF MODALIAS) or this sub-device module
will not be loaded.
next prev parent reply other threads:[~2015-11-05 18:04 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 20:37 [PATCH v4 0/5] mfd: tps65912: Driver rewrite with DT support Andrew F. Davis
2015-10-01 20:37 ` Andrew F. Davis
2015-10-01 20:37 ` [PATCH v4 1/5] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC Andrew F. Davis
2015-10-01 20:37 ` Andrew F. Davis
2015-10-01 20:37 ` [PATCH v4 2/5] mfd: tps65912: Remove old driver in preparation for new driver Andrew F. Davis
2015-10-01 20:37 ` Andrew F. Davis
2015-10-05 9:28 ` Lee Jones
2015-10-05 9:29 ` Lee Jones
2015-10-05 9:29 ` Lee Jones
2015-10-05 16:01 ` Andrew F. Davis
2015-10-05 16:01 ` Andrew F. Davis
2015-10-01 20:37 ` [PATCH v4 3/5] mfd: tps65912: Add driver for the TPS65912 PMIC Andrew F. Davis
2015-10-01 20:37 ` Andrew F. Davis
[not found] ` <1443731874-21362-4-git-send-email-afd-l0cyMroinI0@public.gmane.org>
2015-10-01 20:51 ` kbuild test robot
2015-10-01 20:51 ` kbuild test robot
[not found] ` <20151002095859.GN12635@sirena.org.uk>
2015-10-02 13:32 ` [lkp] " Fengguang Wu
2015-10-02 13:47 ` Mark Brown
2015-10-01 20:57 ` kbuild test robot
2015-10-01 20:57 ` kbuild test robot
2015-10-01 20:57 ` kbuild test robot
2015-10-01 20:57 ` kbuild test robot
2015-10-01 23:49 ` Andrew F. Davis
2015-10-01 23:49 ` Andrew F. Davis
2015-10-05 9:24 ` Lee Jones
2015-10-05 9:27 ` Lee Jones
2015-10-12 15:06 ` Andrew F. Davis
2015-10-12 15:06 ` Andrew F. Davis
[not found] ` <561BCC8A.3090402-l0cyMroinI0@public.gmane.org>
2015-10-13 7:34 ` Lee Jones
2015-10-13 7:34 ` Lee Jones
2015-10-01 20:37 ` [PATCH v4 4/5] regulator: tps65912: Add regulator " Andrew F. Davis
2015-10-01 20:37 ` Andrew F. Davis
2015-10-02 19:21 ` Grygorii Strashko
2015-10-02 19:21 ` Grygorii Strashko
2015-10-22 16:47 ` Mark Brown
[not found] ` <20151022164724.GZ8232-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-23 12:46 ` Andrew F. Davis
2015-10-23 12:46 ` Andrew F. Davis
2015-10-23 23:18 ` Mark Brown
2015-10-24 0:11 ` Andrew F. Davis
2015-10-24 0:11 ` Andrew F. Davis
[not found] ` <562ACCCC.503-l0cyMroinI0@public.gmane.org>
2015-10-24 22:14 ` Mark Brown
2015-10-24 22:14 ` Mark Brown
[not found] ` <20151024221457.GS29919-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-25 20:45 ` Andrew F. Davis
2015-10-25 20:45 ` Andrew F. Davis
[not found] ` <562D3F77.5040205-l0cyMroinI0@public.gmane.org>
2015-10-26 0:43 ` Mark Brown
2015-10-26 0:43 ` Mark Brown
2015-10-26 15:47 ` Andrew F. Davis
2015-10-26 15:47 ` Andrew F. Davis
[not found] ` <562E4B1D.4060205-l0cyMroinI0@public.gmane.org>
2015-10-27 0:16 ` Mark Brown
2015-10-27 0:16 ` Mark Brown
[not found] ` <20151027001608.GJ28319-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-27 14:23 ` Andrew F. Davis
2015-10-27 14:23 ` Andrew F. Davis
2015-11-04 15:35 ` Andrew F. Davis
2015-11-04 15:35 ` Andrew F. Davis
2015-11-05 10:14 ` Mark Brown
2015-11-05 18:04 ` Andrew F. Davis [this message]
2015-11-05 18:04 ` Andrew F. Davis
2015-11-06 10:43 ` Mark Brown
2015-11-06 18:10 ` Andrew F. Davis
2015-11-06 18:10 ` Andrew F. Davis
2015-11-06 21:16 ` Mark Brown
[not found] ` <20151106211651.GJ18409-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-11-09 17:41 ` Andrew F. Davis
2015-11-09 17:41 ` Andrew F. Davis
2015-11-10 9:57 ` Mark Brown
2015-11-10 16:47 ` Andrew F. Davis
2015-11-10 16:47 ` Andrew F. Davis
2015-11-10 17:04 ` Mark Brown
2015-11-10 17:52 ` Andrew F. Davis
2015-11-10 17:52 ` Andrew F. Davis
2015-11-10 18:44 ` Mark Brown
2015-11-10 19:40 ` Andrew F. Davis
2015-11-10 19:40 ` Andrew F. Davis
[not found] ` <56424836.7000608-l0cyMroinI0@public.gmane.org>
2015-11-16 18:23 ` Mark Brown
2015-11-16 18:23 ` Mark Brown
2015-10-01 20:37 ` [PATCH v4 5/5] gpio: tps65912: Add GPIO " Andrew F. Davis
2015-10-01 20:37 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563B9A10.4020907@ti.com \
--to=afd@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.