All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Wanpeng Li <wanpeng.li@hotmail.com>,
	Andi Kleen <andi@firstfloor.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Hugh Dickins <hughd@google.com>, Minchan Kim <minchan@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v1] mm: hwpoison: adjust for new thp refcounting
Date: Fri, 6 Nov 2015 01:31:49 -0500	[thread overview]
Message-ID: <563C4955.3000300@oracle.com> (raw)
In-Reply-To: <1446790309-15683-1-git-send-email-n-horiguchi@ah.jp.nec.com>

On 11/06/2015 01:11 AM, Naoya Horiguchi wrote:
> In the new refcounting, we no longer use tail->_mapcount to keep tail's
> refcount, and thereby we can simplify get_hwpoison_page() and remove
> put_hwpoison_page() (by replacing with put_page()).

This is confusing for the reader (and some static analysis tools): this adds
put_page()s without corresponding get_page()s.

Could we instead macro put_hwpoison_page() as put_page() for the sake of readability?


Thanks,
Sasha

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sasha.levin@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Wanpeng Li <wanpeng.li@hotmail.com>,
	Andi Kleen <andi@firstfloor.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Hugh Dickins <hughd@google.com>, Minchan Kim <minchan@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v1] mm: hwpoison: adjust for new thp refcounting
Date: Fri, 6 Nov 2015 01:31:49 -0500	[thread overview]
Message-ID: <563C4955.3000300@oracle.com> (raw)
In-Reply-To: <1446790309-15683-1-git-send-email-n-horiguchi@ah.jp.nec.com>

On 11/06/2015 01:11 AM, Naoya Horiguchi wrote:
> In the new refcounting, we no longer use tail->_mapcount to keep tail's
> refcount, and thereby we can simplify get_hwpoison_page() and remove
> put_hwpoison_page() (by replacing with put_page()).

This is confusing for the reader (and some static analysis tools): this adds
put_page()s without corresponding get_page()s.

Could we instead macro put_hwpoison_page() as put_page() for the sake of readability?


Thanks,
Sasha

  reply	other threads:[~2015-11-06  6:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  6:11 [PATCH v1] mm: hwpoison: adjust for new thp refcounting Naoya Horiguchi
2015-11-06  6:11 ` Naoya Horiguchi
2015-11-06  6:31 ` Sasha Levin [this message]
2015-11-06  6:31   ` Sasha Levin
2015-11-06  6:47   ` Naoya Horiguchi
2015-11-06  6:47     ` Naoya Horiguchi
2015-11-06  8:03     ` [PATCH v2] " Naoya Horiguchi
2015-11-06  8:03       ` Naoya Horiguchi
2015-11-06 10:34       ` Kirill A. Shutemov
2015-11-06 10:34         ` Kirill A. Shutemov
2015-11-09  9:09     ` [PATCH v1] hugetlb: trivial comment fix Naoya Horiguchi
2015-11-09  9:09       ` Naoya Horiguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C4955.3000300@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=nao.horiguchi@gmail.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.