From: Jiang Liu <jiang.liu@linux.intel.com>
To: Sinan Kaya <okaya@codeaurora.org>,
linux-acpi@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, jcm@redhat.com
Cc: agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acpi: add support for extended IRQ to PCI link
Date: Mon, 9 Nov 2015 16:45:18 +0800 [thread overview]
Message-ID: <56405D1E.6020007@linux.intel.com> (raw)
In-Reply-To: <56403311.2020806@codeaurora.org>
On 2015/11/9 13:45, Sinan Kaya wrote:
>
>
> On 11/9/2015 12:24 AM, Jiang Liu wrote:
>>> + u32 possible[ACPI_PCI_LINK_MAX_POSSIBLE];
>>> > u8 initialized:1;
>>> > u8 reserved:7;
>>> > };
>> Hi Sinan,
>> This data structure become some sort of big, any idea to reduce
>> memory consumption?
>> Thanks,
>> Gerry
>>
> Hi Gerry,
>
> There are two constants in the code.
>
> #define ACPI_PCI_LINK_MAX_POSSIBLE 16
>
> I changed the data type above. Previously it was consuming 16 bytes now
> 64 bytes.
Aha, I made a mistake. ACPI_PCI_LINK_MAX_POSSIBLE hasn't been changed,
so the space increasing is not so big:)
>
> The second one is this.
>
> #define ACPI_MAX_IRQS 256
>
> I changed ACPI_MAX_IRQS to 1020 from 256. Let's assume 1024.
>
> I'm concerned about this though since you warned. This used to consume
> 1024 bytes now 4096 bytes.
>
> static int acpi_irq_penalty[ACPI_MAX_IRQS] = {
> PIRQ_PENALTY_ISA_ALWAYS, /* IRQ0 timer */
> ...
> }
>
> Sinan
>
WARNING: multiple messages have this Message-ID (diff)
From: jiang.liu@linux.intel.com (Jiang Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] acpi: add support for extended IRQ to PCI link
Date: Mon, 9 Nov 2015 16:45:18 +0800 [thread overview]
Message-ID: <56405D1E.6020007@linux.intel.com> (raw)
In-Reply-To: <56403311.2020806@codeaurora.org>
On 2015/11/9 13:45, Sinan Kaya wrote:
>
>
> On 11/9/2015 12:24 AM, Jiang Liu wrote:
>>> + u32 possible[ACPI_PCI_LINK_MAX_POSSIBLE];
>>> > u8 initialized:1;
>>> > u8 reserved:7;
>>> > };
>> Hi Sinan,
>> This data structure become some sort of big, any idea to reduce
>> memory consumption?
>> Thanks,
>> Gerry
>>
> Hi Gerry,
>
> There are two constants in the code.
>
> #define ACPI_PCI_LINK_MAX_POSSIBLE 16
>
> I changed the data type above. Previously it was consuming 16 bytes now
> 64 bytes.
Aha, I made a mistake. ACPI_PCI_LINK_MAX_POSSIBLE hasn't been changed,
so the space increasing is not so big:)
>
> The second one is this.
>
> #define ACPI_MAX_IRQS 256
>
> I changed ACPI_MAX_IRQS to 1020 from 256. Let's assume 1024.
>
> I'm concerned about this though since you warned. This used to consume
> 1024 bytes now 4096 bytes.
>
> static int acpi_irq_penalty[ACPI_MAX_IRQS] = {
> PIRQ_PENALTY_ISA_ALWAYS, /* IRQ0 timer */
> ...
> }
>
> Sinan
>
next prev parent reply other threads:[~2015-11-09 8:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 16:07 [PATCH] acpi: add support for extended IRQ to PCI link Sinan Kaya
2015-11-08 16:07 ` Sinan Kaya
2015-11-08 16:11 ` Timur Tabi
2015-11-08 16:11 ` Timur Tabi
2015-11-09 0:04 ` Sinan Kaya
2015-11-09 0:04 ` Sinan Kaya
2015-11-09 0:05 ` Timur Tabi
2015-11-09 0:05 ` Timur Tabi
2015-11-09 21:49 ` Rafael J. Wysocki
2015-11-09 21:49 ` Rafael J. Wysocki
2015-11-08 20:35 ` Andy Shevchenko
2015-11-08 20:35 ` Andy Shevchenko
2015-11-09 22:29 ` Sinan Kaya
2015-11-09 22:29 ` Sinan Kaya
2015-11-09 22:29 ` Sinan Kaya
2015-11-09 5:24 ` Jiang Liu
2015-11-09 5:24 ` Jiang Liu
2015-11-09 5:45 ` Sinan Kaya
2015-11-09 5:45 ` Sinan Kaya
2015-11-09 8:45 ` Jiang Liu [this message]
2015-11-09 8:45 ` Jiang Liu
2015-11-09 13:50 ` Timur Tabi
2015-11-09 13:50 ` Timur Tabi
2015-11-09 16:28 ` Sinan Kaya
2015-11-09 16:28 ` Sinan Kaya
-- strict thread matches above, loose matches on Subject: below --
2015-11-12 6:14 [PATCH V2] " Sinan Kaya
2015-11-12 6:14 ` [PATCH] " Sinan Kaya
2015-11-12 9:56 ` Andy Shevchenko
2015-11-12 15:04 ` Sinan Kaya
2015-11-12 15:17 ` Andy Shevchenko
2015-11-12 15:54 ` okaya
2015-11-12 15:58 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56405D1E.6020007@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=agross@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.