[U-Boot] [PATCH] serial: serial_x86: add ns16550a compatible ids

[U-Boot] [PATCH] serial: serial_x86: add ns16550a compatible ids

[Thomas Chou]

Add ns16550a compatible ids, so that other arch may use
this standard driver.

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
---
 drivers/serial/serial_x86.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/serial/serial_x86.c b/drivers/serial/serial_x86.c
index 4bf6062..f378eee 100644
--- a/drivers/serial/serial_x86.c
+++ b/drivers/serial/serial_x86.c
@@ -14,6 +14,8 @@ DECLARE_GLOBAL_DATA_PTR;
 
 static const struct udevice_id x86_serial_ids[] = {
 	{ .compatible = "x86-uart" },
+	{ .compatible = "ns16550a" },
+	{ .compatible = "ns16550" },
 	{ }
 };
 
-- 
2.5.0

[U-Boot] [PATCH] serial: serial_x86: add ns16550a compatible ids

[Thomas Chou]

Hi Simon,

On 2015?11?09? 16:53, Thomas Chou wrote:
> Add ns16550a compatible ids, so that other arch may use
> this standard driver.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
>   drivers/serial/serial_x86.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/serial/serial_x86.c b/drivers/serial/serial_x86.c
> index 4bf6062..f378eee 100644
> --- a/drivers/serial/serial_x86.c
> +++ b/drivers/serial/serial_x86.c
> @@ -14,6 +14,8 @@ DECLARE_GLOBAL_DATA_PTR;
>
>   static const struct udevice_id x86_serial_ids[] = {
>   	{ .compatible = "x86-uart" },
> +	{ .compatible = "ns16550a" },
> +	{ .compatible = "ns16550" },
>   	{ }
>   };

I want to use serial_x86.c for nios2. I think there is no need to 
duplicate another one for altera/nios2. Is there a proper way to change 
Kconfig/Makefile?

Best regards,
Thomas

[U-Boot] [PATCH] serial: serial_x86: add ns16550a compatible ids

[Bin Meng]

Hi Thomas,

On Mon, Nov 9, 2015 at 5:17 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> Hi Simon,
>
> On 2015?11?09? 16:53, Thomas Chou wrote:
>>
>> Add ns16550a compatible ids, so that other arch may use
>> this standard driver.
>>
>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>> ---
>>   drivers/serial/serial_x86.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/serial/serial_x86.c b/drivers/serial/serial_x86.c
>> index 4bf6062..f378eee 100644
>> --- a/drivers/serial/serial_x86.c
>> +++ b/drivers/serial/serial_x86.c
>> @@ -14,6 +14,8 @@ DECLARE_GLOBAL_DATA_PTR;
>>
>>   static const struct udevice_id x86_serial_ids[] = {
>>         { .compatible = "x86-uart" },
>> +       { .compatible = "ns16550a" },
>> +       { .compatible = "ns16550" },
>>         { }
>>   };
>
>
> I want to use serial_x86.c for nios2. I think there is no need to duplicate
> another one for altera/nios2. Is there a proper way to change
> Kconfig/Makefile?
>

Please check my previous proposal on serial driver clean up.

http://lists.denx.de/pipermail/u-boot/2015-August/223758.html

Regards,
Bin

[U-Boot] [PATCH] serial: serial_x86: add ns16550a compatible ids

[Thomas Chou]

Hi Bin,

On 2015?11?09? 20:03, Bin Meng wrote:
>> I want to use serial_x86.c for nios2. I think there is no need to duplicate
>> another one for altera/nios2. Is there a proper way to change
>> Kconfig/Makefile?
>>
>
> Please check my previous proposal on serial driver clean up.
>
> http://lists.denx.de/pipermail/u-boot/2015-August/223758.html

Thanks a lot for the pointer.

I think your suggestion is more practical. We can add clock-frequency to 
those have fixed clock. Then merge them to one driver.

For those need dynamic clock like tegra, we may ether leave them along. 
Or we can use the .data of compatible ids to fetch the clock.

We will need this soon.

Best regards,
Thomas

[U-Boot] [PATCH] serial: serial_x86: add ns16550a compatible ids

[Simon Glass]

+Tom, Stephen

Hi,

On 9 November 2015 at 05:19, Thomas Chou <thomas@wytron.com.tw> wrote:
> Hi Bin,
>
> On 2015?11?09? 20:03, Bin Meng wrote:
>>>
>>> I want to use serial_x86.c for nios2. I think there is no need to
>>> duplicate
>>> another one for altera/nios2. Is there a proper way to change
>>> Kconfig/Makefile?
>>>
>>
>> Please check my previous proposal on serial driver clean up.
>>
>> http://lists.denx.de/pipermail/u-boot/2015-August/223758.html
>
>
> Thanks a lot for the pointer.
>
> I think your suggestion is more practical. We can add clock-frequency to
> those have fixed clock. Then merge them to one driver.
>

Sounds good.

> For those need dynamic clock like tegra, we may ether leave them along. Or
> we can use the .data of compatible ids to fetch the clock.

Yes I think we should just add the property. It's silly to expect SPL
to parse the entire clock logic in the DT. We can leave Tegra on its
own for now.

>
> We will need this soon.

Regards.
Simon