From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] ofdisk: allocate space for vscsi table
Date: Mon, 9 Nov 2015 11:46:33 +0100 [thread overview]
Message-ID: <56407989.50903@gmail.com> (raw)
In-Reply-To: <1447032789-17670-1-git-send-email-pfsmorigo@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
On 09.11.2015 02:33, Paulo Flabiano Smorigo wrote:
> + /* 64 entries should be enough */
> + table_size = sizeof (grub_uint64_t) * 64;
Can we do something better than assuming a particular upper limit? You
don't even pass this limit to the function in any way. You basically get
a buffer overflow. Should we perhaps pass the limit in nentries? Or do
something similar?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2015-11-09 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 1:33 [PATCH] ofdisk: allocate space for vscsi table Paulo Flabiano Smorigo
2015-11-09 10:46 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-11-09 11:59 ` Paulo Flabiano Smorigo
2015-11-09 12:03 ` Vladimir 'phcoder' Serbinenko
2015-11-09 16:33 ` Paulo Flabiano Smorigo
2015-11-09 16:49 ` Vladimir 'phcoder' Serbinenko
2015-11-10 23:31 ` Paulo Flabiano Smorigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56407989.50903@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.