From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [PATCH] x86/P2M: consolidate handling of types not requiring a valid MFN
Date: Mon, 9 Nov 2015 15:02:50 +0000 [thread overview]
Message-ID: <5640B59A.9010909@citrix.com> (raw)
In-Reply-To: <5640C13902000078000B3122@prv-mh.provo.novell.com>
On 09/11/15 14:52, Jan Beulich wrote:
> As noted regarding the mixture of checks in p2m_pt_set_entry(),
> introduce an new P2M type group allowing to be used everywhere we
"a new P2M"
> just care about accepting operations with either a valid MFN or a type
> permitting to be used without (valid) MFN.
>
> Note that p2m_mmio_dm is not included in P2M_NO_MFN_TYPES, as for the
> intended purpose that one ought to be treated similar to p2m_invalid
> (perhaps the two should ultimately get folded anyway).
I seem to recall that p2m_invalid is still required to make the default
ioreq server infrastructure work with older qemu's
We really should see about cleaning the two up however.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
You probably also want to note that PoD superpages are now INVALID_MFN
rather than _mfn(0), but code wise,
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2015-11-09 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 14:52 [PATCH] x86/P2M: consolidate handling of types not requiring a valid MFN Jan Beulich
2015-11-09 15:02 ` Andrew Cooper [this message]
2015-11-09 15:06 ` Jan Beulich
2015-11-19 17:17 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640B59A.9010909@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.