From: "Andreas Färber" <afaerber@suse.de>
To: Huaitong Han <huaitong.han@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
rth@twiddle.net, ehabkost@redhat.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling
Date: Mon, 9 Nov 2015 16:19:12 +0100 [thread overview]
Message-ID: <5640B970.8020803@suse.de> (raw)
In-Reply-To: <56409064.6040609@redhat.com>
Am 09.11.2015 um 13:24 schrieb Paolo Bonzini:
> On 09/11/2015 12:55, Huaitong Han wrote:
>> @@ -351,6 +362,7 @@ static const char *cpuid_6_feature_name[] = {
>> CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2,
>> CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
>> CPUID_7_0_EBX_RDSEED */
>> +#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE)
>
> This should be zero. Apart from this detail, the QEMU parts look good.
...except for the subjects, which should be "target-i386: add pkeys
support for cpuid handling" etc. - no need to put qemu into a QEMU
commit subject, especially not twice.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Huaitong Han <huaitong.han@intel.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
ehabkost@redhat.com, kvm@vger.kernel.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling
Date: Mon, 9 Nov 2015 16:19:12 +0100 [thread overview]
Message-ID: <5640B970.8020803@suse.de> (raw)
In-Reply-To: <56409064.6040609@redhat.com>
Am 09.11.2015 um 13:24 schrieb Paolo Bonzini:
> On 09/11/2015 12:55, Huaitong Han wrote:
>> @@ -351,6 +362,7 @@ static const char *cpuid_6_feature_name[] = {
>> CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2,
>> CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
>> CPUID_7_0_EBX_RDSEED */
>> +#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE)
>
> This should be zero. Apart from this detail, the QEMU parts look good.
...except for the subjects, which should be "target-i386: add pkeys
support for cpuid handling" etc. - no need to put qemu into a QEMU
commit subject, especially not twice.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-11-09 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 11:55 [PATCH 0/3] qemu, pkeys: add memory protection-key support Huaitong Han
2015-11-09 11:55 ` [Qemu-devel] " Huaitong Han
2015-11-09 11:55 ` [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling Huaitong Han
2015-11-09 11:55 ` [Qemu-devel] " Huaitong Han
2015-11-09 12:24 ` Paolo Bonzini
2015-11-09 12:24 ` [Qemu-devel] " Paolo Bonzini
2015-11-09 15:19 ` Andreas Färber [this message]
2015-11-09 15:19 ` Andreas Färber
2015-11-09 11:55 ` [PATCH 2/3] qemu, pkeys: add pkeys support for qemu xsave state handling Huaitong Han
2015-11-09 11:55 ` [Qemu-devel] " Huaitong Han
2015-11-09 18:49 ` Eduardo Habkost
2015-11-09 18:49 ` [Qemu-devel] " Eduardo Habkost
2015-11-09 11:55 ` [PATCH 3/3] qemu, pkeys: add pkeys support for qemu migration Huaitong Han
2015-11-09 11:55 ` [Qemu-devel] " Huaitong Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640B970.8020803@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=huaitong.han@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.