From: Timur Tabi <timur@codeaurora.org>
To: Sinan Kaya <okaya@codeaurora.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: dmaengine <dmaengine@vger.kernel.org>,
cov@codeaurora.org, jcm@redhat.com,
Andy Gross <agross@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions
Date: Mon, 9 Nov 2015 22:59:13 -0600 [thread overview]
Message-ID: <564179A1.2080304@codeaurora.org> (raw)
In-Reply-To: <564178A5.6080603@codeaurora.org>
Sinan Kaya wrote:
>
> OK. I did an internal code review before posting the patch. Nobody
> complained about iterator types. I am trying to find what goes as a good
> practice vs. what is personal style.
I normally check for inappropriate usage of sized integers in my
reviews, but I admit I'm inconsistent about that sort of thing for
internal reviews.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions
Date: Mon, 9 Nov 2015 22:59:13 -0600 [thread overview]
Message-ID: <564179A1.2080304@codeaurora.org> (raw)
In-Reply-To: <564178A5.6080603@codeaurora.org>
Sinan Kaya wrote:
>
> OK. I did an internal code review before posting the patch. Nobody
> complained about iterator types. I am trying to find what goes as a good
> practice vs. what is personal style.
I normally check for inappropriate usage of sized integers in my
reviews, but I admit I'm inconsistent about that sort of thing for
internal reviews.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2015-11-10 4:59 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 4:52 [PATCH V3 0/4] *ma: add Qualcomm Technologies HIDMA driver Sinan Kaya
2015-11-08 4:52 ` Sinan Kaya
2015-11-08 4:52 ` [PATCH V3 1/4] dma: qcom_bam_dma: move to qcom directory Sinan Kaya
2015-11-08 4:52 ` Sinan Kaya
2015-11-08 5:02 ` Timur Tabi
2015-11-08 5:02 ` Timur Tabi
[not found] ` <1446958380-23298-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-11-08 4:52 ` [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2015-11-08 4:52 ` Sinan Kaya
2015-11-08 4:52 ` Sinan Kaya
2015-11-08 5:08 ` Timur Tabi
2015-11-08 5:08 ` Timur Tabi
2015-11-09 2:17 ` Sinan Kaya
2015-11-09 2:17 ` Sinan Kaya
2015-11-09 18:25 ` Rob Herring
2015-11-09 18:25 ` Rob Herring
2015-11-10 4:57 ` Sinan Kaya
2015-11-10 4:57 ` Sinan Kaya
2015-11-08 9:32 ` kbuild test robot
2015-11-08 9:32 ` kbuild test robot
2015-11-08 9:32 ` kbuild test robot
2015-11-08 4:52 ` [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya
2015-11-08 4:52 ` Sinan Kaya
2015-11-08 5:13 ` Timur Tabi
2015-11-08 5:13 ` Timur Tabi
2015-11-09 2:46 ` Sinan Kaya
2015-11-09 2:46 ` Sinan Kaya
2015-11-09 13:48 ` Timur Tabi
2015-11-09 13:48 ` Timur Tabi
2015-11-10 4:49 ` Sinan Kaya
2015-11-10 4:49 ` Sinan Kaya
2015-11-10 10:13 ` Arnd Bergmann
2015-11-10 10:13 ` Arnd Bergmann
2015-11-08 20:09 ` Andy Shevchenko
2015-11-08 20:09 ` Andy Shevchenko
2015-11-09 3:07 ` Sinan Kaya
2015-11-09 3:07 ` Sinan Kaya
2015-11-09 9:26 ` Andy Shevchenko
2015-11-09 9:26 ` Andy Shevchenko
2015-11-10 4:55 ` Sinan Kaya
2015-11-10 4:55 ` Sinan Kaya
2015-11-10 4:59 ` Timur Tabi [this message]
2015-11-10 4:59 ` Timur Tabi
2015-11-08 4:53 ` [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2015-11-08 4:53 ` Sinan Kaya
[not found] ` <1446958380-23298-5-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-11-08 19:13 ` kbuild test robot
2015-11-08 19:13 ` kbuild test robot
2015-11-08 19:13 ` kbuild test robot
2015-11-09 0:43 ` Sinan Kaya
2015-11-09 0:43 ` Sinan Kaya
2015-11-11 2:21 ` [kbuild-all] " Fengguang Wu
2015-11-11 2:21 ` Fengguang Wu
[not found] ` <20151111022103.GA29459-q6ZYBFIlbFFi0tQiZxhdj1DQ4js95KgL@public.gmane.org>
2015-11-11 8:42 ` Arnd Bergmann
2015-11-11 8:42 ` Arnd Bergmann
2015-11-11 8:42 ` Arnd Bergmann
2015-11-12 8:20 ` Fengguang Wu
2015-11-12 8:20 ` Fengguang Wu
2015-11-12 13:49 ` Arnd Bergmann
2015-11-12 13:49 ` Arnd Bergmann
2015-11-08 20:47 ` Andy Shevchenko
2015-11-08 20:47 ` Andy Shevchenko
2015-11-08 20:47 ` Andy Shevchenko
2015-11-08 21:51 ` Sinan Kaya
2015-11-08 21:51 ` Sinan Kaya
2015-11-08 22:00 ` Andy Shevchenko
2015-11-08 22:00 ` Andy Shevchenko
2015-11-09 0:31 ` Sinan Kaya
2015-11-09 0:31 ` Sinan Kaya
2015-11-09 18:19 ` Rob Herring
2015-11-09 18:19 ` Rob Herring
2015-11-10 4:44 ` Sinan Kaya
2015-11-10 4:44 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564179A1.2080304@codeaurora.org \
--to=timur@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.