From: Vlastimil Babka <vbabka@suse.cz>
To: Alexey Klimov <klimov.linux@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
emunson@akamai.com
Subject: Re: [PATCH] mm/mlock.c: drop unneeded initialization in munlock_vma_pages_range()
Date: Tue, 10 Nov 2015 10:27:00 +0100 [thread overview]
Message-ID: <5641B864.2020709@suse.cz> (raw)
In-Reply-To: <1447114962-31834-1-git-send-email-klimov.linux@gmail.com>
On 11/10/2015 01:22 AM, Alexey Klimov wrote:
> Before usage page pointer initialized by NULL is reinitialized by
> follow_page_mask(). Drop useless init of page pointer in the beginning
> of loop.
>
> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/mlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index 339d9e0..9cb87cb 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -425,7 +425,7 @@ void munlock_vma_pages_range(struct vm_area_struct *vma,
> vma->vm_flags &= VM_LOCKED_CLEAR_MASK;
>
> while (start < end) {
> - struct page *page = NULL;
> + struct page *page;
> unsigned int page_mask;
> unsigned long page_increm;
> struct pagevec pvec;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Alexey Klimov <klimov.linux@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
emunson@akamai.com
Subject: Re: [PATCH] mm/mlock.c: drop unneeded initialization in munlock_vma_pages_range()
Date: Tue, 10 Nov 2015 10:27:00 +0100 [thread overview]
Message-ID: <5641B864.2020709@suse.cz> (raw)
In-Reply-To: <1447114962-31834-1-git-send-email-klimov.linux@gmail.com>
On 11/10/2015 01:22 AM, Alexey Klimov wrote:
> Before usage page pointer initialized by NULL is reinitialized by
> follow_page_mask(). Drop useless init of page pointer in the beginning
> of loop.
>
> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/mlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index 339d9e0..9cb87cb 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -425,7 +425,7 @@ void munlock_vma_pages_range(struct vm_area_struct *vma,
> vma->vm_flags &= VM_LOCKED_CLEAR_MASK;
>
> while (start < end) {
> - struct page *page = NULL;
> + struct page *page;
> unsigned int page_mask;
> unsigned long page_increm;
> struct pagevec pvec;
>
next prev parent reply other threads:[~2015-11-10 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 0:22 [PATCH] mm/mlock.c: drop unneeded initialization in munlock_vma_pages_range() Alexey Klimov
2015-11-10 0:22 ` Alexey Klimov
2015-11-10 9:27 ` Vlastimil Babka [this message]
2015-11-10 9:27 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5641B864.2020709@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=emunson@akamai.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.