All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] toaster: Link to image recipes
@ 2015-10-15 19:57 Belen Barros Pena
  2015-11-10 17:12 ` Michael Wood
  2015-11-10 17:21 ` Michael Wood
  0 siblings, 2 replies; 3+ messages in thread
From: Belen Barros Pena @ 2015-10-15 19:57 UTC (permalink / raw)
  To: toaster

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 2422 bytes --]

From: Belen Barros Pena <belen.barros.pena@intel.com>

The project created notifications and the 'Choose
a recipe to build' link in the project page are
linking to the software recipes table.

Change them to link to the image recipes table instead,
which is bound to be more useful.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
---
 bitbake/lib/toaster/toastergui/templates/project.html       | 2 +-
 bitbake/lib/toaster/toastergui/templates/projecttopbar.html | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bitbake/lib/toaster/toastergui/templates/project.html b/bitbake/lib/toaster/toastergui/templates/project.html
index 2f978bc..5968c61 100644
--- a/bitbake/lib/toaster/toastergui/templates/project.html
+++ b/bitbake/lib/toaster/toastergui/templates/project.html
@@ -67,7 +67,7 @@
 
       <div class="alert alert-info" style="display:none" id="no-most-built">
         <span class="lead">You haven't built any recipes yet</span>
-        <p style="margin-top: 10px;"><a href="{% url 'projectsoftwarerecipes' project.id %}">Choose a recipe to build</a></p>
+        <p style="margin-top: 10px;"><a href="{% url 'projectimagerecipes' project.id %}">Choose a recipe to build</a></p>
       </div>
 
       <ul class="unstyled configuration-list" id="freq-build-list">
diff --git a/bitbake/lib/toaster/toastergui/templates/projecttopbar.html b/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
index ee86b54..7a6bfef 100644
--- a/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
+++ b/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
@@ -1,6 +1,6 @@
 <div class="alert alert-success lead" id="project-created-notification" style="margin-top:15px; display:none">
   <button type="button" class="close" data-dismiss="alert">×</button>
-  Your project <strong>{{project.name}}</strong> has been created. You can now <a href="{% url 'projectmachines' project.id %}">select your target machine</a> and <a href="{% url 'projectsoftwarerecipes' project.id %}">choose image recipes</a> to build.
+  Your project <strong>{{project.name}}</strong> has been created. You can now <a href="{% url 'projectmachines' project.id %}">select your target machine</a> and <a href="{% url 'projectimagerecipes' project.id %}">choose image recipes</a> to build.
 </div>
 
 <!-- project name -->
-- 
2.3.8 (Apple Git-58)



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] toaster: Link to image recipes
  2015-10-15 19:57 [PATCH] toaster: Link to image recipes Belen Barros Pena
@ 2015-11-10 17:12 ` Michael Wood
  2015-11-10 17:21 ` Michael Wood
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Wood @ 2015-11-10 17:12 UTC (permalink / raw)
  To: toaster

Thanks upstreamed and pushed to toaster-next with additions to make 
commit message more descriptive.

On 15/10/15 20:57, Belen Barros Pena wrote:
> From: Belen Barros Pena <belen.barros.pena@intel.com>
>
> The project created notifications and the 'Choose
> a recipe to build' link in the project page are
> linking to the software recipes table.
>
> Change them to link to the image recipes table instead,
> which is bound to be more useful.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
> ---
>   bitbake/lib/toaster/toastergui/templates/project.html       | 2 +-
>   bitbake/lib/toaster/toastergui/templates/projecttopbar.html | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/project.html b/bitbake/lib/toaster/toastergui/templates/project.html
> index 2f978bc..5968c61 100644
> --- a/bitbake/lib/toaster/toastergui/templates/project.html
> +++ b/bitbake/lib/toaster/toastergui/templates/project.html
> @@ -67,7 +67,7 @@
>   
>         <div class="alert alert-info" style="display:none" id="no-most-built">
>           <span class="lead">You haven't built any recipes yet</span>
> -        <p style="margin-top: 10px;"><a href="{% url 'projectsoftwarerecipes' project.id %}">Choose a recipe to build</a></p>
> +        <p style="margin-top: 10px;"><a href="{% url 'projectimagerecipes' project.id %}">Choose a recipe to build</a></p>
>         </div>
>   
>         <ul class="unstyled configuration-list" id="freq-build-list">
> diff --git a/bitbake/lib/toaster/toastergui/templates/projecttopbar.html b/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
> index ee86b54..7a6bfef 100644
> --- a/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
> +++ b/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
> @@ -1,6 +1,6 @@
>   <div class="alert alert-success lead" id="project-created-notification" style="margin-top:15px; display:none">
>     <button type="button" class="close" data-dismiss="alert">×</button>
> -  Your project <strong>{{project.name}}</strong> has been created. You can now <a href="{% url 'projectmachines' project.id %}">select your target machine</a> and <a href="{% url 'projectsoftwarerecipes' project.id %}">choose image recipes</a> to build.
> +  Your project <strong>{{project.name}}</strong> has been created. You can now <a href="{% url 'projectmachines' project.id %}">select your target machine</a> and <a href="{% url 'projectimagerecipes' project.id %}">choose image recipes</a> to build.
>   </div>
>   
>   <!-- project name -->
>
>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] toaster: Link to image recipes
  2015-10-15 19:57 [PATCH] toaster: Link to image recipes Belen Barros Pena
  2015-11-10 17:12 ` Michael Wood
@ 2015-11-10 17:21 ` Michael Wood
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Wood @ 2015-11-10 17:21 UTC (permalink / raw)
  To: toaster

Thanks sent upstream and toaster-next with some additional detail in the 
commit message

On 15/10/15 20:57, Belen Barros Pena wrote:
> From: Belen Barros Pena <belen.barros.pena@intel.com>
>
> The project created notifications and the 'Choose
> a recipe to build' link in the project page are
> linking to the software recipes table.
>
> Change them to link to the image recipes table instead,
> which is bound to be more useful.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
> ---
>   bitbake/lib/toaster/toastergui/templates/project.html       | 2 +-
>   bitbake/lib/toaster/toastergui/templates/projecttopbar.html | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/project.html b/bitbake/lib/toaster/toastergui/templates/project.html
> index 2f978bc..5968c61 100644
> --- a/bitbake/lib/toaster/toastergui/templates/project.html
> +++ b/bitbake/lib/toaster/toastergui/templates/project.html
> @@ -67,7 +67,7 @@
>   
>         <div class="alert alert-info" style="display:none" id="no-most-built">
>           <span class="lead">You haven't built any recipes yet</span>
> -        <p style="margin-top: 10px;"><a href="{% url 'projectsoftwarerecipes' project.id %}">Choose a recipe to build</a></p>
> +        <p style="margin-top: 10px;"><a href="{% url 'projectimagerecipes' project.id %}">Choose a recipe to build</a></p>
>         </div>
>   
>         <ul class="unstyled configuration-list" id="freq-build-list">
> diff --git a/bitbake/lib/toaster/toastergui/templates/projecttopbar.html b/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
> index ee86b54..7a6bfef 100644
> --- a/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
> +++ b/bitbake/lib/toaster/toastergui/templates/projecttopbar.html
> @@ -1,6 +1,6 @@
>   <div class="alert alert-success lead" id="project-created-notification" style="margin-top:15px; display:none">
>     <button type="button" class="close" data-dismiss="alert">×</button>
> -  Your project <strong>{{project.name}}</strong> has been created. You can now <a href="{% url 'projectmachines' project.id %}">select your target machine</a> and <a href="{% url 'projectsoftwarerecipes' project.id %}">choose image recipes</a> to build.
> +  Your project <strong>{{project.name}}</strong> has been created. You can now <a href="{% url 'projectmachines' project.id %}">select your target machine</a> and <a href="{% url 'projectimagerecipes' project.id %}">choose image recipes</a> to build.
>   </div>
>   
>   <!-- project name -->
>
>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-10 17:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 19:57 [PATCH] toaster: Link to image recipes Belen Barros Pena
2015-11-10 17:12 ` Michael Wood
2015-11-10 17:21 ` Michael Wood

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.