Re: [Powertop] [PATCH v2 00/14] pull: various changes, mostly build system related

[Alexandra Yates <alexandra.yates at linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]


> On 14 November 2014 04:30, Alexandra Yates
> <alexandra.yates(a)linux.intel.com> wrote:
>
> Hi Alexandra, and all,
>
>> Patches look good.
>
> Nice to hear.
>
>> Two things:
>>
>> 1- I could not get this patch to apply
>> "configure: require new enough automake version"
>> Patch is empty.  Was it split wrong?
>
> Empty? I don't understand, I can see the change in mail archive.
>
> https://lists.01.org/pipermail/powertop/2014-November/001666.html
>
> Instead of sending the same 14 patches without any changes to them
> could you consider merging from my repo to avoid weird mail content
> issue(s).
>
> cd powertop
> git remote add sami https://github.com/kerolasa/powertop.git
> git fetch sami
> git checkout master
> git merge sami/various
> git remote remove sami
>
> If all OK git push to what ever you call upstream repo, often origin,
> but there is no way I could be sure.
>
>> 2- Please get the latest checkpatch.pl from the linux kernel scripts and
>> run it over your files before creating the patches.
>
> The script reported few of the following, but I don't think they are
> meaningful in this case.
>
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>
> The checkpatch.pl did not report any other errors.
>
> --
> Sami Kerola
> http://www.iki.fi/kerolasa/
>

Sami,

When I run checkpatch.pl I get white spaces and over 80 char line errors
on your patches.

Thank you,
Alexandra.