All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandra Yates <alexandra.yates at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH v2 00/14] pull: various changes, mostly build system related
Date: Thu, 13 Nov 2014 20:30:26 -0800	[thread overview]
Message-ID: <62192.10.254.178.169.1415939426.squirrel@linux.intel.com> (raw)
In-Reply-To: 1415538871-11411-1-git-send-email-sami.kerola@lastminute.com

[-- Attachment #1: Type: text/plain, Size: 2666 bytes --]

Hi Sami,


> Hello,
>
> This change set is related to previous submission, that is discussed in
> thread below:
>
> https://lists.01.org/pipermail/powertop/2014-November/001664.html
>
> My assumption is that these changes may not be completely in acceptable
> to be part of upstream just before release.  See the link for details.
>
> Sami Kerola (14):
>   configure: require new enough automake version
>   configure: use autoconf-archive ax_pthread.m4
>   add missing space to --version print out
>   csstoh.sh: check every single return value
>   configure: use AC_USE_SYSTEM_EXTENSIONS to determine features
>   powertop.m4: GCC_FORTIFY_SOURCE_CC copy idea of macro from Archlinux
>     pacman
>   configure: use autoconf-archive ax_cxx_compile_stdcxx_11.m4
>   main: fix incompatible operand type
>   move variables to protected scope
>   make --quiet option to suppress various info messages
>   squeeze all extra bits from size of binary and html report
>   add timestamp to html report
>   fix typo in message
>   add missing include
>
>  .gitignore                           |  39 +++-
>  PowerTop.png                         | Bin 6975 -> 5542 bytes
>  configure.ac                         |  21 ++-
>  m4/ax_cxx_compile_stdcxx_11.m4       | 142 +++++++++++++++
>  m4/ax_pthread.m4                     | 332
> +++++++++++++++++++++++++++++++++++
>  m4/gcc_fortify_source_cc.m4          |  29 +++
>  src/Makefile.am                      |   1 -
>  src/cpu/rapl/rapl_interface.cpp      |   7 +-
>  src/cpu/rapl/rapl_interface.h        |   9 +-
>  src/csstoh.sh                        |  40 +++--
>  src/lib.h                            |   1 +
>  src/main.cpp                         |   8 +-
>  src/report/report-formatter-base.cpp |   2 -
>  src/report/report-formatter-csv.cpp  |   2 -
>  src/report/report-formatter-html.cpp | 248 +++++++++++++-------------
>  src/report/report.cpp                |   5 +-
>  16 files changed, 719 insertions(+), 167 deletions(-)
>  create mode 100644 m4/ax_cxx_compile_stdcxx_11.m4
>  create mode 100644 m4/ax_pthread.m4
>  create mode 100644 m4/gcc_fortify_source_cc.m4
>
> --
> 2.1.3
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>

Patches look good.  Two things:

1- I could not get this patch to apply
"configure: require new enough automake version"
Patch is empty.  Was it split wrong?

2- Please get the latest checkpatch.pl from the linux kernel scripts and
run it over your files before creating the patches.

Thank you,
Alexandra.

             reply	other threads:[~2014-11-14  4:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  4:30 Alexandra Yates [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-11-25 19:22 [Powertop] [PATCH v2 00/14] pull: various changes, mostly build system related Alexandra Yates
2014-11-18 18:08 Alexandra Yates
2014-11-17 20:24 Sami Kerola
2014-11-17  4:45 Alexandra Yates
2014-11-15 17:54 Sami Kerola
2014-11-09 13:14 Sami Kerola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62192.10.254.178.169.1415939426.squirrel@linux.intel.com \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.