From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>
Subject: Re: [PATCH v4] ofdisk: add sas disks to the device list
Date: Wed, 11 Nov 2015 21:01:20 +0100 [thread overview]
Message-ID: <56439E90.3080200@gmail.com> (raw)
In-Reply-To: <1447247672-20823-1-git-send-email-pfsmorigo@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
On 11.11.2015 14:14, Paulo Flabiano Smorigo wrote:
> + ptr = (grub_uint64_t *) (table + sizeof (grub_uint64_t) * i);
> + grub_snprintf (bufptr, 32, "/disk@%" PRIxGRUB_UINT64_T, *ptr);
Please declare table as being grub_uint64_t * and then just use
table[i]. This code violates cast-align
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
prev parent reply other threads:[~2015-11-11 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 13:14 [PATCH v4] ofdisk: add sas disks to the device list Paulo Flabiano Smorigo
2015-11-11 17:28 ` Andrei Borzenkov
2015-11-11 17:34 ` Paulo Flabiano Smorigo
2015-11-11 20:01 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56439E90.3080200@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
--cc=pfsmorigo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.