All of lore.kernel.org
 help / color / mirror / Atom feed
From: m@bjorling.me (Matias Bjørling)
Subject: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs
Date: Thu, 12 Nov 2015 11:01:10 +0100	[thread overview]
Message-ID: <56446366.8050907@bjorling.me> (raw)
In-Reply-To: <CAMuHMdVfboMmbWcd_iCJ2KqAAmYjYUZ9_i4yFut6rRwQ75X+eQ@mail.gmail.com>

On 11/11/2015 11:46 PM, Geert Uytterhoeven wrote:
> On Wed, Oct 28, 2015@7:54 PM, Matias Bj?rling <m@bjorling.me> wrote:
>> +struct nvm_dev_ops {
>
> [...]
>
>> +       uint8_t                 max_phys_sect;
>> +};
>
>> --- /dev/null
>> +++ b/drivers/lightnvm/core.c
>
>> +int nvm_register(struct request_queue *q, char *disk_name,
>> +                                                       struct nvm_dev_ops *ops)
>> +{
>
> [...]
>
>> +       } else if (dev->ops->max_phys_sect > 256) {
>
> drivers/nfc/nfcmrvl/i2c.c:52: warning: comparison is always false due
> to limited range of data type
>
> Indeed, max_phys_sect is "uint8_t", so its maximum value is 255.
>
>> +               pr_info("nvm: max sectors supported is 256.\n");
>
> Hence this message is not correct. What's the intended maximum value?
> 255 or 256?

Good catch. It'll be 256, the typically device driver supports 64. The 
256 is just an upper sensible bound. I'll create a patch to make it an 
unsigned short.

Thanks

WARNING: multiple messages have this Message-ID (diff)
From: "Matias Bjørling" <m@bjorling.me>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jens Axboe <axboe@fb.com>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-nvme@lists.infradead.org,
	Christoph Hellwig <hch@infradead.org>,
	jg@lightnvm.io, Stephen.Bates@pmcs.com,
	Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH v14 1/5] lightnvm: Support for Open-Channel SSDs
Date: Thu, 12 Nov 2015 11:01:10 +0100	[thread overview]
Message-ID: <56446366.8050907@bjorling.me> (raw)
In-Reply-To: <CAMuHMdVfboMmbWcd_iCJ2KqAAmYjYUZ9_i4yFut6rRwQ75X+eQ@mail.gmail.com>

On 11/11/2015 11:46 PM, Geert Uytterhoeven wrote:
> On Wed, Oct 28, 2015 at 7:54 PM, Matias Bjørling <m@bjorling.me> wrote:
>> +struct nvm_dev_ops {
>
> [...]
>
>> +       uint8_t                 max_phys_sect;
>> +};
>
>> --- /dev/null
>> +++ b/drivers/lightnvm/core.c
>
>> +int nvm_register(struct request_queue *q, char *disk_name,
>> +                                                       struct nvm_dev_ops *ops)
>> +{
>
> [...]
>
>> +       } else if (dev->ops->max_phys_sect > 256) {
>
> drivers/nfc/nfcmrvl/i2c.c:52: warning: comparison is always false due
> to limited range of data type
>
> Indeed, max_phys_sect is "uint8_t", so its maximum value is 255.
>
>> +               pr_info("nvm: max sectors supported is 256.\n");
>
> Hence this message is not correct. What's the intended maximum value?
> 255 or 256?

Good catch. It'll be 256, the typically device driver supports 64. The 
256 is just an upper sensible bound. I'll create a patch to make it an 
unsigned short.

Thanks

  parent reply	other threads:[~2015-11-12 10:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 18:54 [PATCH v14 0/5] Support for Open-Channel SSDs Matias Bjørling
2015-10-28 18:54 ` Matias Bjørling
2015-10-28 18:54 ` [PATCH v14 1/5] lightnvm: " Matias Bjørling
2015-10-28 18:54   ` Matias Bjørling
2015-11-11 22:46   ` Geert Uytterhoeven
2015-11-11 22:46     ` Geert Uytterhoeven
2015-11-11 22:47     ` Geert Uytterhoeven
2015-11-11 22:47       ` Geert Uytterhoeven
2015-11-11 22:47       ` Geert Uytterhoeven
2015-11-12 10:01     ` Matias Bjørling [this message]
2015-11-12 10:01       ` Matias Bjørling
2015-10-28 18:54 ` [PATCH v14 2/5] gennvm: Generic NVM manager Matias Bjørling
2015-10-28 18:54   ` Matias Bjørling
2015-10-28 18:54 ` [PATCH v14 3/5] rrpc: Round-robin sector target with cost-based gc Matias Bjørling
2015-10-28 18:54   ` Matias Bjørling
2015-10-28 18:54 ` [PATCH v14 4/5] null_nvm: LightNVM test driver Matias Bjørling
2015-10-28 18:54   ` Matias Bjørling
2015-10-28 18:54 ` [PATCH v14 5/5] nvme: LightNVM support Matias Bjørling
2015-10-28 18:54   ` Matias Bjørling
2015-10-29 19:48 ` [PATCH v14 0/5] Support for Open-Channel SSDs Jens Axboe
2015-10-29 19:48   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56446366.8050907@bjorling.me \
    --to=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.