From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org,
ian.campbell@citrix.com, andrew.cooper3@citrix.com,
stefano.stabellini@eu.citrix.com, roy.franz@linaro.org,
ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com,
wei.liu2@citrix.com, xen-devel@lists.xenproject.org,
qiaowei.ren@intel.com, richard.l.maliszewski@intel.com,
gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator
Date: Thu, 12 Nov 2015 14:45:17 +0100 [thread overview]
Message-ID: <564497ED.3050709@gmail.com> (raw)
In-Reply-To: <20151110143833.GS26902@olila.local.net-space.pl>
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
On 10.11.2015 15:38, Daniel Kiper wrote:
>>> - if (entry_specified)
>>> > > + if (keep_bs && efi_entry_specified)
>>> > > + grub_multiboot_payload_eip = efi_entry;
>>> > > + else if (entry_specified)
>>> > > grub_multiboot_payload_eip = entry;
>>> > >
>> > This seems redundant.
> What is wrong here?
I just mean that if we use a single structure this code could go away
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2015-11-12 13:45 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:35 [PATCH v2 0/6] multiboot2: Add two extensions and fix some issues Daniel Kiper
2015-07-20 14:35 ` [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files Daniel Kiper
2015-08-11 17:00 ` Konrad Rzeszutek Wilk
2015-08-11 17:00 ` Konrad Rzeszutek Wilk
2015-08-12 9:04 ` Ian Campbell
2015-11-04 12:03 ` Vladimir 'phcoder' Serbinenko
2015-11-09 15:29 ` Daniel Kiper
2015-11-09 15:29 ` Daniel Kiper
2015-11-09 15:34 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-09 15:39 ` Daniel Kiper
2015-11-09 15:39 ` Daniel Kiper
2015-11-09 20:22 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-09 20:22 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-09 15:34 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-04 12:03 ` Vladimir 'phcoder' Serbinenko
2015-08-12 9:04 ` Ian Campbell
2015-07-20 14:35 ` Daniel Kiper
2015-07-20 14:35 ` [PATCH v2 2/6] relocator: Do not use memory region if its starta is smaller than size Daniel Kiper
2015-07-21 6:42 ` Andrei Borzenkov
2015-11-09 18:44 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-09 18:44 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-07-21 6:42 ` Andrei Borzenkov
2016-02-12 14:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
2016-02-12 19:01 ` Daniel Kiper
2016-02-12 19:12 ` Vladimir 'phcoder' Serbinenko
2016-02-12 19:55 ` Daniel Kiper
2016-02-12 19:55 ` Daniel Kiper
2016-02-12 19:12 ` Vladimir 'phcoder' Serbinenko
2016-02-12 19:01 ` Daniel Kiper
2016-02-12 14:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-07-20 14:35 ` Daniel Kiper
2015-07-20 14:35 ` [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator Daniel Kiper
2015-07-20 14:35 ` Daniel Kiper
2015-08-11 17:02 ` Konrad Rzeszutek Wilk
2015-08-11 17:02 ` Konrad Rzeszutek Wilk
2015-11-09 20:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-10 14:38 ` Daniel Kiper
2015-11-10 14:38 ` Daniel Kiper
2015-11-12 13:45 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-11-12 13:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-09 20:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-07-20 14:35 ` [PATCH v2 4/6] multiboot2: Add tags used to pass ImageHandle to loaded image Daniel Kiper
2015-08-11 18:38 ` Konrad Rzeszutek Wilk
2015-08-11 18:38 ` Konrad Rzeszutek Wilk
[not found] ` <CAEaD8JOPxLVECcUqjj2-x5AeXjbQ9Cd7bOaoe8UPU2t7wdoxpA@mail.gmail.com>
2015-11-09 19:12 ` Fwd: " Vladimir 'phcoder' Serbinenko
[not found] ` <CAEaD8JOaS=J22k+Sq=8Ou77pO6yvtgxSLiwuMjAoirSipJhW6g@mail.gmail.com>
2015-11-09 20:06 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-07-20 14:35 ` Daniel Kiper
2015-07-20 14:35 ` [PATCH v2 5/6] multiboot2: Add support for relocatable images Daniel Kiper
2015-08-11 18:51 ` Konrad Rzeszutek Wilk
2015-08-11 18:51 ` Konrad Rzeszutek Wilk
2015-11-09 20:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-09 20:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-10 14:52 ` Daniel Kiper
2015-11-10 14:52 ` Daniel Kiper
[not found] ` <CAEaD8JMUUnSd7MMTANouZ1oQvYA00c49V8ENgUGUY+K8HcE_+Q@mail.gmail.com>
[not found] ` <20151112131555.GW26902@olila.local.net-space.pl>
2015-11-12 13:26 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-12 13:33 ` Daniel Kiper
2015-11-12 13:33 ` Daniel Kiper
2015-11-12 13:26 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-07-20 14:35 ` Daniel Kiper
2015-07-20 14:35 ` [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled Daniel Kiper
2015-08-11 18:59 ` Konrad Rzeszutek Wilk
2015-08-18 12:29 ` Daniel Kiper
2015-08-18 12:29 ` Daniel Kiper
2015-08-11 18:59 ` Konrad Rzeszutek Wilk
2015-07-20 14:35 ` Daniel Kiper
2015-08-24 17:11 ` [PATCH v2 0/6] multiboot2: Add two extensions and fix some issues Daniel Kiper
2015-08-24 17:11 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564497ED.3050709@gmail.com \
--to=phcoder@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=grub-devel@gnu.org \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=keir@xen.org \
--cc=ning.sun@intel.com \
--cc=qiaowei.ren@intel.com \
--cc=richard.l.maliszewski@intel.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.