All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: bcm63xx: use correct format string for printing a resource
Date: Thu, 12 Nov 2015 10:40:19 -0800	[thread overview]
Message-ID: <5644DD13.9070206@openwrt.org> (raw)
In-Reply-To: <8442314.JjGyK1Sa3M@wuerfel>

On 12/11/15 08:44, Arnd Bergmann wrote:
> With a 64-bit resource_size_t, we get a build warning on bcm63xx_spi_probe:
> 
> drivers/spi/spi-bcm63xx.c:565:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> 
> As we are printing a resource, we can just use the %pr format
> specifier that pretty-prints the address and avoids the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

Acked-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks

> ---
> Found on arm multi_v7_defconfig with LPAE
> 
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 06858e04ec59..bf9a610e5b89 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -562,8 +562,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
>  		goto out_clk_disable;
>  	}
>  
> -	dev_info(dev, "at 0x%08x (irq %d, FIFOs size %d)\n",
> -		 r->start, irq, bs->fifo_size);
> +	dev_info(dev, "at %pr (irq %d, FIFOs size %d)\n",
> +		 r, irq, bs->fifo_size);
>  
>  	return 0;
>  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: bcm63xx: use correct format string for printing a resource
Date: Thu, 12 Nov 2015 10:40:19 -0800	[thread overview]
Message-ID: <5644DD13.9070206@openwrt.org> (raw)
In-Reply-To: <8442314.JjGyK1Sa3M@wuerfel>

On 12/11/15 08:44, Arnd Bergmann wrote:
> With a 64-bit resource_size_t, we get a build warning on bcm63xx_spi_probe:
> 
> drivers/spi/spi-bcm63xx.c:565:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> 
> As we are printing a resource, we can just use the %pr format
> specifier that pretty-prints the address and avoids the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks

> ---
> Found on arm multi_v7_defconfig with LPAE
> 
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 06858e04ec59..bf9a610e5b89 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -562,8 +562,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
>  		goto out_clk_disable;
>  	}
>  
> -	dev_info(dev, "at 0x%08x (irq %d, FIFOs size %d)\n",
> -		 r->start, irq, bs->fifo_size);
> +	dev_info(dev, "at %pr (irq %d, FIFOs size %d)\n",
> +		 r, irq, bs->fifo_size);
>  
>  	return 0;
>  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Jonas Gorski <jogo@openwrt.org>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: bcm63xx: use correct format string for printing a resource
Date: Thu, 12 Nov 2015 10:40:19 -0800	[thread overview]
Message-ID: <5644DD13.9070206@openwrt.org> (raw)
In-Reply-To: <8442314.JjGyK1Sa3M@wuerfel>

On 12/11/15 08:44, Arnd Bergmann wrote:
> With a 64-bit resource_size_t, we get a build warning on bcm63xx_spi_probe:
> 
> drivers/spi/spi-bcm63xx.c:565:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> 
> As we are printing a resource, we can just use the %pr format
> specifier that pretty-prints the address and avoids the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks

> ---
> Found on arm multi_v7_defconfig with LPAE
> 
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 06858e04ec59..bf9a610e5b89 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -562,8 +562,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
>  		goto out_clk_disable;
>  	}
>  
> -	dev_info(dev, "at 0x%08x (irq %d, FIFOs size %d)\n",
> -		 r->start, irq, bs->fifo_size);
> +	dev_info(dev, "at %pr (irq %d, FIFOs size %d)\n",
> +		 r, irq, bs->fifo_size);
>  
>  	return 0;
>  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


  reply	other threads:[~2015-11-12 18:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 16:44 [PATCH] spi: bcm63xx: use correct format string for printing a resource Arnd Bergmann
2015-11-12 16:44 ` Arnd Bergmann
2015-11-12 16:44 ` Arnd Bergmann
2015-11-12 18:40 ` Florian Fainelli [this message]
2015-11-12 18:40   ` Florian Fainelli
2015-11-12 18:40   ` Florian Fainelli
2015-11-16 18:45 ` Applied "spi: bcm63xx: use correct format string for printing a resource" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5644DD13.9070206@openwrt.org \
    --to=florian-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.