Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER

[Hongxu Jia <hongxu.jia@windriver.com>]

On 11/13/2015 06:36 PM, Andreas Müller wrote:
> On Fri, Nov 13, 2015 at 11:19 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> Why not use VIRTUAL-RUNTIME variable like in other places? And if it's
>> needed by xfce4-power-manager, then why don't you add it to RDEPENDS there?
>>
> networkmanager is already in RDEPENDS of xfce4-power-manager. I think
> when building an image packagegroup-core-x11-sato there is a conflict.
>
> I looked into this a bit more and think:
> 1. networkmanger support is optional so a packagroup would allow
> conman and xfce4-power-manager live together in harmony
> 2. I think the patch goes much to far: To have networkmanager in
> images based on packagegroup-core-x11-sato the correct way would be to
> write NETWORK_MANAGER = "networkmanager" in the image recipe.

Hi Andreas,

The condition of writing  NETWORK_MANAGER = "networkmanager" is
packagegroup-core-x11-sato + xfce4-power-manager, I think it is not
proper to test the existence of them in an image recipe.

Hi Martin & Andreas,

How about we still do the setting in meta-xfce's local.conf and replace
networkmanager with variable ${NETWORK_MANAGER} in
xfce4-power-manager's RDEPENDS.

So we could globally control network manager by variable
${NETWORK_MANAGER} for the similar issue.

//Hongxu
> Andreas