From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/IO-APIC: fix setup of Xen internally used IRQs (take 2)
Date: Fri, 13 Nov 2015 17:29:39 +0000 [thread overview]
Message-ID: <56461E03.3060804@citrix.com> (raw)
In-Reply-To: <564612AE02000078000B4CBB@prv-mh.provo.novell.com>
On 13/11/15 15:41, Jan Beulich wrote:
> ..., i.e. namely that of a PCI serial card with an IRQ above the
> legacy range. This had got broken by the switch to cpumask_any() in
> cpu_mask_to_apicid_phys(). Fix this by allowing all CPUs for that IRQ
> (via setup_vector_irq() properly updating a booting CPU's vector_irq[],
> thus avoiding "No irq handler for vector" messages and the interrupt
> not working).
>
> Cleanup coding style and types there at once.
>
> While doing this I also noticed that io_apic_set_pci_routing() can't
> be quite right: It sets up the destination _before_ getting a vector
> allocated (which on other than systems using the flat APIC mode
> affects the possible destinations), and also didn't restrict affinity
> to ->arch.cpu_mask (as established by assign_irq_vector()).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Appears to cover the issues identified from v1.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
prev parent reply other threads:[~2015-11-13 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 15:41 [PATCH] x86/IO-APIC: fix setup of Xen internally used IRQs (take 2) Jan Beulich
2015-11-13 17:29 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56461E03.3060804@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.