Patch for terminal definition in gfx themes

Patch for terminal definition in gfx themes

[Konstantin Vlasov]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Hi,

I discovered that terminal size and position in GFX themes are calculated 
incorrectly: proportional units for terminal-top and terminal-height values are 
calculated from the screen width, not height as one would expect.

I attached the patch for fixing it.


-- 
Best regards,
 Konstantin                          mailto:kvlasov@odin.com

[-- Attachment #2: grub-gfx-terminal-sizes-fix.patch --]
[-- Type: application/octet-stream, Size: 1251 bytes --]

diff --git a/grub-core/gfxmenu/theme_loader.c b/grub-core/gfxmenu/theme_loader.c
index 1a6ed1d..0297839 100644
--- a/grub-core/gfxmenu/theme_loader.c
+++ b/grub-core/gfxmenu/theme_loader.c
@@ -254,9 +254,9 @@ theme_set_string (grub_gfxmenu_view_t view,
   else if (! grub_strcmp ("terminal-top", name))
     {
       unsigned int tmp;
       int err = theme_get_unsigned_int_from_proportional (value,
-                                                          view->screen.width,
+                                                          view->screen.height,
                                                           &tmp);
       if (err != GRUB_ERR_NONE)
         return err;
       view->terminal_rect.y = tmp;
@@ -274,9 +274,9 @@ theme_set_string (grub_gfxmenu_view_t view,
   else if (! grub_strcmp ("terminal-height", name))
     {
       unsigned int tmp;
       int err = theme_get_unsigned_int_from_proportional (value,
-                                                          view->screen.width,
+                                                          view->screen.height,
                                                           &tmp);
       if (err != GRUB_ERR_NONE)
         return err;
       view->terminal_rect.height = tmp;

Re: Patch for terminal definition in gfx themes

[Andrei Borzenkov]

13.11.2015 19:31, Konstantin Vlasov пишет:
> Hi,
>
> I discovered that terminal size and position in GFX themes are calculated
> incorrectly: proportional units for terminal-top and terminal-height values are
> calculated from the screen width, not height as one would expect.
>
> I attached the patch for fixing it.
>
>

Committed, thanks!

Please use "git format-patch" next time.