From: Jonathan Cameron <jic23@kernel.org>
To: Thomas Betker <thomas.betker@freenet.de>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Xander Huff" <xander.huff@ni.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Thomas Betker" <thomas.betker@rohde-schwarz.com>
Subject: Re: [PATCH] iio: adc: xilinx: Fix VREFN scale
Date: Sun, 15 Nov 2015 10:42:39 +0000 [thread overview]
Message-ID: <5648619F.4040208@kernel.org> (raw)
In-Reply-To: <1447273478-2530-1-git-send-email-thomas.betker@freenet.de>
On 11/11/15 20:24, Thomas Betker wrote:
> From: Thomas Betker <thomas.betker@rohde-schwarz.com>
>
> The scaling factor for VREFN is 3.0/4096 (not 1.0/4096), just as for
> VREFP. This is not immediately obvious from the specification (Xilinx
> UG480), but has been confirmed by Xilinx support.
>
> Suggested-by: Hartmut Knaack <knaack.h@gmx.de>
> Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 0370624..02e636a 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -841,6 +841,7 @@ static int xadc_read_raw(struct iio_dev *indio_dev,
> case XADC_REG_VCCINT:
> case XADC_REG_VCCAUX:
> case XADC_REG_VREFP:
> + case XADC_REG_VREFN:
> case XADC_REG_VCCBRAM:
> case XADC_REG_VCCPINT:
> case XADC_REG_VCCPAUX:
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: adc: xilinx: Fix VREFN scale
Date: Sun, 15 Nov 2015 10:42:39 +0000 [thread overview]
Message-ID: <5648619F.4040208@kernel.org> (raw)
In-Reply-To: <1447273478-2530-1-git-send-email-thomas.betker@freenet.de>
On 11/11/15 20:24, Thomas Betker wrote:
> From: Thomas Betker <thomas.betker@rohde-schwarz.com>
>
> The scaling factor for VREFN is 3.0/4096 (not 1.0/4096), just as for
> VREFP. This is not immediately obvious from the specification (Xilinx
> UG480), but has been confirmed by Xilinx support.
>
> Suggested-by: Hartmut Knaack <knaack.h@gmx.de>
> Signed-off-by: Thomas Betker <thomas.betker@rohde-schwarz.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 0370624..02e636a 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -841,6 +841,7 @@ static int xadc_read_raw(struct iio_dev *indio_dev,
> case XADC_REG_VCCINT:
> case XADC_REG_VCCAUX:
> case XADC_REG_VREFP:
> + case XADC_REG_VREFN:
> case XADC_REG_VCCBRAM:
> case XADC_REG_VCCPINT:
> case XADC_REG_VCCPAUX:
>
next prev parent reply other threads:[~2015-11-15 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 20:24 [PATCH] iio: adc: xilinx: Fix VREFN scale Thomas Betker
2015-11-11 20:24 ` Thomas Betker
2015-11-15 10:42 ` Jonathan Cameron [this message]
2015-11-15 10:42 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5648619F.4040208@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
--cc=soren.brinkmann@xilinx.com \
--cc=thomas.betker@freenet.de \
--cc=thomas.betker@rohde-schwarz.com \
--cc=xander.huff@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.