All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: tiwai@suse.com
Cc: Cheah Kok Cheong <thrust73@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Sound: Usb: Misc: ua101: replace le16_to_cpu() with	usb_endpoint_maxp()
Date: Sun, 15 Nov 2015 14:54:28 +0100	[thread overview]
Message-ID: <56488E94.1030609@ladisch.de> (raw)
In-Reply-To: <1447536690-25173-1-git-send-email-thrust73@gmail.com>

Cheah Kok Cheong wrote:
> Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")
>
> And commit 29cc88979a88 ("USB: use usb_endpoint_maxp()
> instead of le16_to_cpu()")

These sentences no verb.

> Patched against
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

This does not belong into the commit message.

> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>

Otherwise:
Acked-by: Clemens Ladisch <clemens@ladisch.de>

> ---
>  sound/usb/misc/ua101.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/usb/misc/ua101.c b/sound/usb/misc/ua101.c
> index 9581089..c19a5dd 100644
> --- a/sound/usb/misc/ua101.c
> +++ b/sound/usb/misc/ua101.c
> @@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua)
>  		return -ENXIO;
>  	}
>  	ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd));
> -	ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> +	ua->capture.max_packet_bytes = usb_endpoint_maxp(epd);
>
>  	epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc;
>  	if (!usb_endpoint_is_isoc_out(epd)) {
> @@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua)
>  		return -ENXIO;
>  	}
>  	ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd));
> -	ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> +	ua->playback.max_packet_bytes = usb_endpoint_maxp(epd);
>  	return 0;
>  }

WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de>
To: tiwai@suse.com
Cc: Cheah Kok Cheong <thrust73@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Sound: Usb: Misc: ua101: replace le16_to_cpu() with usb_endpoint_maxp()
Date: Sun, 15 Nov 2015 14:54:28 +0100	[thread overview]
Message-ID: <56488E94.1030609@ladisch.de> (raw)
In-Reply-To: <1447536690-25173-1-git-send-email-thrust73@gmail.com>

Cheah Kok Cheong wrote:
> Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")
>
> And commit 29cc88979a88 ("USB: use usb_endpoint_maxp()
> instead of le16_to_cpu()")

These sentences no verb.

> Patched against
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

This does not belong into the commit message.

> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>

Otherwise:
Acked-by: Clemens Ladisch <clemens@ladisch.de>

> ---
>  sound/usb/misc/ua101.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/usb/misc/ua101.c b/sound/usb/misc/ua101.c
> index 9581089..c19a5dd 100644
> --- a/sound/usb/misc/ua101.c
> +++ b/sound/usb/misc/ua101.c
> @@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua)
>  		return -ENXIO;
>  	}
>  	ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd));
> -	ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> +	ua->capture.max_packet_bytes = usb_endpoint_maxp(epd);
>
>  	epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc;
>  	if (!usb_endpoint_is_isoc_out(epd)) {
> @@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua)
>  		return -ENXIO;
>  	}
>  	ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd));
> -	ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> +	ua->playback.max_packet_bytes = usb_endpoint_maxp(epd);
>  	return 0;
>  }

  reply	other threads:[~2015-11-15 13:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14 21:31 [PATCH] Sound: Usb: Misc: ua101: replace le16_to_cpu() with usb_endpoint_maxp() Cheah Kok Cheong
2015-11-15 13:54 ` Clemens Ladisch [this message]
2015-11-15 13:54   ` Clemens Ladisch
2015-11-16  8:04   ` Takashi Iwai
2015-11-16  8:04     ` Takashi Iwai
2015-11-16 20:39     ` Cheah Kok Cheong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56488E94.1030609@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thrust73@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.