All of lore.kernel.org
 help / color / mirror / Atom feed
From: labbott@redhat.com (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro
Date: Mon, 16 Nov 2015 14:50:48 -0800	[thread overview]
Message-ID: <564A5DC8.9090307@redhat.com> (raw)
In-Reply-To: <CAKv+Gu_xkiH8w2gor8SEp4y2UV9KSKTp9Kjtr6C9aU7XduZ06g@mail.gmail.com>

On 11/14/2015 11:38 PM, Ard Biesheuvel wrote:
> On 12 November 2015 at 21:21, Laura Abbott <labbott@fedoraproject.org> wrote:
>> The permissions in mark_rodata_ro trigger a build error
>> with STRICT_MM_TYPECHECKS. Fix this by introducing
>> PAGE_KERNEL_ROX for the same reasons as PAGE_KERNEL_RO.
>
> Forgive the bikeshedding but perhaps PAGE_KERNEL_EXEC_RO is more consistent?
>

powerpc was using PAGE_KERNEL_ROX so I went with that. Blame powerpc ;)
  
>>  From Ard:
>>
>> "PAGE_KERNEL_EXEC has PTE_WRITE set as well, making the range
>> writeable under the ARMv8.1 DBM feature, that manages the
>> dirty bit in hardware (writing to a page with the PTE_RDONLY
>> and PTE_WRITE bits both set will clear the PTE_RDONLY bit in that case)"
>>
>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>

Thanks,
Laura

WARNING: multiple messages have this Message-ID (diff)
From: Laura Abbott <labbott@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Laura Abbott <labbott@fedoraproject.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro
Date: Mon, 16 Nov 2015 14:50:48 -0800	[thread overview]
Message-ID: <564A5DC8.9090307@redhat.com> (raw)
In-Reply-To: <CAKv+Gu_xkiH8w2gor8SEp4y2UV9KSKTp9Kjtr6C9aU7XduZ06g@mail.gmail.com>

On 11/14/2015 11:38 PM, Ard Biesheuvel wrote:
> On 12 November 2015 at 21:21, Laura Abbott <labbott@fedoraproject.org> wrote:
>> The permissions in mark_rodata_ro trigger a build error
>> with STRICT_MM_TYPECHECKS. Fix this by introducing
>> PAGE_KERNEL_ROX for the same reasons as PAGE_KERNEL_RO.
>
> Forgive the bikeshedding but perhaps PAGE_KERNEL_EXEC_RO is more consistent?
>

powerpc was using PAGE_KERNEL_ROX so I went with that. Blame powerpc ;)
  
>>  From Ard:
>>
>> "PAGE_KERNEL_EXEC has PTE_WRITE set as well, making the range
>> writeable under the ARMv8.1 DBM feature, that manages the
>> dirty bit in hardware (writing to a page with the PTE_RDONLY
>> and PTE_WRITE bits both set will clear the PTE_RDONLY bit in that case)"
>>
>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>

Thanks,
Laura


  reply	other threads:[~2015-11-16 22:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11  2:03 [PATCH 1/2] arm64: Fix STRICT_MM_TYPECHECKS errors from pgprot Laura Abbott
2015-11-11  2:03 ` Laura Abbott
2015-11-11  2:03 ` [PATCH 2/2] arm: kvm: Fix STRICT_MM_TYPECHECK errors Laura Abbott
2015-11-11  2:03   ` Laura Abbott
2015-11-14  7:02   ` Ard Biesheuvel
2015-11-14  7:02     ` Ard Biesheuvel
2015-11-14  7:02     ` Ard Biesheuvel
2015-11-11  5:51 ` [PATCH 1/2] arm64: Fix STRICT_MM_TYPECHECKS errors from pgprot Ard Biesheuvel
2015-11-11  5:51   ` Ard Biesheuvel
2015-11-11  6:02   ` Ard Biesheuvel
2015-11-11  6:02     ` Ard Biesheuvel
2015-11-12 20:21     ` [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro Laura Abbott
2015-11-12 20:21       ` Laura Abbott
2015-11-15  7:38       ` Ard Biesheuvel
2015-11-15  7:38         ` Ard Biesheuvel
2015-11-16 22:50         ` Laura Abbott [this message]
2015-11-16 22:50           ` Laura Abbott
2015-11-17  9:56           ` Ard Biesheuvel
2015-11-17  9:56             ` Ard Biesheuvel
2015-11-18 12:14       ` Catalin Marinas
2015-11-18 12:14         ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564A5DC8.9090307@redhat.com \
    --to=labbott@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.