From: Arend van Spriel <arend@broadcom.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Brett Rudley <brudley@broadcom.com>
Cc: kernel-janitors@vger.kernel.org,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: constify brcmf_bus_ops structures
Date: Tue, 17 Nov 2015 08:47:03 +0000 [thread overview]
Message-ID: <564AE987.60709@broadcom.com> (raw)
In-Reply-To: <1447518127-1994-1-git-send-email-Julia.Lawall@lip6.fr>
On 11/14/2015 05:22 PM, Julia Lawall wrote:
> The brcmf_bus_ops structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/bus.h | 2 +-
> drivers/net/wireless/brcm80211/brcmfmac/pcie.c | 2 +-
> drivers/net/wireless/brcm80211/brcmfmac/sdio.c | 2 +-
> drivers/net/wireless/brcm80211/brcmfmac/usb.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bus.h b/drivers/net/wireless/brcm80211/brcmfmac/bus.h
> index 230cad7..36093f9 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/bus.h
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bus.h
> @@ -137,7 +137,7 @@ struct brcmf_bus {
> bool always_use_fws_queue;
> bool wowl_supported;
>
> - struct brcmf_bus_ops *ops;
> + const struct brcmf_bus_ops *ops;
> struct brcmf_bus_msgbuf *msgbuf;
> };
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> index 83d8042..65ae3b0 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> @@ -1419,7 +1419,7 @@ static int brcmf_pcie_get_memdump(struct device *dev, void *data, size_t len)
> }
>
>
> -static struct brcmf_bus_ops brcmf_pcie_bus_ops = {
> +static const struct brcmf_bus_ops brcmf_pcie_bus_ops = {
> .txdata = brcmf_pcie_tx,
> .stop = brcmf_pcie_down,
> .txctl = brcmf_pcie_tx_ctlpkt,
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> index 7e74ac3..01f359e 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> @@ -4025,7 +4025,7 @@ brcmf_sdio_watchdog(unsigned long data)
> }
> }
>
> -static struct brcmf_bus_ops brcmf_sdio_bus_ops = {
> +static const struct brcmf_bus_ops brcmf_sdio_bus_ops = {
> .stop = brcmf_sdio_bus_stop,
> .preinit = brcmf_sdio_bus_preinit,
> .txdata = brcmf_sdio_bus_txdata,
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> index 689e64d..4bdd3b3 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> @@ -1163,7 +1163,7 @@ static void brcmf_usb_wowl_config(struct device *dev, bool enabled)
> device_set_wakeup_enable(devinfo->dev, false);
> }
>
> -static struct brcmf_bus_ops brcmf_usb_bus_ops = {
> +static const struct brcmf_bus_ops brcmf_usb_bus_ops = {
> .txdata = brcmf_usb_tx,
> .stop = brcmf_usb_down,
> .txctl = brcmf_usb_tx_ctlpkt,
>
WARNING: multiple messages have this Message-ID (diff)
From: Arend van Spriel <arend@broadcom.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Brett Rudley <brudley@broadcom.com>
Cc: <kernel-janitors@vger.kernel.org>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list@broadcom.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] brcmfmac: constify brcmf_bus_ops structures
Date: Tue, 17 Nov 2015 09:47:03 +0100 [thread overview]
Message-ID: <564AE987.60709@broadcom.com> (raw)
In-Reply-To: <1447518127-1994-1-git-send-email-Julia.Lawall@lip6.fr>
On 11/14/2015 05:22 PM, Julia Lawall wrote:
> The brcmf_bus_ops structures are never modified, so declare them as const.
>
> Done with the help of Coccinelle.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/bus.h | 2 +-
> drivers/net/wireless/brcm80211/brcmfmac/pcie.c | 2 +-
> drivers/net/wireless/brcm80211/brcmfmac/sdio.c | 2 +-
> drivers/net/wireless/brcm80211/brcmfmac/usb.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bus.h b/drivers/net/wireless/brcm80211/brcmfmac/bus.h
> index 230cad7..36093f9 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/bus.h
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bus.h
> @@ -137,7 +137,7 @@ struct brcmf_bus {
> bool always_use_fws_queue;
> bool wowl_supported;
>
> - struct brcmf_bus_ops *ops;
> + const struct brcmf_bus_ops *ops;
> struct brcmf_bus_msgbuf *msgbuf;
> };
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> index 83d8042..65ae3b0 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> @@ -1419,7 +1419,7 @@ static int brcmf_pcie_get_memdump(struct device *dev, void *data, size_t len)
> }
>
>
> -static struct brcmf_bus_ops brcmf_pcie_bus_ops = {
> +static const struct brcmf_bus_ops brcmf_pcie_bus_ops = {
> .txdata = brcmf_pcie_tx,
> .stop = brcmf_pcie_down,
> .txctl = brcmf_pcie_tx_ctlpkt,
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> index 7e74ac3..01f359e 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> @@ -4025,7 +4025,7 @@ brcmf_sdio_watchdog(unsigned long data)
> }
> }
>
> -static struct brcmf_bus_ops brcmf_sdio_bus_ops = {
> +static const struct brcmf_bus_ops brcmf_sdio_bus_ops = {
> .stop = brcmf_sdio_bus_stop,
> .preinit = brcmf_sdio_bus_preinit,
> .txdata = brcmf_sdio_bus_txdata,
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> index 689e64d..4bdd3b3 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/usb.c
> @@ -1163,7 +1163,7 @@ static void brcmf_usb_wowl_config(struct device *dev, bool enabled)
> device_set_wakeup_enable(devinfo->dev, false);
> }
>
> -static struct brcmf_bus_ops brcmf_usb_bus_ops = {
> +static const struct brcmf_bus_ops brcmf_usb_bus_ops = {
> .txdata = brcmf_usb_tx,
> .stop = brcmf_usb_down,
> .txctl = brcmf_usb_tx_ctlpkt,
>
next prev parent reply other threads:[~2015-11-17 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 16:22 [PATCH] brcmfmac: constify brcmf_bus_ops structures Julia Lawall
2015-11-14 16:22 ` Julia Lawall
2015-11-14 16:22 ` Julia Lawall
2015-11-17 8:47 ` Arend van Spriel [this message]
2015-11-17 8:47 ` Arend van Spriel
2015-11-26 12:55 ` Kalle Valo
2015-11-26 12:55 ` Kalle Valo
2015-11-26 12:55 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564AE987.60709@broadcom.com \
--to=arend@broadcom.com \
--cc=Julia.Lawall@lip6.fr \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.