From: Matthias Brugger <matthias.bgg@gmail.com>
To: lei liu <leilk.liu@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] spi: mediatek: single device does not require cs_gpios
Date: Tue, 17 Nov 2015 11:49:14 +0100 [thread overview]
Message-ID: <564B062A.90003@gmail.com> (raw)
In-Reply-To: <1447468039.27169.1.camel@mhfsdcap03>
On 14/11/15 03:27, lei liu wrote:
> On Mon, 2015-11-09 at 12:14 +0800, Nicolas Boichat wrote:
>> When only one device is present, it is not necessary to specify
>> cs_gpios, as the CS line can be controlled by the hardware
>> module.
>>
>> Without this patch, older device tree bindings used before
>> 37457607 "spi: mediatek: mt8173 spi multiple devices support"
>> would cause a panic on boot. This fixes the crash, and
>> re-introduces backward compatibility.
>>
>> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>
> Acked-by: Leilk Liu <leilk.liu@mediatek.com>
>
Please make sure this fix get applied to v4.3 as well.
Thanks,
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] spi: mediatek: single device does not require cs_gpios
Date: Tue, 17 Nov 2015 11:49:14 +0100 [thread overview]
Message-ID: <564B062A.90003@gmail.com> (raw)
In-Reply-To: <1447468039.27169.1.camel@mhfsdcap03>
On 14/11/15 03:27, lei liu wrote:
> On Mon, 2015-11-09 at 12:14 +0800, Nicolas Boichat wrote:
>> When only one device is present, it is not necessary to specify
>> cs_gpios, as the CS line can be controlled by the hardware
>> module.
>>
>> Without this patch, older device tree bindings used before
>> 37457607 "spi: mediatek: mt8173 spi multiple devices support"
>> would cause a panic on boot. This fixes the crash, and
>> re-introduces backward compatibility.
>>
>> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>
> Acked-by: Leilk Liu <leilk.liu@mediatek.com>
>
Please make sure this fix get applied to v4.3 as well.
Thanks,
Matthias
next prev parent reply other threads:[~2015-11-17 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 4:14 [PATCH v2] spi: mediatek: single device does not require cs_gpios Nicolas Boichat
2015-11-09 4:14 ` Nicolas Boichat
2015-11-09 4:14 ` Nicolas Boichat
[not found] ` <1447042491-1199-1-git-send-email-drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2015-11-14 2:27 ` lei liu
2015-11-14 2:27 ` lei liu
2015-11-14 2:27 ` lei liu
2015-11-17 10:49 ` Matthias Brugger [this message]
2015-11-17 10:49 ` Matthias Brugger
2015-11-16 17:51 ` Applied "spi: mediatek: single device does not require cs_gpios" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B062A.90003@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=broonie@kernel.org \
--cc=drinkcat@chromium.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.