All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 18/19] ARC: [plat-eznps] replace sync with proper cpu barrier
Date: Tue, 17 Nov 2015 16:42:49 +0530	[thread overview]
Message-ID: <564B0BB1.8080709@synopsys.com> (raw)
In-Reply-To: <1446893557-29748-19-git-send-email-noamc@ezchip.com>

On Saturday 07 November 2015 04:22 PM, Noam Camus wrote:
> From: Tal Zilcer <talz at ezchip.com>
> 
> In SMT system like we have the generic "sync" is not working with
> HW threads. The replacement is "schd.rw" instruction that is served
> as cpu barrier for HW threads.

As discussed in v2 of this patch, SYNC or some such in __switch_to is completely
superfluous. We don't need this patch, you may instead wanna submit a patch which
removes the sync. Also please do that in assembler version of this file as well !

> Signed-off-by: Noam Camus <noamc at ezchip.com>
> ---
>  arch/arc/kernel/ctx_sw.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arc/kernel/ctx_sw.c b/arch/arc/kernel/ctx_sw.c
> index 92e2e82..2a2f50e 100644
> --- a/arch/arc/kernel/ctx_sw.c
> +++ b/arch/arc/kernel/ctx_sw.c
> @@ -61,7 +61,11 @@ __switch_to(struct task_struct *prev_task, struct task_struct *next_task)
>  		"st      sp, [r24]       \n\t"
>  #endif
>  
> +#ifdef CONFIG_EZNPS_MTM_EXT
> +		".word %5   \n\t"
> +#else
>  		"sync   \n\t"
> +#endif
>  
>  		/*
>  		 * setup _current_task with incoming tsk.
> @@ -122,6 +126,9 @@ __switch_to(struct task_struct *prev_task, struct task_struct *next_task)
>  #ifdef CONFIG_ARC_PLAT_EZNPS
>  		, "i"(CTOP_AUX_LOGIC_GLOBAL_ID)
>  #endif
> +#ifdef CONFIG_EZNPS_MTM_EXT
> +		, "i"(CTOP_INST_SCHD_RW)
> +#endif
>  		: "blink"
>  	);
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Noam Camus <noamc@ezchip.com>, <linux-snps-arc@lists.infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <talz@ezchip.com>,
	<gilf@ezchip.com>, <cmetcalf@ezchip.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 18/19] ARC: [plat-eznps] replace sync with proper cpu barrier
Date: Tue, 17 Nov 2015 16:42:49 +0530	[thread overview]
Message-ID: <564B0BB1.8080709@synopsys.com> (raw)
In-Reply-To: <1446893557-29748-19-git-send-email-noamc@ezchip.com>

On Saturday 07 November 2015 04:22 PM, Noam Camus wrote:
> From: Tal Zilcer <talz@ezchip.com>
> 
> In SMT system like we have the generic "sync" is not working with
> HW threads. The replacement is "schd.rw" instruction that is served
> as cpu barrier for HW threads.

As discussed in v2 of this patch, SYNC or some such in __switch_to is completely
superfluous. We don't need this patch, you may instead wanna submit a patch which
removes the sync. Also please do that in assembler version of this file as well !

> Signed-off-by: Noam Camus <noamc@ezchip.com>
> ---
>  arch/arc/kernel/ctx_sw.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arc/kernel/ctx_sw.c b/arch/arc/kernel/ctx_sw.c
> index 92e2e82..2a2f50e 100644
> --- a/arch/arc/kernel/ctx_sw.c
> +++ b/arch/arc/kernel/ctx_sw.c
> @@ -61,7 +61,11 @@ __switch_to(struct task_struct *prev_task, struct task_struct *next_task)
>  		"st      sp, [r24]       \n\t"
>  #endif
>  
> +#ifdef CONFIG_EZNPS_MTM_EXT
> +		".word %5   \n\t"
> +#else
>  		"sync   \n\t"
> +#endif
>  
>  		/*
>  		 * setup _current_task with incoming tsk.
> @@ -122,6 +126,9 @@ __switch_to(struct task_struct *prev_task, struct task_struct *next_task)
>  #ifdef CONFIG_ARC_PLAT_EZNPS
>  		, "i"(CTOP_AUX_LOGIC_GLOBAL_ID)
>  #endif
> +#ifdef CONFIG_EZNPS_MTM_EXT
> +		, "i"(CTOP_INST_SCHD_RW)
> +#endif
>  		: "blink"
>  	);
>  
> 


  reply	other threads:[~2015-11-17 11:12 UTC|newest]

Thread overview: 190+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-31 13:15 [PATCH v1 00/20] eznps a new ARC platform Noam Camus
2015-10-31 13:15 ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 01/20] Documentation: Add EZchip vendor to binding list Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 02/20] clocksource: Add NPS400 timers driver Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-01 20:44   ` Daniel Lezcano
2015-11-01 20:44     ` Daniel Lezcano
2015-11-02  7:57     ` Noam Camus
2015-11-02  7:57       ` Noam Camus
2015-11-02 11:03   ` Vineet Gupta
2015-11-02 11:03     ` Vineet Gupta
2015-11-03 15:18     ` Noam Camus
2015-11-03 15:18       ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 03/20] irqchip: add nps Internal and external irqchips Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 04/20] ARC: Set vmalloc size from configuration Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 05/20] ARC: rwlock: disable interrupts in !LLSC variant Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  9:16   ` Peter Zijlstra
2015-11-02  9:16     ` Peter Zijlstra
2015-11-02  9:42   ` Vineet Gupta
2015-11-02  9:42     ` Vineet Gupta
2015-11-02 10:03     ` Peter Zijlstra
2015-11-02 10:03       ` Peter Zijlstra
2015-10-31 13:15 ` [PATCH v1 06/20] ARC: Mark cpu online only after it has executed the per cpu init hook Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 07/20] ARC: mm: use generic macros _BITUL() Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  6:23   ` Vineet Gupta
2015-11-02  6:23     ` Vineet Gupta
2015-11-02  6:27     ` Noam Camus
2015-11-02  6:27       ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 08/20] ARC: Use res_service as entry point for secondaries Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  6:38   ` Vineet Gupta
2015-11-02  6:38     ` Vineet Gupta
2015-11-02  8:05     ` Noam Camus
2015-11-02  8:05       ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 09/20] ARC: add CONFIG_CLKSRC_OF support to time_init() Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  6:32   ` Vineet Gupta
2015-11-02  6:32     ` Vineet Gupta
2015-10-31 13:15 ` [PATCH v1 10/20] ARC: [plat-eznps] Add eznps board defconfig and dts Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 11/20] ARC: [plat-eznps] Add eznps platform Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02 10:56   ` Vineet Gupta
2015-11-02 10:56     ` Vineet Gupta
2015-11-03 15:59     ` Noam Camus
2015-11-03 15:59       ` Noam Camus
2015-11-04 12:38     ` Noam Camus
2015-11-04 12:38       ` Noam Camus
2015-11-05  5:09   ` Vineet Gupta
2015-11-05  5:09     ` Vineet Gupta
2015-10-31 13:15 ` [PATCH v1 12/20] ARC: [plat-eznps] Use dedicated user stack top Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 13/20] ARC: [plat-eznps] Use dedicated bitops/atomic/cmpxchg Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02 11:56   ` Vineet Gupta
2015-11-02 11:56     ` Vineet Gupta
2015-10-31 13:15 ` [PATCH v1 14/20] ARC: [plat-eznps] Use dedicated SMP barriers Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  8:02   ` Vineet Gupta
2015-11-02  8:02     ` Vineet Gupta
2015-11-02 13:08     ` Noam Camus
2015-11-02 13:08       ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 15/20] ARC: [plat-eznps] Use dedicated identity auxiliary register Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 16/20] ARC: [plat-eznps] Use dedicated cpu_relax() Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  7:54   ` Vineet Gupta
2015-11-02  7:54     ` Vineet Gupta
2015-11-02  9:21   ` Peter Zijlstra
2015-11-02  9:21     ` Peter Zijlstra
2015-11-03 14:02     ` Noam Camus
2015-11-03 14:02       ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 17/20] ARC: [plat-eznps] Use dedicated COMMAND_LINE_SIZE Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 18/20] ARC: [plat-eznps] define IPI_IRQ Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  7:52   ` Vineet Gupta
2015-11-02  7:52     ` Vineet Gupta
2015-11-02 12:16     ` Noam Camus
2015-11-02 12:16       ` Noam Camus
2015-10-31 13:15 ` [PATCH v1 19/20] ARC: [plat-eznps] replace sync with proper cpu barrier Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02  7:48   ` Vineet Gupta
2015-11-02  7:48     ` Vineet Gupta
2015-11-02  9:26     ` Peter Zijlstra
2015-11-02  9:26       ` Peter Zijlstra
2015-11-17 13:48       ` [PATCH] ARC: remove SYNC from __switch_to() Vineet Gupta
2015-11-17 13:48         ` Vineet Gupta
2015-10-31 13:15 ` [PATCH v1 20/20] ARC: Add eznps platform to Kconfig and Makefile Noam Camus
2015-10-31 13:15   ` Noam Camus
2015-11-02 11:06   ` Vineet Gupta
2015-11-02 11:06     ` Vineet Gupta
2015-11-03 15:32     ` Noam Camus
2015-11-03 15:32       ` Noam Camus
2015-11-04 15:35 ` [PATCH v1 00/20] eznps a new ARC platform Vineet Gupta
2015-11-04 15:35   ` Vineet Gupta
2015-11-04 15:53   ` Noam Camus
2015-11-04 15:53     ` Noam Camus
2015-11-04 17:42     ` Vineet Gupta
2015-11-04 17:42       ` Vineet Gupta
2015-11-07 10:52 ` [PATCH v2 00/19] " Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 01/19] Documentation: Add EZchip vendor to binding list Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 02/19] ARC: [plat-eznps] define IPI_IRQ Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 03/19] clocksource: Add NPS400 timers driver Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 11:26   ` Thomas Gleixner
2015-11-07 11:26     ` Thomas Gleixner
2015-11-20 11:59     ` Noam Camus
2015-11-20 11:59       ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 04/19] irqchip: add nps Internal and external irqchips Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 11:38   ` Thomas Gleixner
2015-11-07 11:38     ` Thomas Gleixner
2015-11-07 20:52     ` Noam Camus
2015-11-07 20:52       ` Noam Camus
2015-11-07 23:52       ` Thomas Gleixner
2015-11-07 23:52         ` Thomas Gleixner
2015-11-07 10:52 ` [PATCH v2 05/19] ARC: Set vmalloc size from configuration Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 06/19] ARC: rwlock: disable interrupts in !LLSC variant Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 07/19] ARC: rename smp operation init_irq_cpu() to init_per_cpu() Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-17 11:15   ` Vineet Gupta
2015-11-17 11:15     ` Vineet Gupta
2015-11-17 11:38     ` Noam Camus
2015-11-17 11:38       ` Noam Camus
2015-11-17 11:42       ` Vineet Gupta
2015-11-17 11:42         ` Vineet Gupta
2015-11-07 10:52 ` [PATCH v2 08/19] ARC: Mark secondary cpu online only after all HW setup is done Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-17 11:17   ` Vineet Gupta
2015-11-17 11:17     ` Vineet Gupta
2015-11-07 10:52 ` [PATCH v2 09/19] ARC: add CONFIG_CLKSRC_OF support to time_init() Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 10/19] ARC: [plat-eznps] Add eznps board defconfig and dts Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 11/19] ARC: [plat-eznps] Add eznps platform Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 12/19] ARC: [plat-eznps] Use dedicated user stack top Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 13/19] ARC: [plat-eznps] Use dedicated atomic/bitops/cmpxchg Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 14/19] ARC: [plat-eznps] Use dedicated SMP barriers Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 15/19] ARC: [plat-eznps] Use dedicated identity auxiliary register Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 16/19] ARC: [plat-eznps] Use dedicated cpu_relax() Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-09 10:05   ` Peter Zijlstra
2015-11-09 10:05     ` Peter Zijlstra
2015-11-09 10:22     ` Vineet Gupta
2015-11-09 10:22       ` Vineet Gupta
2015-11-09 10:45       ` Peter Zijlstra
2015-11-09 10:45         ` Peter Zijlstra
2015-11-09 12:27         ` Vineet Gupta
2015-11-09 12:27           ` Vineet Gupta
2015-11-09 12:51           ` Peter Zijlstra
2015-11-09 12:51             ` Peter Zijlstra
2015-11-07 10:52 ` [PATCH v2 17/19] ARC: [plat-eznps] Use dedicated COMMAND_LINE_SIZE Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-07 10:52 ` [PATCH v2 18/19] ARC: [plat-eznps] replace sync with proper cpu barrier Noam Camus
2015-11-07 10:52   ` Noam Camus
2015-11-17 11:12   ` Vineet Gupta [this message]
2015-11-17 11:12     ` Vineet Gupta
2015-11-17 11:23     ` Peter Zijlstra
2015-11-17 11:23       ` Peter Zijlstra
2015-11-17 11:37       ` Vineet Gupta
2015-11-17 11:37         ` Vineet Gupta
2015-11-17 12:22         ` Peter Zijlstra
2015-11-17 12:22           ` Peter Zijlstra
2015-11-17 12:37           ` Vineet Gupta
2015-11-17 12:37             ` Vineet Gupta
2015-11-17 12:44             ` Peter Zijlstra
2015-11-17 12:44               ` Peter Zijlstra
2015-11-17 13:32               ` Vineet Gupta
2015-11-17 13:32                 ` Vineet Gupta
2015-11-17 13:59                 ` Peter Zijlstra
2015-11-17 13:59                   ` Peter Zijlstra
2015-11-07 10:52 ` [PATCH v2 19/19] ARC: Add eznps platform to Kconfig and Makefile Noam Camus
2015-11-07 10:52   ` Noam Camus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564B0BB1.8080709@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.