Re: [PATCH RFC 3/3] Revert "libxc: create an initial FPU state for HVM guests"

["Roger Pau Monné" <roger.pau@citrix.com>]

El 16/11/15 a les 12.51, Ian Campbell ha escrit:
> On Wed, 2015-10-14 at 17:30 +0100, Wei Liu wrote:
>> On Wed, Oct 14, 2015 at 06:24:40PM +0200, Roger Pau Monne wrote:
>>> This reverts commit d64dbbcc7c9934a46126c59d78536235908377ad.
>>>
>>> Xen always set the FPU as initialized when loading a HVM context, so
>>> libxc
>>> has to provide a valid FPU context when setting the CPU registers.
>>>
>>> This is a stop-gap measure in order to unblock OSSTest Windows 7
>>> failures
>>> while a proper fix for the HVM CPU save/restore is being worked on.
>>
>> I think it is better to say in the commit message that a proper fix is
>> in place so we can revert the stop-gap patch instead of copying the
>> commit message from the patch this is being reverted.
>>
>> Assuming I'm right about a proper fix will be committed before this
>> patch and the commit message fixed:
> 
> Roger, Is the "proper fix" in tree now? If so then please can we get an
> updated commit message which references that as Wei suggests.
> 
> I can update the message upon commit if you just want to provide the words,
> or feel free to resend of course.

No, a proper fix is still not in place, sorry. Let me see if I can get a
new version out today.

Roger.