All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Hunt <harvey.hunt@imgtec.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: <linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
	"Zubair Lutfullah Kakakhel" <Zubair.Kakakhel@imgtec.com>,
	<linux-kernel@vger.kernel.org>,
	Alex Smith <alex.smith@imgtec.com>,
	"Alex Smith" <alex@alex-smith.me.uk>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v7,1/3] dt-bindings: binding for jz4780-{nand,bch}
Date: Tue, 17 Nov 2015 16:25:23 +0000	[thread overview]
Message-ID: <564B54F3.3080603@imgtec.com> (raw)
In-Reply-To: <20151104085751.55fbf3c3@bbrezillon>

Hi Boris,

On 04/11/15 07:57, Boris Brezillon wrote:
> Hi Harvey,
>
> On Tue, 6 Oct 2015 17:27:15 +0100
> Harvey Hunt <harvey.hunt@imgtec.com> wrote:
>
>> From: Alex Smith <alex.smith@imgtec.com>
>>
>> Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs,
>> as well as the hardware BCH controller, used by the jz4780_{nand,bch}
>> drivers.
>
> Patch 3 does not seem to follow this binding: it still uses the
> ingenic,ecc-xxx properties and defines NAND timings.

Thanks, I'll fix that for v8.

> Also, as answered to patch 3, I think it would be clearer to separate
> the nand controller and nand chip representation.

That approach makes sense - I'll change it for the next series.

> Best Regards,
>
> Boris

Best regards,

Harvey Hunt

WARNING: multiple messages have this Message-ID (diff)
From: Harvey Hunt <harvey.hunt@imgtec.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
	linux-kernel@vger.kernel.org, Alex Smith <alex.smith@imgtec.com>,
	Alex Smith <alex@alex-smith.me.uk>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v7,1/3] dt-bindings: binding for jz4780-{nand,bch}
Date: Tue, 17 Nov 2015 16:25:23 +0000	[thread overview]
Message-ID: <564B54F3.3080603@imgtec.com> (raw)
In-Reply-To: <20151104085751.55fbf3c3@bbrezillon>

Hi Boris,

On 04/11/15 07:57, Boris Brezillon wrote:
> Hi Harvey,
>
> On Tue, 6 Oct 2015 17:27:15 +0100
> Harvey Hunt <harvey.hunt@imgtec.com> wrote:
>
>> From: Alex Smith <alex.smith@imgtec.com>
>>
>> Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs,
>> as well as the hardware BCH controller, used by the jz4780_{nand,bch}
>> drivers.
>
> Patch 3 does not seem to follow this binding: it still uses the
> ingenic,ecc-xxx properties and defines NAND timings.

Thanks, I'll fix that for v8.

> Also, as answered to patch 3, I think it would be clearer to separate
> the nand controller and nand chip representation.

That approach makes sense - I'll change it for the next series.

> Best Regards,
>
> Boris

Best regards,

Harvey Hunt

  parent reply	other threads:[~2015-11-17 16:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 16:27 [PATCH v7,0/3] mtd: nand: jz4780: Add NAND and BCH drivers Harvey Hunt
2015-10-06 16:27 ` [PATCH v7,1/3] dt-bindings: binding for jz4780-{nand,bch} Harvey Hunt
2015-10-06 16:27   ` Harvey Hunt
2015-11-04  7:57   ` Boris Brezillon
2015-11-04  7:57     ` Boris Brezillon
2015-11-17 16:08     ` Harvey Hunt
2015-11-17 16:08       ` Harvey Hunt
2015-11-17 16:25     ` Harvey Hunt [this message]
2015-11-17 16:25       ` Harvey Hunt
2015-10-06 16:27 ` [PATCH v7, 2/3] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs Harvey Hunt
2015-10-06 16:27   ` [PATCH v7,2/3] " Harvey Hunt
2015-11-04 10:18   ` [PATCH v7, 2/3] " Boris Brezillon
2015-11-17 16:28     ` Harvey Hunt
2015-11-17 19:09       ` Boris Brezillon
2015-10-06 16:27 ` [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes Harvey Hunt
2015-10-06 16:27   ` [PATCH v7, 3/3] " Harvey Hunt
2015-10-06 16:27   ` [PATCH v7,3/3] " Harvey Hunt
2015-10-08 21:22   ` Ezequiel Garcia
2015-10-14  9:15     ` Harvey Hunt
2015-10-14  9:15       ` Harvey Hunt
2015-10-15  8:47   ` James Hogan
2015-10-15  8:47     ` James Hogan
2015-10-15  8:47     ` James Hogan
2015-10-16 10:11     ` Alex Smith
2015-10-16 10:11       ` Alex Smith
2015-10-16 10:31       ` James Hogan
2015-10-16 10:31         ` James Hogan
2015-10-16 10:31         ` James Hogan
2015-10-16 10:48         ` Paul Burton
2015-10-16 10:48           ` Paul Burton
2015-11-04  7:51           ` Boris Brezillon
2015-11-04  7:51             ` Boris Brezillon
2015-11-17 16:29             ` Harvey Hunt
2015-11-17 16:29               ` Harvey Hunt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564B54F3.3080603@imgtec.com \
    --to=harvey.hunt@imgtec.com \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=alex.smith@imgtec.com \
    --cc=alex@alex-smith.me.uk \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.