From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data
Date: Wed, 18 Nov 2015 10:53:23 +0900 [thread overview]
Message-ID: <564BDA13.3040907@samsung.com> (raw)
In-Reply-To: <4020501.kQLt6nnIEv@wuerfel>
On 18.11.2015 00:54, Arnd Bergmann wrote:
> This is a minor cleanup to make the s3c2412-i2s and s3c24xx-i2s
> drivers independent of the mach/dma.h header file and to allow
> removing the dependency on the specific dmaengine driver in the
> next patch.
>
> As a side not, only the s3c24xx-i2s driver seems to still be
> used, while the definition of the s3c2412-i2s platform device was
> removed in commit 6d259a25b56d ("ARM: SAMSUNG: use static
> declaration when it is not used in other files") after it had
> never been referenced since its introduction in f0fba2ad1b6b
> ("ASoC: multi-component - ASoC Multi-Component Support").
>
> Apparently it should have been used by mach-jive.c, but that
> never happened. My patch at this point leaves the current state
> unchanged, we can decide whether to fix or delete the jive
> driver and s3c2412-i2s another time.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: check for NULL pdata
>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data
Date: Wed, 18 Nov 2015 10:53:23 +0900 [thread overview]
Message-ID: <564BDA13.3040907@samsung.com> (raw)
In-Reply-To: <4020501.kQLt6nnIEv@wuerfel>
On 18.11.2015 00:54, Arnd Bergmann wrote:
> This is a minor cleanup to make the s3c2412-i2s and s3c24xx-i2s
> drivers independent of the mach/dma.h header file and to allow
> removing the dependency on the specific dmaengine driver in the
> next patch.
>
> As a side not, only the s3c24xx-i2s driver seems to still be
> used, while the definition of the s3c2412-i2s platform device was
> removed in commit 6d259a25b56d ("ARM: SAMSUNG: use static
> declaration when it is not used in other files") after it had
> never been referenced since its introduction in f0fba2ad1b6b
> ("ASoC: multi-component - ASoC Multi-Component Support").
>
> Apparently it should have been used by mach-jive.c, but that
> never happened. My patch at this point leaves the current state
> unchanged, we can decide whether to fix or delete the jive
> driver and s3c2412-i2s another time.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: check for NULL pdata
>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-11-18 1:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 15:53 [PATCHv2] ASoC: samsung: pass DMA channels as pointers Arnd Bergmann
2015-11-17 15:53 ` Arnd Bergmann
2015-11-17 15:53 ` Arnd Bergmann
2015-11-17 15:54 ` [PATCHv2 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data Arnd Bergmann
2015-11-17 15:54 ` Arnd Bergmann
2015-11-17 15:54 ` Arnd Bergmann
2015-11-18 1:53 ` Krzysztof Kozlowski [this message]
2015-11-18 1:53 ` Krzysztof Kozlowski
2015-11-18 13:20 ` Arnd Bergmann
2015-11-18 13:20 ` Arnd Bergmann
2015-11-18 13:20 ` Arnd Bergmann
2015-11-18 13:29 ` [PATCH v3 " Arnd Bergmann
2015-11-18 13:29 ` Arnd Bergmann
2015-11-18 13:29 ` Arnd Bergmann
2015-11-18 18:09 ` Applied "ASoC: s3c24xx-i2s: pass DMA channels as platform data" to the asoc tree Mark Brown
2015-11-17 15:55 ` [PATCHv2 3/3] ASoC: samsung: pass filter function as pointer Arnd Bergmann
2015-11-17 15:55 ` Arnd Bergmann
2015-11-18 2:13 ` Krzysztof Kozlowski
2015-11-18 2:13 ` Krzysztof Kozlowski
2015-11-18 9:31 ` Arnd Bergmann
2015-11-18 9:31 ` Arnd Bergmann
2015-11-18 9:31 ` Arnd Bergmann
2015-11-18 1:33 ` [PATCHv2] ASoC: samsung: pass DMA channels as pointers Krzysztof Kozlowski
2015-11-18 1:33 ` Krzysztof Kozlowski
2015-11-18 1:33 ` Krzysztof Kozlowski
2015-11-18 18:09 ` Applied "ASoC: samsung: pass DMA channels as pointers" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564BDA13.3040907@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kgene@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.