From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: David Binderman <dcb314@hotmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: linux-4.4-rc1/drivers/leds/led-class-flash.c:111: pointless test ?
Date: Wed, 18 Nov 2015 16:35:37 +0100 [thread overview]
Message-ID: <564C9AC9.9030307@samsung.com> (raw)
In-Reply-To: <DUB128-W15AF3520E78E43963EA8339C1D0@phx.gbl>
Hi David,
Thanks for catching this. Fix applied.
On 11/17/2015 11:45 PM, David Binderman wrote:
> Hello there,
>
> [linux-4.4-rc1/drivers/leds/led-class-flash.c:111]: (style) Checking if unsigned variable 'state' is less than zero.
>
> Source code is
>
>
> if (state < 0 || state> 1) {
>
> but
>
> unsigned long state;
>
>
> Regards
>
> David Binderman
>
>
>
--
Best Regards,
Jacek Anaszewski
parent reply other threads:[~2015-11-18 15:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <DUB128-W15AF3520E78E43963EA8339C1D0@phx.gbl>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C9AC9.9030307@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=dcb314@hotmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.