* Re: linux-4.4-rc1/drivers/leds/led-class-flash.c:111: pointless test ?
[not found] <DUB128-W15AF3520E78E43963EA8339C1D0@phx.gbl>
@ 2015-11-18 15:35 ` Jacek Anaszewski
0 siblings, 0 replies; only message in thread
From: Jacek Anaszewski @ 2015-11-18 15:35 UTC (permalink / raw)
To: David Binderman; +Cc: Richard Purdie, linux-leds@vger.kernel.org
Hi David,
Thanks for catching this. Fix applied.
On 11/17/2015 11:45 PM, David Binderman wrote:
> Hello there,
>
> [linux-4.4-rc1/drivers/leds/led-class-flash.c:111]: (style) Checking if unsigned variable 'state' is less than zero.
>
> Source code is
>
>
> if (state < 0 || state> 1) {
>
> but
>
> unsigned long state;
>
>
> Regards
>
> David Binderman
>
>
>
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-18 15:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <DUB128-W15AF3520E78E43963EA8339C1D0@phx.gbl>
2015-11-18 15:35 ` linux-4.4-rc1/drivers/leds/led-class-flash.c:111: pointless test ? Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.