From: Paolo Bonzini <pbonzini@redhat.com>
To: "Han, Huaitong" <huaitong.han@intel.com>,
"ehabkost@redhat.com" <ehabkost@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"rth@twiddle.net" <rth@twiddle.net>,
"afaerber@suse.de" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling
Date: Thu, 19 Nov 2015 12:10:49 +0100 [thread overview]
Message-ID: <564DAE39.3050203@redhat.com> (raw)
In-Reply-To: <1447915017.3961.22.camel@intel.com>
On 19/11/2015 07:36, Han, Huaitong wrote:
> I understand it has always been that QEMU considers the feature of
> cpuid_7_0_ecx_feature_name as migratable. If the feature is
> unmigratable, it will been added to unmigratable_flags.
>
> A series of patches do complete a full function, moving
> cpuid_7_0_ecx_feature_name to 2/3 patch may make 2/3 patch look
> better, but make 1/3 patch look somewhat incomplete.
>
> Maybe it is a solution that adding the feature to unmigratable_flags in
> 1/3 patch, and deleting unmigratable_flags in 2/3 patch, but I think it
> is pointless.
Or just squash everything together. After all we're talking of
4 files changed, 55 insertions(+), 1 deletion(-)
It's not a large patch.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Han, Huaitong" <huaitong.han@intel.com>,
"ehabkost@redhat.com" <ehabkost@redhat.com>
Cc: "afaerber@suse.de" <afaerber@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling
Date: Thu, 19 Nov 2015 12:10:49 +0100 [thread overview]
Message-ID: <564DAE39.3050203@redhat.com> (raw)
In-Reply-To: <1447915017.3961.22.camel@intel.com>
On 19/11/2015 07:36, Han, Huaitong wrote:
> I understand it has always been that QEMU considers the feature of
> cpuid_7_0_ecx_feature_name as migratable. If the feature is
> unmigratable, it will been added to unmigratable_flags.
>
> A series of patches do complete a full function, moving
> cpuid_7_0_ecx_feature_name to 2/3 patch may make 2/3 patch look
> better, but make 1/3 patch look somewhat incomplete.
>
> Maybe it is a solution that adding the feature to unmigratable_flags in
> 1/3 patch, and deleting unmigratable_flags in 2/3 patch, but I think it
> is pointless.
Or just squash everything together. After all we're talking of
4 files changed, 55 insertions(+), 1 deletion(-)
It's not a large patch.
Paolo
next prev parent reply other threads:[~2015-11-19 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 2:20 [PATCH v3 0/3] target-i386: add memory protection-key support Huaitong Han
2015-11-18 2:20 ` [Qemu-devel] " Huaitong Han
2015-11-18 2:20 ` [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling Huaitong Han
2015-11-18 2:20 ` [Qemu-devel] " Huaitong Han
2015-11-18 15:58 ` Eduardo Habkost
2015-11-18 15:58 ` Eduardo Habkost
2015-11-19 6:36 ` Han, Huaitong
2015-11-19 6:36 ` Han, Huaitong
2015-11-19 11:10 ` Paolo Bonzini [this message]
2015-11-19 11:10 ` Paolo Bonzini
2015-11-19 14:56 ` Eduardo Habkost
2015-11-19 14:56 ` Eduardo Habkost
2015-11-18 2:20 ` [PATCH v3 2/3] target-i386: add pkeys support for xsave state handling Huaitong Han
2015-11-18 2:20 ` [Qemu-devel] " Huaitong Han
2015-11-18 2:20 ` [PATCH v3 3/3] target-i386: add pkeys support for vm migration Huaitong Han
2015-11-18 2:20 ` [Qemu-devel] " Huaitong Han
2015-11-18 17:51 ` [Qemu-devel] [PATCH v3 0/3] target-i386: add memory protection-key support Eduardo Habkost
2015-11-18 17:51 ` Eduardo Habkost
2015-11-18 21:28 ` Paolo Bonzini
2015-11-18 21:28 ` Paolo Bonzini
2015-12-04 14:57 ` Eduardo Habkost
2015-12-04 14:57 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DAE39.3050203@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=huaitong.han@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.