All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.com>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
	linux-kbuild@vger.kernel.org, nico@fluxnic.net,
	mcoquelin.stm32@gmail.com, kernel@pengutronix.de
Subject: Re: [PATCH] ARM: xip: Move XIP linking to a separate file
Date: Thu, 19 Nov 2015 16:07:04 +0100	[thread overview]
Message-ID: <564DE598.7060404@suse.com> (raw)
In-Reply-To: <1447943047-22427-1-git-send-email-chris.brandt@renesas.com>

On 2015-11-19 15:24, Chris Brandt wrote:
> When building an XIP kernel, the linker script needs to be much different
> than a conventional kernel's script. Over time, it's been difficult to
> maintain both XIP and non-XIP layouts in one linker script. Therefore,
> this patch separates the two procedures into two completely different
> files.
> 
> The new linker script is essentially a straight copy of the current script
> with all the non-CONFIG_XIP_KERNEL portions removed.
> 
> Additionally, all CONFIG_XIP_KERNEL portions have been removed from the
> existing linker script...never to return again.
> 
> From now on, for any architecture, when CONFIG_XIP_KERNEL is enabled, you
> must provide a vmlinux-xip.lds.S for the build process.

Why not have a vmlinux.lds.S and #include a vmlinux-xip.lds.S /
vmlinux-nonxip.lds.S from there? That way, you do not clutter the main
Makefile and you can reuse the boilerplate of the linker script.

Michal


WARNING: multiple messages have this Message-ID (diff)
From: mmarek@suse.com (Michal Marek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: xip: Move XIP linking to a separate file
Date: Thu, 19 Nov 2015 16:07:04 +0100	[thread overview]
Message-ID: <564DE598.7060404@suse.com> (raw)
In-Reply-To: <1447943047-22427-1-git-send-email-chris.brandt@renesas.com>

On 2015-11-19 15:24, Chris Brandt wrote:
> When building an XIP kernel, the linker script needs to be much different
> than a conventional kernel's script. Over time, it's been difficult to
> maintain both XIP and non-XIP layouts in one linker script. Therefore,
> this patch separates the two procedures into two completely different
> files.
> 
> The new linker script is essentially a straight copy of the current script
> with all the non-CONFIG_XIP_KERNEL portions removed.
> 
> Additionally, all CONFIG_XIP_KERNEL portions have been removed from the
> existing linker script...never to return again.
> 
> From now on, for any architecture, when CONFIG_XIP_KERNEL is enabled, you
> must provide a vmlinux-xip.lds.S for the build process.

Why not have a vmlinux.lds.S and #include a vmlinux-xip.lds.S /
vmlinux-nonxip.lds.S from there? That way, you do not clutter the main
Makefile and you can reuse the boilerplate of the linker script.

Michal

  reply	other threads:[~2015-11-19 15:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 14:24 [PATCH] ARM: xip: Move XIP linking to a separate file Chris Brandt
2015-11-19 14:24 ` Chris Brandt
2015-11-19 15:07 ` Michal Marek [this message]
2015-11-19 15:07   ` Michal Marek
2015-11-19 15:54 ` Nicolas Pitre
2015-11-19 15:54   ` Nicolas Pitre
2015-11-19 16:04   ` Chris Brandt
2015-11-19 16:04     ` Chris Brandt
2015-11-19 16:21     ` Michal Marek
2015-11-19 16:21       ` Michal Marek
2015-11-19 16:26       ` Chris Brandt
2015-11-19 16:26         ` Chris Brandt
2015-11-19 17:08 ` [PATCH v2] " Chris Brandt
2015-11-19 17:31   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564DE598.7060404@suse.com \
    --to=mmarek@suse.com \
    --cc=chris.brandt@renesas.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.