From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Tejun Heo <tj@kernel.org>,
davem@davemloft.net, pablo@netfilter.org, kaber@trash.net,
kadlec@blackhole.kfki.hu, lizefan@huawei.com, hannes@cmpxchg.org
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com,
daniel@iogearbox.net, nhorman@tuxdriver.com
Subject: Re: [PATCH 4/7] netprio_cgroup: limit the maximum css->id to USHRT_MAX
Date: Fri, 20 Nov 2015 10:18:14 +0100 [thread overview]
Message-ID: <564EE556.5070907@bmw-carit.de> (raw)
In-Reply-To: <1447959171-20749-5-git-send-email-tj@kernel.org>
On 11/19/2015 07:52 PM, Tejun Heo wrote:
> netprio builds per-netdev contiguous priomap array which is indexed by
> css->id. The array is allocated using kzalloc() effectively limiting
> the maximum ID supported to some thousand range. This patch caps the
> maximum supported css->id to USHRT_MAX which should be way above what
> is actually useable.
>
> This allows reducing sock->sk_cgrp_prioidx to u16 from u32. The freed
> up part will be used to overload the cgroup related fields.
> sock->sk_cgrp_prioidx's position is swapped with sk_mark so that the
> two cgroup related fields are adjacent.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Tejun Heo <tj@kernel.org>, <davem@davemloft.net>,
<pablo@netfilter.org>, <kaber@trash.net>,
<kadlec@blackhole.kfki.hu>, <lizefan@huawei.com>,
<hannes@cmpxchg.org>
Cc: <netdev@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
<coreteam@netfilter.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
<daniel@iogearbox.net>, <nhorman@tuxdriver.com>
Subject: Re: [PATCH 4/7] netprio_cgroup: limit the maximum css->id to USHRT_MAX
Date: Fri, 20 Nov 2015 10:18:14 +0100 [thread overview]
Message-ID: <564EE556.5070907@bmw-carit.de> (raw)
In-Reply-To: <1447959171-20749-5-git-send-email-tj@kernel.org>
On 11/19/2015 07:52 PM, Tejun Heo wrote:
> netprio builds per-netdev contiguous priomap array which is indexed by
> css->id. The array is allocated using kzalloc() effectively limiting
> the maximum ID supported to some thousand range. This patch caps the
> maximum supported css->id to USHRT_MAX which should be way above what
> is actually useable.
>
> This allows reducing sock->sk_cgrp_prioidx to u16 from u32. The freed
> up part will be used to overload the cgroup related fields.
> sock->sk_cgrp_prioidx's position is swapped with sk_mark so that the
> two cgroup related fields are adjacent.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
next prev parent reply other threads:[~2015-11-20 9:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 18:52 [PATCHSET v2] netfilter, cgroup: implement xt_cgroup2 match Tejun Heo
2015-11-19 18:52 ` [PATCH 1/7] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo
2015-11-19 18:52 ` [PATCH 2/7] kernfs: implement kernfs_walk_and_get() Tejun Heo
2015-11-20 4:41 ` Greg Kroah-Hartman
2015-11-20 21:12 ` Tejun Heo
[not found] ` <20151120211254.GE1574-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-11-20 21:41 ` Greg Kroah-Hartman
2015-11-20 21:41 ` Greg Kroah-Hartman
2015-11-19 18:52 ` [PATCH 3/7] cgroup: implement cgroup_get_from_path() and expose cgroup_put() Tejun Heo
2015-11-19 18:52 ` [PATCH 4/7] netprio_cgroup: limit the maximum css->id to USHRT_MAX Tejun Heo
2015-11-20 9:18 ` Daniel Wagner [this message]
2015-11-20 9:18 ` Daniel Wagner
2015-11-19 18:52 ` [PATCH 5/7] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct Tejun Heo
2015-11-19 18:52 ` [PATCH 6/7] sock, cgroup: add sock->sk_cgroup Tejun Heo
2015-11-20 11:04 ` Daniel Wagner
2015-11-20 11:04 ` Daniel Wagner
[not found] ` <564EFE25.5000906-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2015-11-20 19:12 ` Tejun Heo
2015-11-20 19:12 ` Tejun Heo
2015-11-19 18:52 ` [PATCH 7/7] netfilter: implement xt_cgroup2 match Tejun Heo
[not found] ` <1447959171-20749-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-11-19 18:57 ` [PATCH v2 iptables] libxt_cgroup2: add support for cgroup2 path matching Tejun Heo
2015-11-19 18:57 ` Tejun Heo
2015-11-19 18:58 ` [PATCH iptables] libxt_cgroup: improve wording in the man page Tejun Heo
2015-11-19 18:58 ` Tejun Heo
2015-11-20 18:59 ` [PATCHSET v2] netfilter, cgroup: implement xt_cgroup2 match David Miller
2015-11-20 18:59 ` David Miller
2015-11-20 19:56 ` Pablo Neira Ayuso
2015-11-20 19:57 ` Pablo Neira Ayuso
2015-11-20 19:57 ` Pablo Neira Ayuso
2015-11-20 21:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564EE556.5070907@bmw-carit.de \
--to=daniel.wagner@bmw-carit.de \
--cc=cgroups@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pablo@netfilter.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.