From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers
Date: Fri, 20 Nov 2015 15:38:47 +0100 [thread overview]
Message-ID: <564F3077.7020104@redhat.com> (raw)
In-Reply-To: <564B51D7.7090500@gmail.com>
Hi,
On 17-11-15 17:12, Jens Kuske wrote:
> Enable the 2 USB host controllers used on the Orange Pi Plus
> and add the necessary regulators.
>
> Signed-off-by: Reinder de Haan <patchesrdh@mveas.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Jens Kuske <jenskuske@gmail.com>
> ---
>
> Hi Hans,
>
> with these regulators USB works on the Orange Pi Plus too.
> I don't know if adding the regulators in the dts is okay, since most
> regulators are defined in the sunxi-common-regulators.dtsi, but
> we use different pins.
Thanks, I've added this to my sunxi-wip branch for now.
Regards,
Hans
p.s.
Any progress on getting the "core" H3 kernel support upstream ?
Given Arnd's remarks about how we should not hard-code the
indices in the clk driver + the very KISS nature of the
change to 1 parent-clk per gate setup I still believe
that that one is best.
Maxime ? Chen-Yu ? It would be really good to be able to
move forward with this, how do you want to proceed ?
>
> Jens
>
>
> arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 44 ++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> index e67df59..1cb6c66 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> @@ -58,6 +58,35 @@
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + reg_usb3_vbus: usb3-vbus {
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb3_vbus_pin_a>;
> + regulator-name = "usb3-vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-boot-on;
> + enable-active-high;
> + gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>;
> + };
> +};
> +
> +&ehci1 {
> + status = "okay";
> +};
> +
> +&ehci3 {
> + status = "okay";
> +};
> +
> +&pio {
> + usb3_vbus_pin_a: usb3_vbus_pin at 0 {
> + allwinner,pins = "PG11";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> };
>
> &mmc0 {
> @@ -70,8 +99,23 @@
> status = "okay";
> };
>
> +®_usb1_vbus {
> + gpio = <&pio 6 13 GPIO_ACTIVE_HIGH>;
> + status = "okay";
> +};
> +
> &uart0 {
> pinctrl-names = "default";
> pinctrl-0 = <&uart0_pins_a>;
> status = "okay";
> };
> +
> +&usb1_vbus_pin_a {
> + allwinner,pins = "PG13";
> +};
> +
> +&usbphy {
> + usb1_vbus-supply = <®_usb1_vbus>;
> + usb3_vbus-supply = <®_usb3_vbus>;
> + status = "okay";
> +};
>
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>,
Reinder de Haan
<patchesrdh-I1/eAgTnXDYAvxtiuMwx3w@public.gmane.org>,
linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers
Date: Fri, 20 Nov 2015 15:38:47 +0100 [thread overview]
Message-ID: <564F3077.7020104@redhat.com> (raw)
In-Reply-To: <564B51D7.7090500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi,
On 17-11-15 17:12, Jens Kuske wrote:
> Enable the 2 USB host controllers used on the Orange Pi Plus
> and add the necessary regulators.
>
> Signed-off-by: Reinder de Haan <patchesrdh-I1/eAgTnXDYAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>
> Hi Hans,
>
> with these regulators USB works on the Orange Pi Plus too.
> I don't know if adding the regulators in the dts is okay, since most
> regulators are defined in the sunxi-common-regulators.dtsi, but
> we use different pins.
Thanks, I've added this to my sunxi-wip branch for now.
Regards,
Hans
p.s.
Any progress on getting the "core" H3 kernel support upstream ?
Given Arnd's remarks about how we should not hard-code the
indices in the clk driver + the very KISS nature of the
change to 1 parent-clk per gate setup I still believe
that that one is best.
Maxime ? Chen-Yu ? It would be really good to be able to
move forward with this, how do you want to proceed ?
>
> Jens
>
>
> arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 44 ++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> index e67df59..1cb6c66 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> @@ -58,6 +58,35 @@
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + reg_usb3_vbus: usb3-vbus {
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb3_vbus_pin_a>;
> + regulator-name = "usb3-vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-boot-on;
> + enable-active-high;
> + gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>;
> + };
> +};
> +
> +&ehci1 {
> + status = "okay";
> +};
> +
> +&ehci3 {
> + status = "okay";
> +};
> +
> +&pio {
> + usb3_vbus_pin_a: usb3_vbus_pin@0 {
> + allwinner,pins = "PG11";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> };
>
> &mmc0 {
> @@ -70,8 +99,23 @@
> status = "okay";
> };
>
> +®_usb1_vbus {
> + gpio = <&pio 6 13 GPIO_ACTIVE_HIGH>;
> + status = "okay";
> +};
> +
> &uart0 {
> pinctrl-names = "default";
> pinctrl-0 = <&uart0_pins_a>;
> status = "okay";
> };
> +
> +&usb1_vbus_pin_a {
> + allwinner,pins = "PG13";
> +};
> +
> +&usbphy {
> + usb1_vbus-supply = <®_usb1_vbus>;
> + usb3_vbus-supply = <®_usb3_vbus>;
> + status = "okay";
> +};
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-20 14:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 19:46 [PATCH 1/5] clk: sunxi: Add support for the H3 usb phy clocks Hans de Goede
2015-11-15 19:46 ` Hans de Goede
2015-11-15 19:46 ` [PATCH 2/5] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC Hans de Goede
2015-11-15 19:46 ` Hans de Goede
2015-11-16 15:29 ` Rob Herring
2015-11-16 15:29 ` Rob Herring
2015-11-20 19:49 ` [linux-sunxi] " Priit Laes
2015-11-20 19:49 ` Priit Laes
2015-11-22 11:29 ` [linux-sunxi] " Hans de Goede
2015-11-22 11:29 ` Hans de Goede
2015-11-15 19:46 ` [PATCH 3/5] ARM: dts: sun8i: Add support for H3 usb clocks Hans de Goede
2015-11-15 19:46 ` Hans de Goede
2015-11-16 2:41 ` [linux-sunxi] " Chen-Yu Tsai
2015-11-16 2:41 ` Chen-Yu Tsai
2015-11-15 19:46 ` [PATCH 4/5] ARM: dts: sun8i: Add usbphy and usb host controller nodes Hans de Goede
2015-11-15 19:46 ` Hans de Goede
2015-11-15 19:46 ` [PATCH 5/5] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers Hans de Goede
2015-11-15 19:46 ` Hans de Goede
2015-11-16 3:00 ` [linux-sunxi] " Chen-Yu Tsai
2015-11-16 3:00 ` Chen-Yu Tsai
2015-11-16 8:11 ` [linux-sunxi] " Hans de Goede
2015-11-16 8:11 ` Hans de Goede
2015-11-17 16:12 ` [PATCH] " Jens Kuske
2015-11-17 16:12 ` Jens Kuske
2015-11-20 14:38 ` Hans de Goede [this message]
2015-11-20 14:38 ` Hans de Goede
2015-11-24 7:44 ` Maxime Ripard
2015-11-24 7:44 ` Maxime Ripard
[not found] ` <564B51D7.7090500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-23 22:20 ` Troy Dack
2015-11-24 8:50 ` [linux-sunxi] " Hans de Goede
2015-11-24 8:50 ` Hans de Goede
[not found] ` <565424B9.5010601-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-27 3:56 ` Troy Dack
2015-11-16 2:36 ` [linux-sunxi] [PATCH 1/5] clk: sunxi: Add support for the H3 usb phy clocks Chen-Yu Tsai
2015-11-16 2:36 ` Chen-Yu Tsai
2015-11-20 12:49 ` Maxime Ripard
2015-11-20 12:49 ` Maxime Ripard
2015-11-16 15:30 ` Rob Herring
2015-11-16 15:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F3077.7020104@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.