* [Cocci] [PATCH 1/1] Add SPI to platform_no_drv_owner.cocci warnings
@ 2015-11-20 22:02 ` Andrew F. Davis
0 siblings, 0 replies; 6+ messages in thread
From: Andrew F. Davis @ 2015-11-20 22:02 UTC (permalink / raw)
To: cocci
Remove .owner field if calls are used which set it automatically.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/scripts/coccinelle/api/platform_no_drv_owner.cocci b/scripts/coccinelle/api/platform_no_drv_owner.cocci
index c5e3f73f..52d5f53 100644
--- a/scripts/coccinelle/api/platform_no_drv_owner.cocci
+++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci
@@ -12,6 +12,7 @@ virtual report
declarer name module_i2c_driver;
declarer name module_platform_driver;
declarer name module_platform_driver_probe;
+declarer name module_spi_driver;
identifier __driver;
@@
(
@@ -20,6 +21,8 @@ identifier __driver;
module_platform_driver(__driver);
|
module_platform_driver_probe(__driver, ...);
+|
+ module_spi_driver(__driver);
)
@fix1 depends on match1 && patch && !context && !org && !report@
@@ -40,6 +43,15 @@ identifier match1.__driver;
}
};
+ at fix1_spi depends on match1 && patch && !context && !org && !report@
+identifier match1.__driver;
+@@
+ static struct spi_driver __driver = {
+ .driver = {
+- .owner = THIS_MODULE,
+ }
+ };
+
@match2@
identifier __driver;
@@
@@ -51,6 +63,8 @@ identifier __driver;
platform_create_bundle(&__driver, ...)
|
i2c_add_driver(&__driver)
+|
+ spi_register_driver(&__driver)
)
@fix2 depends on match2 && patch && !context && !org && !report@
@@ -71,6 +85,15 @@ identifier match2.__driver;
}
};
+ at fix2_spi depends on match2 && patch && !context && !org && !report@
+identifier match2.__driver;
+@@
+ static struct spi_driver __driver = {
+ .driver = {
+- .owner = THIS_MODULE,
+ }
+ };
+
// ----------------------------------------------------------------------------
@fix1_context depends on match1 && !patch && (context || org || report)@
@@ -95,6 +118,17 @@ position j0;
}
};
+ at fix1_spi_context depends on match1 && !patch && (context || org || report)@
+identifier match1.__driver;
+position j0;
+@@
+
+ static struct spi_driver __driver = {
+ .driver = {
+* .owner at j0 = THIS_MODULE,
+ }
+ };
+
@fix2_context depends on match2 && !patch && (context || org || report)@
identifier match2.__driver;
position j0;
@@ -117,6 +151,17 @@ position j0;
}
};
+ at fix2_spi_context depends on match2 && !patch && (context || org || report)@
+identifier match2.__driver;
+position j0;
+@@
+
+ static struct spi_driver __driver = {
+ .driver = {
+* .owner at j0 = THIS_MODULE,
+ }
+ };
+
// ----------------------------------------------------------------------------
@script:python fix1_org depends on org@
@@ -133,6 +178,13 @@ j0 << fix1_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
+ at script:python fix1_spi_org depends on org@
+j0 << fix1_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.org.print_todo(j0[0], msg)
+
@script:python fix2_org depends on org@
j0 << fix2_context.j0;
@@
@@ -147,6 +199,13 @@ j0 << fix2_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
+ at script:python fix2_spi_org depends on org@
+j0 << fix2_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.org.print_todo(j0[0], msg)
+
// ----------------------------------------------------------------------------
@script:python fix1_report depends on report@
@@ -163,6 +222,13 @@ j0 << fix1_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)
+ at script:python fix1_spi_report depends on report@
+j0 << fix1_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.report.print_report(j0[0], msg)
+
@script:python fix2_report depends on report@
j0 << fix2_context.j0;
@@
@@ -177,3 +243,10 @@ j0 << fix2_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)
+@script:python fix2_spi_report depends on report@
+j0 << fix2_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.report.print_report(j0[0], msg)
+
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/1] Add SPI to platform_no_drv_owner.cocci warnings
@ 2015-11-20 22:02 ` Andrew F. Davis
0 siblings, 0 replies; 6+ messages in thread
From: Andrew F. Davis @ 2015-11-20 22:02 UTC (permalink / raw)
To: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek,
Krzysztof Kozlowski
Cc: cocci, linux-kernel, Andrew F. Davis
Remove .owner field if calls are used which set it automatically.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/scripts/coccinelle/api/platform_no_drv_owner.cocci b/scripts/coccinelle/api/platform_no_drv_owner.cocci
index c5e3f73f..52d5f53 100644
--- a/scripts/coccinelle/api/platform_no_drv_owner.cocci
+++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci
@@ -12,6 +12,7 @@ virtual report
declarer name module_i2c_driver;
declarer name module_platform_driver;
declarer name module_platform_driver_probe;
+declarer name module_spi_driver;
identifier __driver;
@@
(
@@ -20,6 +21,8 @@ identifier __driver;
module_platform_driver(__driver);
|
module_platform_driver_probe(__driver, ...);
+|
+ module_spi_driver(__driver);
)
@fix1 depends on match1 && patch && !context && !org && !report@
@@ -40,6 +43,15 @@ identifier match1.__driver;
}
};
+@fix1_spi depends on match1 && patch && !context && !org && !report@
+identifier match1.__driver;
+@@
+ static struct spi_driver __driver = {
+ .driver = {
+- .owner = THIS_MODULE,
+ }
+ };
+
@match2@
identifier __driver;
@@
@@ -51,6 +63,8 @@ identifier __driver;
platform_create_bundle(&__driver, ...)
|
i2c_add_driver(&__driver)
+|
+ spi_register_driver(&__driver)
)
@fix2 depends on match2 && patch && !context && !org && !report@
@@ -71,6 +85,15 @@ identifier match2.__driver;
}
};
+@fix2_spi depends on match2 && patch && !context && !org && !report@
+identifier match2.__driver;
+@@
+ static struct spi_driver __driver = {
+ .driver = {
+- .owner = THIS_MODULE,
+ }
+ };
+
// ----------------------------------------------------------------------------
@fix1_context depends on match1 && !patch && (context || org || report)@
@@ -95,6 +118,17 @@ position j0;
}
};
+@fix1_spi_context depends on match1 && !patch && (context || org || report)@
+identifier match1.__driver;
+position j0;
+@@
+
+ static struct spi_driver __driver = {
+ .driver = {
+* .owner@j0 = THIS_MODULE,
+ }
+ };
+
@fix2_context depends on match2 && !patch && (context || org || report)@
identifier match2.__driver;
position j0;
@@ -117,6 +151,17 @@ position j0;
}
};
+@fix2_spi_context depends on match2 && !patch && (context || org || report)@
+identifier match2.__driver;
+position j0;
+@@
+
+ static struct spi_driver __driver = {
+ .driver = {
+* .owner@j0 = THIS_MODULE,
+ }
+ };
+
// ----------------------------------------------------------------------------
@script:python fix1_org depends on org@
@@ -133,6 +178,13 @@ j0 << fix1_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
+@script:python fix1_spi_org depends on org@
+j0 << fix1_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.org.print_todo(j0[0], msg)
+
@script:python fix2_org depends on org@
j0 << fix2_context.j0;
@@
@@ -147,6 +199,13 @@ j0 << fix2_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
+@script:python fix2_spi_org depends on org@
+j0 << fix2_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.org.print_todo(j0[0], msg)
+
// ----------------------------------------------------------------------------
@script:python fix1_report depends on report@
@@ -163,6 +222,13 @@ j0 << fix1_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)
+@script:python fix1_spi_report depends on report@
+j0 << fix1_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.report.print_report(j0[0], msg)
+
@script:python fix2_report depends on report@
j0 << fix2_context.j0;
@@
@@ -177,3 +243,10 @@ j0 << fix2_i2c_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)
+@script:python fix2_spi_report depends on report@
+j0 << fix2_spi_context.j0;
+@@
+
+msg = "No need to set .owner here. The core will do it."
+coccilib.report.print_report(j0[0], msg)
+
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Cocci] [PATCH 1/1] Add SPI to platform_no_drv_owner.cocci warnings
2015-11-20 22:02 ` Andrew F. Davis
@ 2015-11-21 4:36 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-21 4:36 UTC (permalink / raw)
To: cocci
W dniu 21.11.2015 o 07:02, Andrew F. Davis pisze:
> Remove .owner field if calls are used which set it automatically.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
Symmetric to i2c driver, looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Add SPI to platform_no_drv_owner.cocci warnings
@ 2015-11-21 4:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-21 4:36 UTC (permalink / raw)
To: Andrew F. Davis, Julia Lawall, Gilles Muller, Nicolas Palix,
Michal Marek
Cc: k.kozlowski.k, cocci, linux-kernel
W dniu 21.11.2015 o 07:02, Andrew F. Davis pisze:
> Remove .owner field if calls are used which set it automatically.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
Symmetric to i2c driver, looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cocci] [PATCH 1/1] Add SPI to platform_no_drv_owner.cocci warnings
2015-11-20 22:02 ` Andrew F. Davis
@ 2015-11-21 6:48 ` Julia Lawall
-1 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-11-21 6:48 UTC (permalink / raw)
To: cocci
On Fri, 20 Nov 2015, Andrew F. Davis wrote:
> Remove .owner field if calls are used which set it automatically.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/scripts/coccinelle/api/platform_no_drv_owner.cocci b/scripts/coccinelle/api/platform_no_drv_owner.cocci
> index c5e3f73f..52d5f53 100644
> --- a/scripts/coccinelle/api/platform_no_drv_owner.cocci
> +++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci
> @@ -12,6 +12,7 @@ virtual report
> declarer name module_i2c_driver;
> declarer name module_platform_driver;
> declarer name module_platform_driver_probe;
> +declarer name module_spi_driver;
> identifier __driver;
> @@
> (
> @@ -20,6 +21,8 @@ identifier __driver;
> module_platform_driver(__driver);
> |
> module_platform_driver_probe(__driver, ...);
> +|
> + module_spi_driver(__driver);
> )
>
> @fix1 depends on match1 && patch && !context && !org && !report@
> @@ -40,6 +43,15 @@ identifier match1.__driver;
> }
> };
>
> + at fix1_spi depends on match1 && patch && !context && !org && !report@
> +identifier match1.__driver;
> +@@
> + static struct spi_driver __driver = {
> + .driver = {
> +- .owner = THIS_MODULE,
> + }
> + };
> +
> @match2@
> identifier __driver;
> @@
> @@ -51,6 +63,8 @@ identifier __driver;
> platform_create_bundle(&__driver, ...)
> |
> i2c_add_driver(&__driver)
> +|
> + spi_register_driver(&__driver)
> )
>
> @fix2 depends on match2 && patch && !context && !org && !report@
> @@ -71,6 +85,15 @@ identifier match2.__driver;
> }
> };
>
> + at fix2_spi depends on match2 && patch && !context && !org && !report@
> +identifier match2.__driver;
> +@@
> + static struct spi_driver __driver = {
> + .driver = {
> +- .owner = THIS_MODULE,
> + }
> + };
> +
> // ----------------------------------------------------------------------------
>
> @fix1_context depends on match1 && !patch && (context || org || report)@
> @@ -95,6 +118,17 @@ position j0;
> }
> };
>
> + at fix1_spi_context depends on match1 && !patch && (context || org || report)@
> +identifier match1.__driver;
> +position j0;
> +@@
> +
> + static struct spi_driver __driver = {
> + .driver = {
> +* .owner at j0 = THIS_MODULE,
> + }
> + };
> +
> @fix2_context depends on match2 && !patch && (context || org || report)@
> identifier match2.__driver;
> position j0;
> @@ -117,6 +151,17 @@ position j0;
> }
> };
>
> + at fix2_spi_context depends on match2 && !patch && (context || org || report)@
> +identifier match2.__driver;
> +position j0;
> +@@
> +
> + static struct spi_driver __driver = {
> + .driver = {
> +* .owner at j0 = THIS_MODULE,
> + }
> + };
> +
> // ----------------------------------------------------------------------------
>
> @script:python fix1_org depends on org@
> @@ -133,6 +178,13 @@ j0 << fix1_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.org.print_todo(j0[0], msg)
>
> + at script:python fix1_spi_org depends on org@
> +j0 << fix1_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.org.print_todo(j0[0], msg)
> +
> @script:python fix2_org depends on org@
> j0 << fix2_context.j0;
> @@
> @@ -147,6 +199,13 @@ j0 << fix2_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.org.print_todo(j0[0], msg)
>
> + at script:python fix2_spi_org depends on org@
> +j0 << fix2_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.org.print_todo(j0[0], msg)
> +
> // ----------------------------------------------------------------------------
>
> @script:python fix1_report depends on report@
> @@ -163,6 +222,13 @@ j0 << fix1_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.report.print_report(j0[0], msg)
>
> + at script:python fix1_spi_report depends on report@
> +j0 << fix1_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.report.print_report(j0[0], msg)
> +
> @script:python fix2_report depends on report@
> j0 << fix2_context.j0;
> @@
> @@ -177,3 +243,10 @@ j0 << fix2_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.report.print_report(j0[0], msg)
>
> + at script:python fix2_spi_report depends on report@
> +j0 << fix2_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.report.print_report(j0[0], msg)
> +
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] Add SPI to platform_no_drv_owner.cocci warnings
@ 2015-11-21 6:48 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-11-21 6:48 UTC (permalink / raw)
To: Andrew F. Davis
Cc: Gilles Muller, Nicolas Palix, Michal Marek, Krzysztof Kozlowski,
cocci, linux-kernel
On Fri, 20 Nov 2015, Andrew F. Davis wrote:
> Remove .owner field if calls are used which set it automatically.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/scripts/coccinelle/api/platform_no_drv_owner.cocci b/scripts/coccinelle/api/platform_no_drv_owner.cocci
> index c5e3f73f..52d5f53 100644
> --- a/scripts/coccinelle/api/platform_no_drv_owner.cocci
> +++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci
> @@ -12,6 +12,7 @@ virtual report
> declarer name module_i2c_driver;
> declarer name module_platform_driver;
> declarer name module_platform_driver_probe;
> +declarer name module_spi_driver;
> identifier __driver;
> @@
> (
> @@ -20,6 +21,8 @@ identifier __driver;
> module_platform_driver(__driver);
> |
> module_platform_driver_probe(__driver, ...);
> +|
> + module_spi_driver(__driver);
> )
>
> @fix1 depends on match1 && patch && !context && !org && !report@
> @@ -40,6 +43,15 @@ identifier match1.__driver;
> }
> };
>
> +@fix1_spi depends on match1 && patch && !context && !org && !report@
> +identifier match1.__driver;
> +@@
> + static struct spi_driver __driver = {
> + .driver = {
> +- .owner = THIS_MODULE,
> + }
> + };
> +
> @match2@
> identifier __driver;
> @@
> @@ -51,6 +63,8 @@ identifier __driver;
> platform_create_bundle(&__driver, ...)
> |
> i2c_add_driver(&__driver)
> +|
> + spi_register_driver(&__driver)
> )
>
> @fix2 depends on match2 && patch && !context && !org && !report@
> @@ -71,6 +85,15 @@ identifier match2.__driver;
> }
> };
>
> +@fix2_spi depends on match2 && patch && !context && !org && !report@
> +identifier match2.__driver;
> +@@
> + static struct spi_driver __driver = {
> + .driver = {
> +- .owner = THIS_MODULE,
> + }
> + };
> +
> // ----------------------------------------------------------------------------
>
> @fix1_context depends on match1 && !patch && (context || org || report)@
> @@ -95,6 +118,17 @@ position j0;
> }
> };
>
> +@fix1_spi_context depends on match1 && !patch && (context || org || report)@
> +identifier match1.__driver;
> +position j0;
> +@@
> +
> + static struct spi_driver __driver = {
> + .driver = {
> +* .owner@j0 = THIS_MODULE,
> + }
> + };
> +
> @fix2_context depends on match2 && !patch && (context || org || report)@
> identifier match2.__driver;
> position j0;
> @@ -117,6 +151,17 @@ position j0;
> }
> };
>
> +@fix2_spi_context depends on match2 && !patch && (context || org || report)@
> +identifier match2.__driver;
> +position j0;
> +@@
> +
> + static struct spi_driver __driver = {
> + .driver = {
> +* .owner@j0 = THIS_MODULE,
> + }
> + };
> +
> // ----------------------------------------------------------------------------
>
> @script:python fix1_org depends on org@
> @@ -133,6 +178,13 @@ j0 << fix1_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.org.print_todo(j0[0], msg)
>
> +@script:python fix1_spi_org depends on org@
> +j0 << fix1_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.org.print_todo(j0[0], msg)
> +
> @script:python fix2_org depends on org@
> j0 << fix2_context.j0;
> @@
> @@ -147,6 +199,13 @@ j0 << fix2_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.org.print_todo(j0[0], msg)
>
> +@script:python fix2_spi_org depends on org@
> +j0 << fix2_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.org.print_todo(j0[0], msg)
> +
> // ----------------------------------------------------------------------------
>
> @script:python fix1_report depends on report@
> @@ -163,6 +222,13 @@ j0 << fix1_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.report.print_report(j0[0], msg)
>
> +@script:python fix1_spi_report depends on report@
> +j0 << fix1_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.report.print_report(j0[0], msg)
> +
> @script:python fix2_report depends on report@
> j0 << fix2_context.j0;
> @@
> @@ -177,3 +243,10 @@ j0 << fix2_i2c_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.report.print_report(j0[0], msg)
>
> +@script:python fix2_spi_report depends on report@
> +j0 << fix2_spi_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.report.print_report(j0[0], msg)
> +
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-21 6:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-20 22:02 [Cocci] [PATCH 1/1] Add SPI to platform_no_drv_owner.cocci warnings Andrew F. Davis
2015-11-20 22:02 ` Andrew F. Davis
2015-11-21 4:36 ` [Cocci] " Krzysztof Kozlowski
2015-11-21 4:36 ` Krzysztof Kozlowski
2015-11-21 6:48 ` [Cocci] " Julia Lawall
2015-11-21 6:48 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.