[meta-oe][PATCH] libsoc: upgrade from version 0.6 to 0.7

[meta-oe][PATCH] libsoc: upgrade from version 0.6 to 0.7

[Fathi Boudra]

* update SRCREV
* add --with-board-configs to configure
* run oe-stylize to sanitize the recipe

Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
 .../recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb}    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
 rename meta-oe/recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb} (85%)

diff --git a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
similarity index 85%
rename from meta-oe/recipes-support/libsoc/libsoc_0.6.bb
rename to meta-oe/recipes-support/libsoc/libsoc_0.7.bb
index 79c171a..1a7f4a7 100644
--- a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb
+++ b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
@@ -1,17 +1,17 @@
 SUMMARY = "Library for interfacing with common SoC peripherals"
 DESCRIPTION = "libsoc is a C library to interface with common peripherals (gpio, i2c, spi, pwm) \
                found in SoC (System on Chips) through generic Linux Kernel interfaces."
-
 HOMEPAGE = "https://github.com/jackmitch/libsoc"
-
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
+SRCREV = "4d5c5af71e225cc4e792d2166da3f3e432b08735"
 
-inherit autotools
-
-SRCREV = "3643cf161a4b37bfbdfd05437166c4a29ac3ed8d"
 SRC_URI = "git://github.com/jackmitch/libsoc.git"
 
 S = "${WORKDIR}/git"
 
+inherit autotools
+
+EXTRA_OECONF = "--with-board-configs"
+
 RDEPENDS_${PN} = "libgcc"
-- 
2.6.2

Re: [meta-oe][PATCH] libsoc: upgrade from version 0.6 to 0.7

[Jack Mitchell]

On 22/11/2015 15:45, Fathi Boudra wrote:
> * update SRCREV
> * add --with-board-configs to configure
> * run oe-stylize to sanitize the recipe
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
>   .../recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb}    | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>   rename meta-oe/recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb} (85%)
>
> diff --git a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
> similarity index 85%
> rename from meta-oe/recipes-support/libsoc/libsoc_0.6.bb
> rename to meta-oe/recipes-support/libsoc/libsoc_0.7.bb
> index 79c171a..1a7f4a7 100644
> --- a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb
> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
> @@ -1,17 +1,17 @@
>   SUMMARY = "Library for interfacing with common SoC peripherals"
>   DESCRIPTION = "libsoc is a C library to interface with common peripherals (gpio, i2c, spi, pwm) \
>                  found in SoC (System on Chips) through generic Linux Kernel interfaces."
> -
>   HOMEPAGE = "https://github.com/jackmitch/libsoc"
> -
>   LICENSE = "LGPLv2.1"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
> +SRCREV = "4d5c5af71e225cc4e792d2166da3f3e432b08735"
>
> -inherit autotools
> -
> -SRCREV = "3643cf161a4b37bfbdfd05437166c4a29ac3ed8d"
>   SRC_URI = "git://github.com/jackmitch/libsoc.git"
>
>   S = "${WORKDIR}/git"
>
> +inherit autotools
> +
> +EXTRA_OECONF = "--with-board-configs"

I think this should be a packageconfig, you don't want to ship board 
files by default. Most boards will not be supported (as they will be 
custom in-house boards) and as such just clutter up the users filesystem 
and waste space.

> +
>   RDEPENDS_${PN} = "libgcc"
>

Re: [meta-oe][PATCH] libsoc: upgrade from version 0.6 to 0.7

[Koen Kooi]

> Op 22 nov. 2015, om 16:45 heeft Fathi Boudra <fathi.boudra@linaro.org> het volgende geschreven:
> 
> * update SRCREV
> * add --with-board-configs to configure
> * run oe-stylize to sanitize the recipe

OE-stylize tends to remove the blank lines that are supposed to be there, so...

> 
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> .../recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb}    | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> rename meta-oe/recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb} (85%)
> 
> diff --git a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
> similarity index 85%
> rename from meta-oe/recipes-support/libsoc/libsoc_0.6.bb
> rename to meta-oe/recipes-support/libsoc/libsoc_0.7.bb
> index 79c171a..1a7f4a7 100644
> --- a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb
> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
> @@ -1,17 +1,17 @@
> SUMMARY = "Library for interfacing with common SoC peripherals"
> DESCRIPTION = "libsoc is a C library to interface with common peripherals (gpio, i2c, spi, pwm) \
>                found in SoC (System on Chips) through generic Linux Kernel interfaces."
> -
> HOMEPAGE = "https://github.com/jackmitch/libsoc”
> -

… the 2 above need to stay in

> LICENSE = "LGPLv2.1"
> LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5”

add one here

> +SRCREV = “4d5c5af71e225cc4e792d2166da3f3e432b08735"
> 

and drop this one so SRC* lines are together

> -inherit autotools
> -
> -SRCREV = "3643cf161a4b37bfbdfd05437166c4a29ac3ed8d"
> SRC_URI = "git://github.com/jackmitch/libsoc.git"
> 
> S = "${WORKDIR}/git"
> 
> +inherit autotools
> +
> +EXTRA_OECONF = "--with-board-configs"
> +
> RDEPENDS_${PN} = "libgcc"
> -- 
> 2.6.2
> 
> 

Re: [meta-oe][PATCH] libsoc: upgrade from version 0.6 to 0.7

[Fathi Boudra]

On 22 November 2015 at 18:34, Jack Mitchell <ml@communistcode.co.uk> wrote:
>
>
> On 22/11/2015 15:45, Fathi Boudra wrote:
>>
>> * update SRCREV
>> * add --with-board-configs to configure
>> * run oe-stylize to sanitize the recipe
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>> ---
>>   .../recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb}    | 10
>> +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>   rename meta-oe/recipes-support/libsoc/{libsoc_0.6.bb => libsoc_0.7.bb}
>> (85%)
>>
>> diff --git a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb
>> b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
>> similarity index 85%
>> rename from meta-oe/recipes-support/libsoc/libsoc_0.6.bb
>> rename to meta-oe/recipes-support/libsoc/libsoc_0.7.bb
>> index 79c171a..1a7f4a7 100644
>> --- a/meta-oe/recipes-support/libsoc/libsoc_0.6.bb
>> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.7.bb
>> @@ -1,17 +1,17 @@
>>   SUMMARY = "Library for interfacing with common SoC peripherals"
>>   DESCRIPTION = "libsoc is a C library to interface with common
>> peripherals (gpio, i2c, spi, pwm) \
>>                  found in SoC (System on Chips) through generic Linux
>> Kernel interfaces."
>> -
>>   HOMEPAGE = "https://github.com/jackmitch/libsoc"
>> -
>>   LICENSE = "LGPLv2.1"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
>> +SRCREV = "4d5c5af71e225cc4e792d2166da3f3e432b08735"
>>
>> -inherit autotools
>> -
>> -SRCREV = "3643cf161a4b37bfbdfd05437166c4a29ac3ed8d"
>>   SRC_URI = "git://github.com/jackmitch/libsoc.git"
>>
>>   S = "${WORKDIR}/git"
>>
>> +inherit autotools
>> +
>> +EXTRA_OECONF = "--with-board-configs"
>
>
> I think this should be a packageconfig, you don't want to ship board files
> by default. Most boards will not be supported (as they will be custom
> in-house boards) and as such just clutter up the users filesystem and waste
> space.

I'm not convinced 1.4k can be considered as waste of space. I'll
simply remove them in patch v2 as it was before.

>> +
>>   RDEPENDS_${PN} = "libgcc"
>>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel