All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: dmaengine <dmaengine@vger.kernel.org>,
	Timur Tabi <timur@codeaurora.org>,
	cov@codeaurora.org, jcm@redhat.com,
	Andy Gross <agross@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
	linux-arm-msm@vger.kernel.org,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver
Date: Sun, 22 Nov 2015 21:31:35 -0500	[thread overview]
Message-ID: <56527A87.80201@codeaurora.org> (raw)
In-Reply-To: <CAHp75VdAdrbQv1EY+KDsoAbyGURxfr+3c5f=-w=OR4MhBoWDHA@mail.gmail.com>

>>>
>>> Can it be like
>>>
>>> /sys/…/DEVICExx/
>>>  channelYY/
>>>  attr1
>>>  attr2
>>>  …
>>>
>>> ?
>>
>> I'll work on it. I didn't know that you are allowed to create subdirectories
>> in sysfs. I was just creating attributes to keep it simple. But, your
>> suggestion is cleaner.
>>
>>>
>>> I think it will be easier to handle in code and from user. (Similar
>>> way DMAEngine API does for slave DMA devices)
>>
>> Now, the good stuff. Can you clarify your comment? I didn't understand it.
> 
> I meant that DMAEngine uses
> /sys/class/dma
>  dmaYchannelX/
>   attr1
>   attr2
>   …
> 
> layout.
> 

I have posted v7 with this change.


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver
Date: Sun, 22 Nov 2015 21:31:35 -0500	[thread overview]
Message-ID: <56527A87.80201@codeaurora.org> (raw)
In-Reply-To: <CAHp75VdAdrbQv1EY+KDsoAbyGURxfr+3c5f=-w=OR4MhBoWDHA@mail.gmail.com>

>>>
>>> Can it be like
>>>
>>> /sys/?/DEVICExx/
>>>  channelYY/
>>>  attr1
>>>  attr2
>>>  ?
>>>
>>> ?
>>
>> I'll work on it. I didn't know that you are allowed to create subdirectories
>> in sysfs. I was just creating attributes to keep it simple. But, your
>> suggestion is cleaner.
>>
>>>
>>> I think it will be easier to handle in code and from user. (Similar
>>> way DMAEngine API does for slave DMA devices)
>>
>> Now, the good stuff. Can you clarify your comment? I didn't understand it.
> 
> I meant that DMAEngine uses
> /sys/class/dma
>  dmaYchannelX/
>   attr1
>   attr2
>   ?
> 
> layout.
> 

I have posted v7 with this change.


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project

  reply	other threads:[~2015-11-23  2:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-22 16:37 [PATCH V6 0/3] dma: add Qualcomm Technologies HIDMA driver Sinan Kaya
2015-11-22 16:37 ` Sinan Kaya
2015-11-22 16:37 ` [PATCH V6 1/3] dma: qcom_bam_dma: move to qcom directory Sinan Kaya
2015-11-22 16:37   ` Sinan Kaya
2015-11-22 16:37 ` [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2015-11-22 16:37   ` Sinan Kaya
2015-11-22 17:14   ` Andy Shevchenko
2015-11-22 17:14     ` Andy Shevchenko
2015-11-22 19:52     ` okaya
2015-11-22 19:52       ` okaya at codeaurora.org
2015-11-22 20:41       ` Andy Shevchenko
2015-11-22 20:41         ` Andy Shevchenko
2015-11-23  2:31         ` Sinan Kaya [this message]
2015-11-23  2:31           ` Sinan Kaya
2015-11-22 16:37 ` [PATCH V6 3/3] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2015-11-22 16:37   ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56527A87.80201@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=cov@codeaurora.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.