All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Tejun Heo <tj@kernel.org>,
	davem@davemloft.net, pablo@netfilter.org, kaber@trash.net,
	kadlec@blackhole.kfki.hu, daniel@iogearbox.net,
	nhorman@tuxdriver.co
Cc: lizefan@huawei.com, hannes@cmpxchg.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@fb.com, ninasc@fb.com,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH 7/9] sock, cgroup: add sock->sk_cgroup
Date: Mon, 23 Nov 2015 14:02:03 +0100	[thread overview]
Message-ID: <56530E4B.4090209@bmw-carit.de> (raw)
In-Reply-To: <1448122441-9335-8-git-send-email-tj@kernel.org>

Hi Tejun,

On 11/21/2015 05:13 PM, Tejun Heo wrote:
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Daniel Wagner <daniel.wagner@bmw-carit.de>

I did a quick test and for new connection the cgroup2 match worked as
expected. For an existing connection I wasn't able to trigger the match.

It is quite likely I do something wrong:

	ssh into the box
	# mkdir /sys/fs/cgroup/test
	# echo $$ > /sys/fs/cgroup/test/cgroup.procs
	# echo $PPID > /sys/fs/cgroup/test/cgroup.procs
	# iptables -A OUTPUT -m cgroup --path test

Should I see matches with the existing ssh session?

cheers,
daniel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Tejun Heo <tj@kernel.org>, <davem@davemloft.net>,
	<pablo@netfilter.org>, <kaber@trash.net>,
	<kadlec@blackhole.kfki.hu>, <daniel@iogearbox.net>,
	<nhorman@tuxdriver.co>
Cc: <lizefan@huawei.com>, <hannes@cmpxchg.org>,
	<netdev@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
	<coreteam@netfilter.org>, <cgroups@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
	<ninasc@fb.com>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH 7/9] sock, cgroup: add sock->sk_cgroup
Date: Mon, 23 Nov 2015 14:02:03 +0100	[thread overview]
Message-ID: <56530E4B.4090209@bmw-carit.de> (raw)
In-Reply-To: <1448122441-9335-8-git-send-email-tj@kernel.org>

Hi Tejun,

On 11/21/2015 05:13 PM, Tejun Heo wrote:
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Daniel Wagner <daniel.wagner@bmw-carit.de>

I did a quick test and for new connection the cgroup2 match worked as
expected. For an existing connection I wasn't able to trigger the match.

It is quite likely I do something wrong:

	ssh into the box
	# mkdir /sys/fs/cgroup/test
	# echo $$ > /sys/fs/cgroup/test/cgroup.procs
	# echo $PPID > /sys/fs/cgroup/test/cgroup.procs
	# iptables -A OUTPUT -m cgroup --path test

Should I see matches with the existing ssh session?

cheers,
daniel

  reply	other threads:[~2015-11-23 13:02 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21 16:13 [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-11-21 16:13 ` Tejun Heo
2015-11-21 16:13 ` [PATCH 1/9] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo
2015-11-21 16:13 ` [PATCH 2/9] kernfs: implement kernfs_walk_and_get() Tejun Heo
2015-11-21 16:13 ` [PATCH 4/9] cgroups: Allow dynamically changing net_classid Tejun Heo
2015-11-21 16:13 ` [PATCH 5/9] netprio_cgroup: limit the maximum css->id to USHRT_MAX Tejun Heo
2015-11-21 16:13 ` [PATCH 6/9] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct Tejun Heo
2015-11-21 16:13 ` [PATCH 7/9] sock, cgroup: add sock->sk_cgroup Tejun Heo
2015-11-23 13:02   ` Daniel Wagner [this message]
2015-11-23 13:02     ` Daniel Wagner
     [not found]     ` <56530E4B.4090209-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2015-11-23 15:48       ` Tejun Heo
2015-11-23 15:48         ` Tejun Heo
2015-11-23 15:53         ` Daniel Wagner
2015-11-23 15:53           ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 8/9] netfilter: prepare xt_cgroup for multi revisions Tejun Heo
2015-11-23 12:44   ` Daniel Wagner
2015-11-23 12:44     ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo
     [not found]   ` <1448122441-9335-10-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-11-21 16:56     ` Florian Westphal
2015-11-21 16:56       ` Florian Westphal
     [not found]       ` <20151121165605.GC25336-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2015-11-21 17:04         ` Tejun Heo
2015-11-21 17:04           ` Tejun Heo
2015-11-21 18:54           ` Florian Westphal
2015-11-21 20:26             ` Jan Engelhardt
2015-11-23 13:43             ` Daniel Borkmann
     [not found]               ` <565317F0.2030502-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2015-11-23 13:51                 ` Daniel Borkmann
2015-11-23 13:51                   ` Daniel Borkmann
2015-11-23 15:40                 ` Tejun Heo
2015-11-23 15:40                   ` Tejun Heo
2015-11-23 17:35       ` David Laight
     [not found]         ` <063D6719AE5E284EB5DD2968C1650D6D1CBDA8E2-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2015-11-23 17:55           ` Jan Engelhardt
2015-11-23 17:55             ` Jan Engelhardt
2015-11-23 17:55             ` Jan Engelhardt
2015-11-23 12:43     ` Daniel Wagner
2015-11-23 12:43       ` Daniel Wagner
2015-11-23 12:43       ` Daniel Wagner
     [not found]       ` <565309D5.80707-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2015-11-23 15:41         ` Tejun Heo
2015-11-23 15:41           ` Tejun Heo
2015-11-21 16:17 ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-11-21 16:18 ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Tejun Heo
     [not found]   ` <20151121161846.GB3428-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-11-21 16:19     ` [PATCH 2/2 iptables] libxt_cgroup: add support for cgroup2 path matching Tejun Heo
2015-11-21 16:19       ` Tejun Heo
2015-11-22 20:31   ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Pablo Neira Ayuso
2015-11-22 20:34     ` Pablo Neira Ayuso
2015-11-22 20:34       ` Pablo Neira Ayuso
     [not found] ` <1448122441-9335-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-11-21 16:13   ` [PATCH 3/9] cgroup: implement cgroup_get_from_path() and expose cgroup_put() Tejun Heo
2015-11-21 16:13     ` Tejun Heo
2015-11-23  7:11   ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Daniel Wagner
2015-11-23  7:11     ` Daniel Wagner
2015-11-23  7:11     ` Daniel Wagner
     [not found]     ` <5652BC3A.1010701-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2015-11-23  8:54       ` Daniel Wagner
2015-11-23  8:54         ` Daniel Wagner
2015-11-23  8:54         ` Daniel Wagner
     [not found]         ` <5652D448.3080002-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2015-11-23 15:53           ` Tejun Heo
2015-11-23 15:53             ` Tejun Heo
     [not found]             ` <20151123155346.GE3049-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-11-23 15:57               ` Daniel Wagner
2015-11-23 15:57                 ` Daniel Wagner
2015-11-23 15:57                 ` Daniel Wagner
2015-11-23 19:58             ` Tejun Heo
2015-11-23 20:45 ` David Miller
     [not found]   ` <20151123.154523.125969708507852672.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-11-23 20:54     ` Tejun Heo
2015-11-23 20:54       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56530E4B.4090209@bmw-carit.de \
    --to=daniel.wagner@bmw-carit.de \
    --cc=cgroups@vger.kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hannes@cmpxchg.org \
    --cc=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nhorman@tuxdriver.co \
    --cc=nhorman@tuxdriver.com \
    --cc=ninasc@fb.com \
    --cc=pablo@netfilter.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.