From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dmaengine: at_xdmac: fix macro typo
Date: Mon, 23 Nov 2015 15:41:45 +0100 [thread overview]
Message-ID: <565325A9.6020604@atmel.com> (raw)
In-Reply-To: <1448284184-15171-1-git-send-email-ludovic.desroches@atmel.com>
Le 23/11/2015 14:09, Ludovic Desroches a ?crit :
> Fix typo in a macro which was not used until now. It explains why there
> is no error at compilation time.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Fixes: e1f7c9eee707 "dmaengine: at_xdmac: creation of the atmel eXtended
> DMA Controller driver"
> Cc: stable at vger.kernel.org # 3.19 and later
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/dma/at_xdmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 7f039de..d09277f 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -156,7 +156,7 @@
> #define AT_XDMAC_CC_WRIP (0x1 << 23) /* Write in Progress (read only) */
> #define AT_XDMAC_CC_WRIP_DONE (0x0 << 23)
> #define AT_XDMAC_CC_WRIP_IN_PROGRESS (0x1 << 23)
> -#define AT_XDMAC_CC_PERID(i) (0x7f & (h) << 24) /* Channel Peripheral Identifier */
> +#define AT_XDMAC_CC_PERID(i) (0x7f & (i) << 24) /* Channel Peripheral Identifier */
> #define AT_XDMAC_CDS_MSP 0x2C /* Channel Data Stride Memory Set Pattern */
> #define AT_XDMAC_CSUS 0x30 /* Channel Source Microblock Stride */
> #define AT_XDMAC_CDUS 0x34 /* Channel Destination Microblock Stride */
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Ludovic Desroches <ludovic.desroches@atmel.com>, <vinod.koul@intel.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dmaengine: at_xdmac: fix macro typo
Date: Mon, 23 Nov 2015 15:41:45 +0100 [thread overview]
Message-ID: <565325A9.6020604@atmel.com> (raw)
In-Reply-To: <1448284184-15171-1-git-send-email-ludovic.desroches@atmel.com>
Le 23/11/2015 14:09, Ludovic Desroches a écrit :
> Fix typo in a macro which was not used until now. It explains why there
> is no error at compilation time.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Fixes: e1f7c9eee707 "dmaengine: at_xdmac: creation of the atmel eXtended
> DMA Controller driver"
> Cc: stable@vger.kernel.org # 3.19 and later
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/dma/at_xdmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 7f039de..d09277f 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -156,7 +156,7 @@
> #define AT_XDMAC_CC_WRIP (0x1 << 23) /* Write in Progress (read only) */
> #define AT_XDMAC_CC_WRIP_DONE (0x0 << 23)
> #define AT_XDMAC_CC_WRIP_IN_PROGRESS (0x1 << 23)
> -#define AT_XDMAC_CC_PERID(i) (0x7f & (h) << 24) /* Channel Peripheral Identifier */
> +#define AT_XDMAC_CC_PERID(i) (0x7f & (i) << 24) /* Channel Peripheral Identifier */
> #define AT_XDMAC_CDS_MSP 0x2C /* Channel Data Stride Memory Set Pattern */
> #define AT_XDMAC_CSUS 0x30 /* Channel Source Microblock Stride */
> #define AT_XDMAC_CDUS 0x34 /* Channel Destination Microblock Stride */
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-11-23 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 13:09 [PATCH 1/2] dmaengine: at_xdmac: fix macro typo Ludovic Desroches
2015-11-23 13:09 ` Ludovic Desroches
2015-11-23 13:09 ` [PATCH 2/2] dmaengine: at_xdmac: fix spurious flag status for mem2mem transfers Ludovic Desroches
2015-11-23 13:09 ` Ludovic Desroches
2015-11-23 14:42 ` Nicolas Ferre
2015-11-23 14:42 ` Nicolas Ferre
2015-11-23 14:41 ` Nicolas Ferre [this message]
2015-11-23 14:41 ` [PATCH 1/2] dmaengine: at_xdmac: fix macro typo Nicolas Ferre
2015-12-05 8:18 ` Vinod Koul
2015-12-05 8:18 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565325A9.6020604@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.