From: Lars-Peter Clausen <lars@metafoo.de>
To: Ranjit Waghmode <ranjit.waghmode@xilinx.com>,
jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sbhatta@xilinx.com,
punnaia@xilinx.com
Subject: Re: [LINUX PATCH] iio: xadc: fix for extended name remains same issue
Date: Tue, 24 Nov 2015 08:44:38 +0100 [thread overview]
Message-ID: <56541566.80604@metafoo.de> (raw)
In-Reply-To: <1448345847-15051-1-git-send-email-ranjit.waghmode@xilinx.com>
On 11/24/2015 07:17 AM, Ranjit Waghmode wrote:
> If we read channel details based on the device tree entry; channel’s scan_index
> and channel’s address were overwritten by scan_index and address of channel
> based on device tree. But extended name were remaining same because of which
> sysfs entry names were continuous.
I don't understand this part. Those channels don't have a extended name,
they are always NULL. Those are added as part of this patch as well, but the
patch description makes it sound like it is a fix for a existing issue.
>
> So this patch takes care of the above issue by updating 'channels' structure
> inside xadc_parse_dt() function with the help of 'xadc_channels' structure
> so that every channel's parameters will be updated properly. Also for the
> sake of simplicity this patch updates default values for extend_name.
We can't really do that, that would break existing applications. And to be
honest I don't think regular channels should have a extended name.
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [LINUX PATCH] iio: xadc: fix for extended name remains same issue
Date: Tue, 24 Nov 2015 08:44:38 +0100 [thread overview]
Message-ID: <56541566.80604@metafoo.de> (raw)
In-Reply-To: <1448345847-15051-1-git-send-email-ranjit.waghmode@xilinx.com>
On 11/24/2015 07:17 AM, Ranjit Waghmode wrote:
> If we read channel details based on the device tree entry; channel?s scan_index
> and channel?s address were overwritten by scan_index and address of channel
> based on device tree. But extended name were remaining same because of which
> sysfs entry names were continuous.
I don't understand this part. Those channels don't have a extended name,
they are always NULL. Those are added as part of this patch as well, but the
patch description makes it sound like it is a fix for a existing issue.
>
> So this patch takes care of the above issue by updating 'channels' structure
> inside xadc_parse_dt() function with the help of 'xadc_channels' structure
> so that every channel's parameters will be updated properly. Also for the
> sake of simplicity this patch updates default values for extend_name.
We can't really do that, that would break existing applications. And to be
honest I don't think regular channels should have a extended name.
next prev parent reply other threads:[~2015-11-24 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 6:17 [LINUX PATCH] iio: xadc: fix for extended name remains same issue Ranjit Waghmode
2015-11-24 6:17 ` Ranjit Waghmode
2015-11-24 7:44 ` Lars-Peter Clausen [this message]
2015-11-24 7:44 ` Lars-Peter Clausen
2015-11-30 10:42 ` Ranjit Abhimanyu Waghmode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56541566.80604@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
--cc=punnaia@xilinx.com \
--cc=ranjit.waghmode@xilinx.com \
--cc=sbhatta@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.