All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES
Date: Tue, 24 Nov 2015 11:20:43 +0100	[thread overview]
Message-ID: <565439FB.6050800@suse.com> (raw)
In-Reply-To: <3799453.oCg1CdOrtm@wuerfel>

On 2015-11-23 17:26, Arnd Bergmann wrote:
> These are all false positives that either rob someone's time when trying
> to figure out whether they are real, or they get people to send wrong
> patches to shut up the warnings.
[...]
> diff --git a/Makefile b/Makefile
> index 5e01a416c6e4..f8b921658f29 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -626,7 +626,11 @@ KBUILD_CFLAGS	+= $(call cc-option,-fno-delete-null-pointer-checks,)
>  ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
>  KBUILD_CFLAGS	+= -Os $(call cc-disable-warning,maybe-uninitialized,)
>  else
> -KBUILD_CFLAGS	+= -O2
> +ifdef CONFIG_PROFILE_ALL_BRANCHES
> +KBUILD_CFLAGS	+= -O2 $(call cc-disable-warning,maybe-uninitialized,)
> +else
> +KBUILD_CFLAGS   += -O2
> +endif

Does it only happen with -O2? Normally, we would add it outside the
ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE.

Michal

WARNING: multiple messages have this Message-ID (diff)
From: mmarek@suse.com (Michal Marek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES
Date: Tue, 24 Nov 2015 11:20:43 +0100	[thread overview]
Message-ID: <565439FB.6050800@suse.com> (raw)
In-Reply-To: <3799453.oCg1CdOrtm@wuerfel>

On 2015-11-23 17:26, Arnd Bergmann wrote:
> These are all false positives that either rob someone's time when trying
> to figure out whether they are real, or they get people to send wrong
> patches to shut up the warnings.
[...]
> diff --git a/Makefile b/Makefile
> index 5e01a416c6e4..f8b921658f29 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -626,7 +626,11 @@ KBUILD_CFLAGS	+= $(call cc-option,-fno-delete-null-pointer-checks,)
>  ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
>  KBUILD_CFLAGS	+= -Os $(call cc-disable-warning,maybe-uninitialized,)
>  else
> -KBUILD_CFLAGS	+= -O2
> +ifdef CONFIG_PROFILE_ALL_BRANCHES
> +KBUILD_CFLAGS	+= -O2 $(call cc-disable-warning,maybe-uninitialized,)
> +else
> +KBUILD_CFLAGS   += -O2
> +endif

Does it only happen with -O2? Normally, we would add it outside the
ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE.

Michal

  reply	other threads:[~2015-11-24 10:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 16:26 [PATCH] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES Arnd Bergmann
2015-11-23 16:26 ` Arnd Bergmann
2015-11-24 10:20 ` Michal Marek [this message]
2015-11-24 10:20   ` Michal Marek
2015-11-24 10:42   ` Arnd Bergmann
2015-11-24 10:42     ` Arnd Bergmann
2015-11-24 10:42     ` Arnd Bergmann
2015-11-24 12:07     ` Michal Marek
2015-11-24 12:07       ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565439FB.6050800@suse.com \
    --to=mmarek@suse.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.