All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>,
	linux-kernel@vger.kernel.org
Cc: airlied@linux.ie, laurent.pinchart@ideasonboard.com,
	grygorii.strashko@linaro.org, robdclark@gmail.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [RESEND PATCH] drm: omapdrm: tiler: Remove unneded module alias for tiler
Date: Tue, 24 Nov 2015 12:32:02 +0200	[thread overview]
Message-ID: <56543CA2.4090507@ti.com> (raw)
In-Reply-To: <1445352511-30910-1-git-send-email-luisbg@osg.samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]



On 20/10/15 17:48, Luis de Bethencourt wrote:
> omap_dmm_tiler.c can't be compiled as a module and it is built
> unconditionally as part of omapdrm. Since it can't be used as a module,
> there is no need for it to have an unused MODULE_ALIAS().
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hi,
> 
> This is a resend of a patch sent September 24 [0]
> 
> Submitting the removal of MODULE_ALIAS("platform:" DMM_DRIVER_NAME):
> As discussed with Tomi Valkeinen in:
> https://lkml.org/lkml/2015/9/24/379
> 
> Thanks,
> Luis
> 
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 7841970..51554c9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1030,4 +1030,3 @@ struct platform_driver omap_dmm_driver = {
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Andy Gross <andy.gross@ti.com>");
>  MODULE_DESCRIPTION("OMAP DMM/Tiler Driver");
> -MODULE_ALIAS("platform:" DMM_DRIVER_NAME);
> 

Thanks, applying to my 4.5 branch.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>,
	<linux-kernel@vger.kernel.org>
Cc: <airlied@linux.ie>, <laurent.pinchart@ideasonboard.com>,
	<grygorii.strashko@linaro.org>, <robdclark@gmail.com>,
	<dri-devel@lists.freedesktop.org>
Subject: Re: [RESEND PATCH] drm: omapdrm: tiler: Remove unneded module alias for tiler
Date: Tue, 24 Nov 2015 12:32:02 +0200	[thread overview]
Message-ID: <56543CA2.4090507@ti.com> (raw)
In-Reply-To: <1445352511-30910-1-git-send-email-luisbg@osg.samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]



On 20/10/15 17:48, Luis de Bethencourt wrote:
> omap_dmm_tiler.c can't be compiled as a module and it is built
> unconditionally as part of omapdrm. Since it can't be used as a module,
> there is no need for it to have an unused MODULE_ALIAS().
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hi,
> 
> This is a resend of a patch sent September 24 [0]
> 
> Submitting the removal of MODULE_ALIAS("platform:" DMM_DRIVER_NAME):
> As discussed with Tomi Valkeinen in:
> https://lkml.org/lkml/2015/9/24/379
> 
> Thanks,
> Luis
> 
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 7841970..51554c9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1030,4 +1030,3 @@ struct platform_driver omap_dmm_driver = {
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Andy Gross <andy.gross@ti.com>");
>  MODULE_DESCRIPTION("OMAP DMM/Tiler Driver");
> -MODULE_ALIAS("platform:" DMM_DRIVER_NAME);
> 

Thanks, applying to my 4.5 branch.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-11-24 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 14:48 [RESEND PATCH] drm: omapdrm: tiler: Remove unneded module alias for tiler Luis de Bethencourt
2015-11-24 10:32 ` Tomi Valkeinen [this message]
2015-11-24 10:32   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56543CA2.4090507@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=grygorii.strashko@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.