* PCIe regression with DRA7xx in 4.4-rc1
@ 2015-11-24 12:01 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 15+ messages in thread
From: Kishon Vijay Abraham I @ 2015-11-24 12:01 UTC (permalink / raw)
To: linux-pci, linux-kernel@vger.kernel.org, linux-omap, james.morse,
gabriel.fernandez, Minghuan.Lian, wangzhou1, gabriele.paoloni,
arnd, bhelgaas, pratyush.anand, Nori, Sekhar, jingoohan1,
linux-arm-kernel
Hi,
I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
designware: Make driver arch-agnostic").
Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I
observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
error, err_mask=0x4)"
Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine
but when I give ifconfig up, it fails.
If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe
cards starts to work fine again
Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine.
Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now.
Actually I'm not able to find any obvious problems with the patch and the irq
number and the memory resource also looks fine. Any idea what could be the problem?
[1] -> http://pastebin.ubuntu.com/13491456/
[2] -> http://pastebin.ubuntu.com/13491526/
[3] -> http://pastebin.ubuntu.com/13491658/
[4] -> http://pastebin.ubuntu.com/13491593/
Thanks
Kishon
^ permalink raw reply [flat|nested] 15+ messages in thread* PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:01 ` Kishon Vijay Abraham I 0 siblings, 0 replies; 15+ messages in thread From: Kishon Vijay Abraham I @ 2015-11-24 12:01 UTC (permalink / raw) To: linux-arm-kernel Hi, I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: designware: Make driver arch-agnostic"). Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)" Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine but when I give ifconfig up, it fails. If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe cards starts to work fine again Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. Actually I'm not able to find any obvious problems with the patch and the irq number and the memory resource also looks fine. Any idea what could be the problem? [1] -> http://pastebin.ubuntu.com/13491456/ [2] -> http://pastebin.ubuntu.com/13491526/ [3] -> http://pastebin.ubuntu.com/13491658/ [4] -> http://pastebin.ubuntu.com/13491593/ Thanks Kishon ^ permalink raw reply [flat|nested] 15+ messages in thread
* PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:01 ` Kishon Vijay Abraham I 0 siblings, 0 replies; 15+ messages in thread From: Kishon Vijay Abraham I @ 2015-11-24 12:01 UTC (permalink / raw) To: linux-pci, linux-kernel@vger.kernel.org, linux-omap, james.morse, gabriel.fernandez, Minghuan.Lian, wangzhou1, gabriele.paoloni, arnd, bhelgaas, pratyush.anand, Nori, Sekhar, jingoohan1, linux-arm-kernel Hi, I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: designware: Make driver arch-agnostic"). Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)" Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine but when I give ifconfig up, it fails. If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe cards starts to work fine again Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. Actually I'm not able to find any obvious problems with the patch and the irq number and the memory resource also looks fine. Any idea what could be the problem? [1] -> http://pastebin.ubuntu.com/13491456/ [2] -> http://pastebin.ubuntu.com/13491526/ [3] -> http://pastebin.ubuntu.com/13491658/ [4] -> http://pastebin.ubuntu.com/13491593/ Thanks Kishon ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: PCIe regression with DRA7xx in 4.4-rc1 2015-11-24 12:01 ` Kishon Vijay Abraham I (?) (?) @ 2015-11-24 12:08 ` Gabriele Paoloni -1 siblings, 0 replies; 15+ messages in thread From: Gabriele Paoloni @ 2015-11-24 12:08 UTC (permalink / raw) To: Kishon Vijay Abraham I, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, james.morse@arm.com, gabriel.fernandez@st.com, Minghuan.Lian@freescale.com, Wangzhou (B), arnd@arndb.de, bhelgaas@google.com, pratyush.anand@gmail.com, Nori, Sekhar, jingoohan1@gmail.com, linux-arm-kernel@lists.infradead.org Hi Kishon > -----Original Message----- > From: Kishon Vijay Abraham I [mailto:kishon@ti.com] > Sent: 24 November 2015 12:01 > To: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > omap@vger.kernel.org; james.morse@arm.com; gabriel.fernandez@st.com; > Minghuan.Lian@freescale.com; Wangzhou (B); Gabriele Paoloni; arnd@arndb.de; > bhelgaas@google.com; pratyush.anand@gmail.com; Nori, Sekhar; > jingoohan1@gmail.com; linux-arm-kernel@lists.infradead.org > Subject: PCIe regression with DRA7xx in 4.4-rc1 > > Hi, > > I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: > designware: Make driver arch-agnostic"). > > Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that > I > observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O > error, err_mask=0x4)" > May this be related to the bug flagged in: [PATCH] PCI: designware: remove wrong io_base assignment [...] diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 540f077c37ea..02a7452bdf23 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) ret, pp->io); continue; } - pp->io_base = pp->io->start; break; case IORESOURCE_MEM: pp->mem = win->res; -- 1.7.9.5 [...] Can you try to see if applying the patch above solves the issue? Thanks Gab > Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine > but when I give ifconfig up, it fails. > > If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe > cards starts to work fine again > > Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. > Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. > > Actually I'm not able to find any obvious problems with the patch and the irq > number and the memory resource also looks fine. Any idea what could be the > problem? > > [1] -> http://pastebin.ubuntu.com/13491456/ > [2] -> http://pastebin.ubuntu.com/13491526/ > > [3] -> http://pastebin.ubuntu.com/13491658/ > [4] -> http://pastebin.ubuntu.com/13491593/ > > Thanks > Kishon ^ permalink raw reply related [flat|nested] 15+ messages in thread
* RE: PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:08 ` Gabriele Paoloni 0 siblings, 0 replies; 15+ messages in thread From: Gabriele Paoloni @ 2015-11-24 12:08 UTC (permalink / raw) To: Kishon Vijay Abraham I, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, james.morse@arm.com, gabriel.fernandez@st.com, Minghuan.Lian@freescale.com, Wangzhou (B), arnd@arndb.de, bhelgaas@google.com, pratyush.anand@gmail.com, Nori, Sekhar, jingoohan1@gmail.com, linux-arm-kernel@lists.infradead.org [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2383 bytes --] Hi Kishon > -----Original Message----- > From: Kishon Vijay Abraham I [mailto:kishon@ti.com] > Sent: 24 November 2015 12:01 > To: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > omap@vger.kernel.org; james.morse@arm.com; gabriel.fernandez@st.com; > Minghuan.Lian@freescale.com; Wangzhou (B); Gabriele Paoloni; arnd@arndb.de; > bhelgaas@google.com; pratyush.anand@gmail.com; Nori, Sekhar; > jingoohan1@gmail.com; linux-arm-kernel@lists.infradead.org > Subject: PCIe regression with DRA7xx in 4.4-rc1 > > Hi, > > I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: > designware: Make driver arch-agnostic"). > > Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that > I > observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O > error, err_mask=0x4)" > May this be related to the bug flagged in: [PATCH] PCI: designware: remove wrong io_base assignment [...] diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 540f077c37ea..02a7452bdf23 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) ret, pp->io); continue; } - pp->io_base = pp->io->start; break; case IORESOURCE_MEM: pp->mem = win->res; -- 1.7.9.5 [...] Can you try to see if applying the patch above solves the issue? Thanks Gab > Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine > but when I give ifconfig up, it fails. > > If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe > cards starts to work fine again > > Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. > Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. > > Actually I'm not able to find any obvious problems with the patch and the irq > number and the memory resource also looks fine. Any idea what could be the > problem? > > [1] -> http://pastebin.ubuntu.com/13491456/ > [2] -> http://pastebin.ubuntu.com/13491526/ > > [3] -> http://pastebin.ubuntu.com/13491658/ > [4] -> http://pastebin.ubuntu.com/13491593/ > > Thanks > Kishon ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥ ^ permalink raw reply related [flat|nested] 15+ messages in thread
* PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:08 ` Gabriele Paoloni 0 siblings, 0 replies; 15+ messages in thread From: Gabriele Paoloni @ 2015-11-24 12:08 UTC (permalink / raw) To: linux-arm-kernel Hi Kishon > -----Original Message----- > From: Kishon Vijay Abraham I [mailto:kishon at ti.com] > Sent: 24 November 2015 12:01 > To: linux-pci at vger.kernel.org; linux-kernel at vger.kernel.org; linux- > omap at vger.kernel.org; james.morse at arm.com; gabriel.fernandez at st.com; > Minghuan.Lian at freescale.com; Wangzhou (B); Gabriele Paoloni; arnd at arndb.de; > bhelgaas at google.com; pratyush.anand at gmail.com; Nori, Sekhar; > jingoohan1 at gmail.com; linux-arm-kernel at lists.infradead.org > Subject: PCIe regression with DRA7xx in 4.4-rc1 > > Hi, > > I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: > designware: Make driver arch-agnostic"). > > Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that > I > observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O > error, err_mask=0x4)" > May this be related to the bug flagged in: [PATCH] PCI: designware: remove wrong io_base assignment [...] diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 540f077c37ea..02a7452bdf23 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) ret, pp->io); continue; } - pp->io_base = pp->io->start; break; case IORESOURCE_MEM: pp->mem = win->res; -- 1.7.9.5 [...] Can you try to see if applying the patch above solves the issue? Thanks Gab > Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine > but when I give ifconfig up, it fails. > > If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe > cards starts to work fine again > > Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. > Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. > > Actually I'm not able to find any obvious problems with the patch and the irq > number and the memory resource also looks fine. Any idea what could be the > problem? > > [1] -> http://pastebin.ubuntu.com/13491456/ > [2] -> http://pastebin.ubuntu.com/13491526/ > > [3] -> http://pastebin.ubuntu.com/13491658/ > [4] -> http://pastebin.ubuntu.com/13491593/ > > Thanks > Kishon ^ permalink raw reply related [flat|nested] 15+ messages in thread
* RE: PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:08 ` Gabriele Paoloni 0 siblings, 0 replies; 15+ messages in thread From: Gabriele Paoloni @ 2015-11-24 12:08 UTC (permalink / raw) To: Kishon Vijay Abraham I, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, james.morse@arm.com, gabriel.fernandez@st.com, Minghuan.Lian@freescale.com, Wangzhou (B), arnd@arndb.de, bhelgaas@google.com, pratyush.anand@gmail.com, Nori, Sekhar, jingoohan1@gmail.com, linux-arm-kernel@lists.infradead.org SGkgS2lzaG9uDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS2lzaG9u IFZpamF5IEFicmFoYW0gSSBbbWFpbHRvOmtpc2hvbkB0aS5jb21dDQo+IFNlbnQ6IDI0IE5vdmVt YmVyIDIwMTUgMTI6MDENCj4gVG86IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LQ0KPiBvbWFwQHZnZXIua2VybmVsLm9yZzsgamFt ZXMubW9yc2VAYXJtLmNvbTsgZ2FicmllbC5mZXJuYW5kZXpAc3QuY29tOw0KPiBNaW5naHVhbi5M aWFuQGZyZWVzY2FsZS5jb207IFdhbmd6aG91IChCKTsgR2FicmllbGUgUGFvbG9uaTsgYXJuZEBh cm5kYi5kZTsNCj4gYmhlbGdhYXNAZ29vZ2xlLmNvbTsgcHJhdHl1c2guYW5hbmRAZ21haWwuY29t OyBOb3JpLCBTZWtoYXI7DQo+IGppbmdvb2hhbjFAZ21haWwuY29tOyBsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gU3ViamVjdDogUENJZSByZWdyZXNzaW9uIHdpdGggRFJB N3h4IGluIDQuNC1yYzENCj4gDQo+IEhpLA0KPiANCj4gSSdtIHNlZWluZyBhIHJlZ3Jlc3Npb24g d2l0aCA8ZDFiOWNmMzEyNTJlOTA1YWQ1NjNiOWU4NjNmZDQ0NzBmNmMzZGQxYz4oIlBDSToNCj4g ZGVzaWdud2FyZTogTWFrZSBkcml2ZXIgYXJjaC1hZ25vc3RpYyIpLg0KPiANCj4gTG9ncyB1c2lu ZyBhIFNBVEEgUENJZSBjYXJkIFsxXS4gVGhlIFBDSWUgY2FyZCBlbnVtZXJhdGVzIGZpbmUgYnV0 IGFmdGVyIHRoYXQNCj4gSQ0KPiBvYnNlcnZlICJhdGEzLjAwOiBxYyB0aW1lb3V0IChjbWQgMHhl YyksIGF0YTMuMDA6IGZhaWxlZCB0byBJREVOVElGWSAoSS9PDQo+IGVycm9yLCBlcnJfbWFzaz0w eDQpIg0KPiANCg0KTWF5IHRoaXMgYmUgcmVsYXRlZCB0byB0aGUgYnVnIGZsYWdnZWQgaW46DQoN CltQQVRDSF0gUENJOiBkZXNpZ253YXJlOiByZW1vdmUgd3JvbmcgaW9fYmFzZSBhc3NpZ25tZW50 DQoNClsuLi5dDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvaG9zdC9wY2llLWRlc2lnbndhcmUu YyBiL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1kZXNpZ253YXJlLmMNCmluZGV4IDU0MGYwNzdjMzdl YS4uMDJhNzQ1MmJkZjIzIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9wY2kvaG9zdC9wY2llLWRlc2ln bndhcmUuYw0KKysrIGIvZHJpdmVycy9wY2kvaG9zdC9wY2llLWRlc2lnbndhcmUuYw0KQEAgLTQ0 MCw3ICs0NDAsNiBAQCBpbnQgZHdfcGNpZV9ob3N0X2luaXQoc3RydWN0IHBjaWVfcG9ydCAqcHAp DQogCQkJCQkgcmV0LCBwcC0+aW8pOw0KIAkJCQljb250aW51ZTsNCiAJCQl9DQotCQkJcHAtPmlv X2Jhc2UgPSBwcC0+aW8tPnN0YXJ0Ow0KIAkJCWJyZWFrOw0KIAkJY2FzZSBJT1JFU09VUkNFX01F TToNCiAJCQlwcC0+bWVtID0gd2luLT5yZXM7DQotLSANCjEuNy45LjUNClsuLi5dDQoNCkNhbiB5 b3UgdHJ5IHRvIHNlZSBpZiBhcHBseWluZyB0aGUgcGF0Y2ggYWJvdmUgc29sdmVzIHRoZSBpc3N1 ZT8NCg0KVGhhbmtzDQoNCkdhYg0KDQo+IExvZ3MgdXNpbmcgYSBFdGhlbmV0IFBDSWUgY2FyZCBb Ml0uIEFnYWluIGhlcmUgdGhlIFBDSWUgY2FyZCBlbnVtZXJhdGVzIGZpbmUNCj4gYnV0IHdoZW4g SSBnaXZlIGlmY29uZmlnIHVwLCBpdCBmYWlscy4NCj4gDQo+IElmIEkganVzdCByZXZlcnQgY29t bWl0IDxkMWI5Y2YzMTI1MmU5MDVhZDU2M2I5ZTg2M2ZkNDQ3MGY2YzNkZDFjPiwgdGhlIFBDSWUN Cj4gY2FyZHMgc3RhcnRzIHRvIHdvcmsgZmluZSBhZ2Fpbg0KPiANCj4gTG9ncyB1c2luZyBhIFNB VEEgUENJZSBjYXJkIFszXS4gSGVyZSB0aGUgS0lOR1NUT04gU1NEIGdldHMgZGV0ZWN0ZWQgZmlu ZS4NCj4gTG9ncyB1c2luZyBhIEV0aGVybmV0IFBDSWUgY2FyZCBbNF0uIEknbSBhYmxlIHRvIGRv IHBpbmcgdGVzdHMgbm93Lg0KPiANCj4gQWN0dWFsbHkgSSdtIG5vdCBhYmxlIHRvIGZpbmQgYW55 IG9idmlvdXMgcHJvYmxlbXMgd2l0aCB0aGUgcGF0Y2ggYW5kIHRoZSBpcnENCj4gbnVtYmVyIGFu ZCB0aGUgbWVtb3J5IHJlc291cmNlIGFsc28gbG9va3MgZmluZS4gQW55IGlkZWEgd2hhdCBjb3Vs ZCBiZSB0aGUNCj4gcHJvYmxlbT8NCj4gDQo+IFsxXSAtPiBodHRwOi8vcGFzdGViaW4udWJ1bnR1 LmNvbS8xMzQ5MTQ1Ni8NCj4gWzJdIC0+IGh0dHA6Ly9wYXN0ZWJpbi51YnVudHUuY29tLzEzNDkx NTI2Lw0KPiANCj4gWzNdIC0+IGh0dHA6Ly9wYXN0ZWJpbi51YnVudHUuY29tLzEzNDkxNjU4Lw0K PiBbNF0gLT4gaHR0cDovL3Bhc3RlYmluLnVidW50dS5jb20vMTM0OTE1OTMvDQo+IA0KPiBUaGFu a3MNCj4gS2lzaG9uDQo= ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: PCIe regression with DRA7xx in 4.4-rc1 2015-11-24 12:08 ` Gabriele Paoloni @ 2015-11-24 12:18 ` Kishon Vijay Abraham I -1 siblings, 0 replies; 15+ messages in thread From: Kishon Vijay Abraham I @ 2015-11-24 12:18 UTC (permalink / raw) To: Gabriele Paoloni, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, james.morse@arm.com, gabriel.fernandez@st.com, Minghuan.Lian@freescale.com, Wangzhou (B), arnd@arndb.de, bhelgaas@google.com, pratyush.anand@gmail.com, Nori, Sekhar, jingoohan1@gmail.com, linux-arm-kernel@lists.infradead.org Hi, On Tuesday 24 November 2015 05:38 PM, Gabriele Paoloni wrote: > Hi Kishon > >> -----Original Message----- >> From: Kishon Vijay Abraham I [mailto:kishon@ti.com] >> Sent: 24 November 2015 12:01 >> To: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> omap@vger.kernel.org; james.morse@arm.com; gabriel.fernandez@st.com; >> Minghuan.Lian@freescale.com; Wangzhou (B); Gabriele Paoloni; arnd@arndb.de; >> bhelgaas@google.com; pratyush.anand@gmail.com; Nori, Sekhar; >> jingoohan1@gmail.com; linux-arm-kernel@lists.infradead.org >> Subject: PCIe regression with DRA7xx in 4.4-rc1 >> >> Hi, >> >> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: >> designware: Make driver arch-agnostic"). >> >> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that >> I >> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O >> error, err_mask=0x4)" >> > > May this be related to the bug flagged in: > > [PATCH] PCI: designware: remove wrong io_base assignment > > [...] > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 540f077c37ea..02a7452bdf23 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) > ret, pp->io); > continue; > } > - pp->io_base = pp->io->start; > break; > case IORESOURCE_MEM: > pp->mem = win->res; > yes, this indeed solved the bug. Thanks Kishon ^ permalink raw reply [flat|nested] 15+ messages in thread
* PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:18 ` Kishon Vijay Abraham I 0 siblings, 0 replies; 15+ messages in thread From: Kishon Vijay Abraham I @ 2015-11-24 12:18 UTC (permalink / raw) To: linux-arm-kernel Hi, On Tuesday 24 November 2015 05:38 PM, Gabriele Paoloni wrote: > Hi Kishon > >> -----Original Message----- >> From: Kishon Vijay Abraham I [mailto:kishon at ti.com] >> Sent: 24 November 2015 12:01 >> To: linux-pci at vger.kernel.org; linux-kernel at vger.kernel.org; linux- >> omap at vger.kernel.org; james.morse at arm.com; gabriel.fernandez at st.com; >> Minghuan.Lian at freescale.com; Wangzhou (B); Gabriele Paoloni; arnd at arndb.de; >> bhelgaas at google.com; pratyush.anand at gmail.com; Nori, Sekhar; >> jingoohan1 at gmail.com; linux-arm-kernel at lists.infradead.org >> Subject: PCIe regression with DRA7xx in 4.4-rc1 >> >> Hi, >> >> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: >> designware: Make driver arch-agnostic"). >> >> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that >> I >> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O >> error, err_mask=0x4)" >> > > May this be related to the bug flagged in: > > [PATCH] PCI: designware: remove wrong io_base assignment > > [...] > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 540f077c37ea..02a7452bdf23 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) > ret, pp->io); > continue; > } > - pp->io_base = pp->io->start; > break; > case IORESOURCE_MEM: > pp->mem = win->res; > yes, this indeed solved the bug. Thanks Kishon ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: PCIe regression with DRA7xx in 4.4-rc1 2015-11-24 12:01 ` Kishon Vijay Abraham I (?) @ 2015-11-24 12:14 ` Jisheng Zhang -1 siblings, 0 replies; 15+ messages in thread From: Jisheng Zhang @ 2015-11-24 12:14 UTC (permalink / raw) To: Kishon Vijay Abraham I Cc: linux-pci, linux-kernel@vger.kernel.org, linux-omap, james.morse, gabriel.fernandez, Minghuan.Lian, wangzhou1, gabriele.paoloni, arnd, bhelgaas, pratyush.anand, Nori, Sekhar, jingoohan1, linux-arm-kernel On Tue, 24 Nov 2015 17:31:07 +0530 Kishon Vijay Abraham I wrote: > Hi, > > I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: > designware: Make driver arch-agnostic"). > > Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I > observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O > error, err_mask=0x4)" > > Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine > but when I give ifconfig up, it fails. > > If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe > cards starts to work fine again FYI, maybe the patch can fix the regression. http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html > > Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. > Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. > > Actually I'm not able to find any obvious problems with the patch and the irq > number and the memory resource also looks fine. Any idea what could be the problem? > > [1] -> http://pastebin.ubuntu.com/13491456/ > [2] -> http://pastebin.ubuntu.com/13491526/ > > [3] -> http://pastebin.ubuntu.com/13491658/ > [4] -> http://pastebin.ubuntu.com/13491593/ > > Thanks > Kishon > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:14 ` Jisheng Zhang 0 siblings, 0 replies; 15+ messages in thread From: Jisheng Zhang @ 2015-11-24 12:14 UTC (permalink / raw) To: linux-arm-kernel On Tue, 24 Nov 2015 17:31:07 +0530 Kishon Vijay Abraham I wrote: > Hi, > > I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: > designware: Make driver arch-agnostic"). > > Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I > observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O > error, err_mask=0x4)" > > Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine > but when I give ifconfig up, it fails. > > If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe > cards starts to work fine again FYI, maybe the patch can fix the regression. http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html > > Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. > Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. > > Actually I'm not able to find any obvious problems with the patch and the irq > number and the memory resource also looks fine. Any idea what could be the problem? > > [1] -> http://pastebin.ubuntu.com/13491456/ > [2] -> http://pastebin.ubuntu.com/13491526/ > > [3] -> http://pastebin.ubuntu.com/13491658/ > [4] -> http://pastebin.ubuntu.com/13491593/ > > Thanks > Kishon > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:14 ` Jisheng Zhang 0 siblings, 0 replies; 15+ messages in thread From: Jisheng Zhang @ 2015-11-24 12:14 UTC (permalink / raw) To: Kishon Vijay Abraham I Cc: linux-pci, linux-kernel@vger.kernel.org, linux-omap, james.morse, gabriel.fernandez, Minghuan.Lian, wangzhou1, gabriele.paoloni, arnd, bhelgaas, pratyush.anand, Nori, Sekhar, jingoohan1, linux-arm-kernel On Tue, 24 Nov 2015 17:31:07 +0530 Kishon Vijay Abraham I wrote: > Hi, > > I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: > designware: Make driver arch-agnostic"). > > Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I > observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O > error, err_mask=0x4)" > > Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine > but when I give ifconfig up, it fails. > > If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe > cards starts to work fine again FYI, maybe the patch can fix the regression. http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html > > Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. > Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. > > Actually I'm not able to find any obvious problems with the patch and the irq > number and the memory resource also looks fine. Any idea what could be the problem? > > [1] -> http://pastebin.ubuntu.com/13491456/ > [2] -> http://pastebin.ubuntu.com/13491526/ > > [3] -> http://pastebin.ubuntu.com/13491658/ > [4] -> http://pastebin.ubuntu.com/13491593/ > > Thanks > Kishon > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: PCIe regression with DRA7xx in 4.4-rc1 2015-11-24 12:14 ` Jisheng Zhang (?) @ 2015-11-24 12:59 ` Kishon Vijay Abraham I -1 siblings, 0 replies; 15+ messages in thread From: Kishon Vijay Abraham I @ 2015-11-24 12:59 UTC (permalink / raw) To: Jisheng Zhang Cc: linux-pci, linux-kernel@vger.kernel.org, linux-omap, james.morse, gabriel.fernandez, Minghuan.Lian, wangzhou1, gabriele.paoloni, arnd, bhelgaas, pratyush.anand, Nori, Sekhar, jingoohan1, linux-arm-kernel Hi, On Tuesday 24 November 2015 05:44 PM, Jisheng Zhang wrote: > > > On Tue, 24 Nov 2015 17:31:07 +0530 > Kishon Vijay Abraham I wrote: > >> Hi, >> >> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: >> designware: Make driver arch-agnostic"). >> >> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I >> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O >> error, err_mask=0x4)" >> >> Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine >> but when I give ifconfig up, it fails. >> >> If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe >> cards starts to work fine again > > FYI, maybe the patch can fix the regression. > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html yes, it fixed. Thanks Kishon > >> >> Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. >> Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. >> >> Actually I'm not able to find any obvious problems with the patch and the irq >> number and the memory resource also looks fine. Any idea what could be the problem? >> >> [1] -> http://pastebin.ubuntu.com/13491456/ >> [2] -> http://pastebin.ubuntu.com/13491526/ >> >> [3] -> http://pastebin.ubuntu.com/13491658/ >> [4] -> http://pastebin.ubuntu.com/13491593/ >> >> Thanks >> Kishon >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 15+ messages in thread
* PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:59 ` Kishon Vijay Abraham I 0 siblings, 0 replies; 15+ messages in thread From: Kishon Vijay Abraham I @ 2015-11-24 12:59 UTC (permalink / raw) To: linux-arm-kernel Hi, On Tuesday 24 November 2015 05:44 PM, Jisheng Zhang wrote: > > > On Tue, 24 Nov 2015 17:31:07 +0530 > Kishon Vijay Abraham I wrote: > >> Hi, >> >> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: >> designware: Make driver arch-agnostic"). >> >> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I >> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O >> error, err_mask=0x4)" >> >> Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine >> but when I give ifconfig up, it fails. >> >> If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe >> cards starts to work fine again > > FYI, maybe the patch can fix the regression. > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html yes, it fixed. Thanks Kishon > >> >> Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. >> Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. >> >> Actually I'm not able to find any obvious problems with the patch and the irq >> number and the memory resource also looks fine. Any idea what could be the problem? >> >> [1] -> http://pastebin.ubuntu.com/13491456/ >> [2] -> http://pastebin.ubuntu.com/13491526/ >> >> [3] -> http://pastebin.ubuntu.com/13491658/ >> [4] -> http://pastebin.ubuntu.com/13491593/ >> >> Thanks >> Kishon >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel at lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: PCIe regression with DRA7xx in 4.4-rc1 @ 2015-11-24 12:59 ` Kishon Vijay Abraham I 0 siblings, 0 replies; 15+ messages in thread From: Kishon Vijay Abraham I @ 2015-11-24 12:59 UTC (permalink / raw) To: Jisheng Zhang Cc: linux-pci, linux-kernel@vger.kernel.org, linux-omap, james.morse, gabriel.fernandez, Minghuan.Lian, wangzhou1, gabriele.paoloni, arnd, bhelgaas, pratyush.anand, Nori, Sekhar, jingoohan1, linux-arm-kernel Hi, On Tuesday 24 November 2015 05:44 PM, Jisheng Zhang wrote: > > > On Tue, 24 Nov 2015 17:31:07 +0530 > Kishon Vijay Abraham I wrote: > >> Hi, >> >> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI: >> designware: Make driver arch-agnostic"). >> >> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that I >> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O >> error, err_mask=0x4)" >> >> Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine >> but when I give ifconfig up, it fails. >> >> If I just revert commit <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>, the PCIe >> cards starts to work fine again > > FYI, maybe the patch can fix the regression. > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/387362.html yes, it fixed. Thanks Kishon > >> >> Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. >> Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. >> >> Actually I'm not able to find any obvious problems with the patch and the irq >> number and the memory resource also looks fine. Any idea what could be the problem? >> >> [1] -> http://pastebin.ubuntu.com/13491456/ >> [2] -> http://pastebin.ubuntu.com/13491526/ >> >> [3] -> http://pastebin.ubuntu.com/13491658/ >> [4] -> http://pastebin.ubuntu.com/13491593/ >> >> Thanks >> Kishon >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-11-24 12:59 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-24 12:01 PCIe regression with DRA7xx in 4.4-rc1 Kishon Vijay Abraham I 2015-11-24 12:01 ` Kishon Vijay Abraham I 2015-11-24 12:01 ` Kishon Vijay Abraham I 2015-11-24 12:08 ` Gabriele Paoloni 2015-11-24 12:08 ` Gabriele Paoloni 2015-11-24 12:08 ` Gabriele Paoloni 2015-11-24 12:08 ` Gabriele Paoloni 2015-11-24 12:18 ` Kishon Vijay Abraham I 2015-11-24 12:18 ` Kishon Vijay Abraham I 2015-11-24 12:14 ` Jisheng Zhang 2015-11-24 12:14 ` Jisheng Zhang 2015-11-24 12:14 ` Jisheng Zhang 2015-11-24 12:59 ` Kishon Vijay Abraham I 2015-11-24 12:59 ` Kishon Vijay Abraham I 2015-11-24 12:59 ` Kishon Vijay Abraham I
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.