All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/kexec: Hide more kexec infrastructure behind CONFIG_KEXEC
@ 2015-11-24 16:23 Andrew Cooper
  2015-11-24 16:24 ` David Vrabel
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2015-11-24 16:23 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Doug Goldstein, David Vrabel, Jan Beulich

Experimenting with the kconfig series showed that various bits of kexec
infrastructure were still being unconditionally included.  Make them
conditional on CONFIG_KEXEC.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: David Vrabel <david.vrabel@citrix.com>
CC: Doug Goldstein <cardoe@cardoe.com>

This patch is independent of the kconfig series.
---
 xen/arch/x86/x86_64/Makefile | 4 ++--
 xen/arch/x86/xen.lds.S       | 4 ++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/x86_64/Makefile b/xen/arch/x86/x86_64/Makefile
index d5af722..5b54c16 100644
--- a/xen/arch/x86/x86_64/Makefile
+++ b/xen/arch/x86/x86_64/Makefile
@@ -3,7 +3,7 @@ subdir-y += compat
 obj-bin-y += entry.o
 obj-bin-y += gpr_switch.o
 obj-y += traps.o
-obj-y += machine_kexec.o
+obj-$(CONFIG_KEXEC) += machine_kexec.o
 obj-y += pci.o
 obj-y += acpi_mmcfg.o
 obj-y += mmconf-fam10h.o
@@ -12,6 +12,6 @@ obj-y += mmconfig-shared.o
 obj-y += domain.o
 obj-y += cpu_idle.o
 obj-y += cpufreq.o
-obj-bin-y += kexec_reloc.o
+obj-bin-$(CONFIG_KEXEC) += kexec_reloc.o
 
 obj-$(crash_debug)   += gdbstub.o
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 6553cff..e18e08f 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -220,5 +220,9 @@ SECTIONS
 ASSERT(__image_base__ > XEN_VIRT_START ||
        _end <= XEN_VIRT_END - NR_CPUS * PAGE_SIZE,
        "Xen image overlaps stubs area")
+
+#ifdef CONFIG_KEXEC
 ASSERT(kexec_reloc_size - kexec_reloc <= PAGE_SIZE, "kexec_reloc is too large")
+#endif
+
 ASSERT((cpu0_stack & (STACK_SIZE - 1)) == 0, "cpu0_stack misaligned")
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86/kexec: Hide more kexec infrastructure behind CONFIG_KEXEC
  2015-11-24 16:23 [PATCH] x86/kexec: Hide more kexec infrastructure behind CONFIG_KEXEC Andrew Cooper
@ 2015-11-24 16:24 ` David Vrabel
  0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2015-11-24 16:24 UTC (permalink / raw)
  To: Andrew Cooper, Xen-devel; +Cc: Doug Goldstein, Jan Beulich

On 24/11/15 16:23, Andrew Cooper wrote:
> Experimenting with the kconfig series showed that various bits of kexec
> infrastructure were still being unconditionally included.  Make them
> conditional on CONFIG_KEXEC.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

David

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-24 16:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-24 16:23 [PATCH] x86/kexec: Hide more kexec infrastructure behind CONFIG_KEXEC Andrew Cooper
2015-11-24 16:24 ` David Vrabel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.