All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
To: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Cc: Gennady Kuznetsov <kuznetsovg@dev.rtsoft.ru>,
	Andrey Rusalin <arusalin@dev.rtsoft.ru>
Subject: imx6dl.dtsi gpu clock definition bug
Date: Tue, 24 Nov 2015 20:04:31 +0300	[thread overview]
Message-ID: <5654989F.6030009@dev.rtsoft.ru> (raw)

Hi

Both in linux-imx branch imx_3.14.28_1.0.0_ga, and in linux-fslc branch
3.14-1.0.x-mx6, in arch/arm/boot/dts/imx6dl.dtsi file, in gpu@00130000,
clock definition is inconsistent:

clocks = <&clks IMX6QDL_CLK_OPENVG_AXI>, <&clks IMX6QDL_CLK_GPU3D_AXI>,
         <&clks IMX6QDL_CLK_GPU2D_CORE>, <&clks IMX6QDL_CLK_GPU3D_CORE>,
         <&clks IMX6QDL_CLK_DUMMY>;
clock-names = "gpu2d_axi_clk", "gpu3d_axi_clk",
              "gpu2d_clk", "gpu3d_clk",
              "gpu3d_shader_clk";

i.e first entry in "clocks" refers to openvg_axi clk, but name refers to
gpu2d_axi clk


This causes

[    1.331535] galcore: clk_get vg clock failed, disable vg!

and may cause unknown misfunctions.


Corresponding part of arch/arm/boot/dts/imx6q.dtsi file:

clocks = <&clks IMX6QDL_CLK_GPU2D_AXI>, <&clks IMX6QDL_CLK_OPENVG_AXI>,
         <&clks IMX6QDL_CLK_GPU3D_AXI>, <&clks IMX6QDL_CLK_GPU2D_CORE>,
       <&clks IMX6QDL_CLK_GPU3D_CORE>, <&clks IMX6QDL_CLK_GPU3D_SHADER>;
clock-names = "gpu2d_axi_clk", "openvg_axi_clk",
              "gpu3d_axi_clk", "gpu2d_clk",
              "gpu3d_clk", "gpu3d_shader_clk";


Is definition of 5 clocks instead of 6 in imx6dl.dtsi intensional?
If so - which one clock should be missing, gpu2d_axi or openvg_axi?


                 reply	other threads:[~2015-11-24 17:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5654989F.6030009@dev.rtsoft.ru \
    --to=nyushchenko@dev.rtsoft.ru \
    --cc=arusalin@dev.rtsoft.ru \
    --cc=kuznetsovg@dev.rtsoft.ru \
    --cc=meta-freescale@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.