From: Doug Goldstein <cardoe@cardoe.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Mukesh Rathor <mukesh.rathor@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 3/4] gdbsx: prefer privcmd character device
Date: Tue, 24 Nov 2015 14:11:44 -0600 [thread overview]
Message-ID: <5654C480.3080606@cardoe.com> (raw)
In-Reply-To: <5654B84E.3020306@cardoe.com>
[-- Attachment #1.1: Type: text/plain, Size: 726 bytes --]
On 11/24/15 1:19 PM, Doug Goldstein wrote:
> On 11/24/15 12:53 PM, Ian Jackson wrote:
>> Doug Goldstein writes ("[PATCH 3/4] gdbsx: prefer privcmd character device"):
>>> Prefer using the character device over the proc file if the character
>>> device exists.
>>
>> I think this common logic (which also appears in your 1/4 patch)
>> should be factored out.
>>
>> Could gdbsx not use a libxc handle ?
>>
>> Ian.
>>
>
> I agree. I actually emailed the maintainer about this but his address
> bounced so I left it as the simpler patch instead. I can make that
> chance and resubmit if you'd prefer.
>
I'll just drop this out of the v2 and look at improving it in another
series.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-24 20:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 18:47 [PATCH 1/4] libxc: prefer using privcmd character device Doug Goldstein
2015-11-24 18:47 ` [PATCH 2/4] update outdated header comment on privcmd.h Doug Goldstein
2015-11-24 18:52 ` Ian Jackson
2015-11-24 18:47 ` [PATCH 3/4] gdbsx: prefer privcmd character device Doug Goldstein
2015-11-24 18:53 ` Ian Jackson
2015-11-24 19:19 ` Doug Goldstein
2015-11-24 20:11 ` Doug Goldstein [this message]
2015-11-25 11:14 ` Ian Jackson
2015-11-25 11:13 ` Ian Campbell
2015-11-24 18:47 ` [PATCH 4/4] xendomains initscript: test for privcmd char device Doug Goldstein
2015-11-24 18:53 ` Ian Jackson
2015-11-24 18:52 ` [PATCH 1/4] libxc: prefer using privcmd character device Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5654C480.3080606@cardoe.com \
--to=cardoe@cardoe.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=mukesh.rathor@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.